)]}'
{"designate/notification_handler/base.py":[{"author":{"_account_id":4894,"name":"stanzgy","email":"stanzgy@gmail.com","username":"stanzgy"},"change_message_id":"979a7d4369e17d085fe51e6f4b2401bbd2e7cca7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            event_data \u003d data.copy()"},{"line_number":140,"context_line":"            event_data.update(self._get_ip_data(addr))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"            for fmt in cfg.CONF[self.name].get(\u0027format\u0027):"},{"line_number":143,"context_line":"                recordset_values \u003d {"},{"line_number":144,"context_line":"                    \u0027domain_id\u0027: domain[\u0027id\u0027],"},{"line_number":145,"context_line":"                    \u0027name\u0027: fmt % event_data,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_c1fa1543","line":142,"updated":"2015-05-05 03:43:51.000000000","message":"should be \u0027fmt in self._get_format()\u0027 which handles the default scenario","commit_id":"639dbd35e1f4f28724bd00c38493b26098cad5f6"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"567945848233ff9952708f605d9661684a29af38","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class BaseAddressHandler(NotificationHandler):"},{"line_number":88,"context_line":"    default_format \u003d [\u0027%(octet0)s-%(octet1)s-%(octet2)s-%(octet3)s.%(domain)s\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_ip_data(self, addr_dict):"},{"line_number":91,"context_line":"        ip \u003d addr_dict[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_4c9e9f57","line":88,"updated":"2015-05-06 18:37:34.000000000","message":"As far as I see, this attribute is not used anywhere, because _get_format method is not used anymore. IMO you should put this in designate/notification_handler/neutron.py and designate/notification_handler/nova.py as a default value when using oslo.config.","commit_id":"9926c175c8683bfd9bb172db2908b4f500233cc8"}]}