)]}'
{"designate/api/v1/records.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"86c7486bbcfc673461e30005e6e7bbb932336ca9","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    criterion \u003d {\u0027domain_id\u0027: domain_id, \u0027id\u0027: record_id}"},{"line_number":264,"context_line":"    record \u003d central_api.find_record(context, criterion)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    # Cannot delete a managed record via the API."},{"line_number":267,"context_line":"    if record[\u0027managed\u0027] is True:"},{"line_number":268,"context_line":"        raise exceptions.BadRequest(\u0027Managed records may not be deleted\u0027)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_6e8471d3","line":266,"updated":"2015-04-08 18:13:33.000000000","message":"How about changing this too?","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c36f773ff4f324c1d933e7f793ce40da04807b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    criterion \u003d {\u0027domain_id\u0027: domain_id, \u0027id\u0027: record_id}"},{"line_number":264,"context_line":"    record \u003d central_api.find_record(context, criterion)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    # Cannot delete a managed record via the API."},{"line_number":267,"context_line":"    if record[\u0027managed\u0027] is True:"},{"line_number":268,"context_line":"        raise exceptions.BadRequest(\u0027Managed records may not be deleted\u0027)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b973e114","line":266,"in_reply_to":"9aa53dc9_6e8471d3","updated":"2015-04-08 18:21:10.000000000","message":"yup - good catch\nDone","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"}],"designate/api/v2/controllers/recordsets.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"86c7486bbcfc673461e30005e6e7bbb932336ca9","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        return DesignateAdapter.render(\u0027API_v2\u0027, recordset, request\u003drequest)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json\u0027)"},{"line_number":176,"context_line":"    @utils.validate_uuid(\u0027zone_id\u0027, \u0027recordset_id\u0027)"},{"line_number":177,"context_line":"    def delete_one(self, zone_id, recordset_id):"},{"line_number":178,"context_line":"        \"\"\"Delete RecordSet\"\"\""},{"line_number":179,"context_line":"        request \u003d pecan.request"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_4ed52db7","line":176,"updated":"2015-04-08 18:13:33.000000000","message":"A managed check is needed in this method too.","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c36f773ff4f324c1d933e7f793ce40da04807b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        return DesignateAdapter.render(\u0027API_v2\u0027, recordset, request\u003drequest)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json\u0027)"},{"line_number":176,"context_line":"    @utils.validate_uuid(\u0027zone_id\u0027, \u0027recordset_id\u0027)"},{"line_number":177,"context_line":"    def delete_one(self, zone_id, recordset_id):"},{"line_number":178,"context_line":"        \"\"\"Delete RecordSet\"\"\""},{"line_number":179,"context_line":"        request \u003d pecan.request"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_590df58e","line":176,"in_reply_to":"9aa53dc9_4ed52db7","updated":"2015-04-08 18:21:10.000000000","message":"The checks in Central will catch this one. \n\nThe only reason that the one above is there is if you removed all of the managed records, the managed property would be false, and you would be able to edit it.","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"}],"designate/objects/recordset.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"86c7486bbcfc673461e30005e6e7bbb932336ca9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def managed(self):"},{"line_number":53,"context_line":"        managed \u003d False"},{"line_number":54,"context_line":"        for record in self.records:"},{"line_number":55,"context_line":"            if record.managed:"},{"line_number":56,"context_line":"                return True"},{"line_number":57,"context_line":"        return managed"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_7909d9dc","line":55,"updated":"2015-04-08 18:13:33.000000000","message":"soa and ns records are marked as managed. so it would appear that all recordsets would be managed.","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c36f773ff4f324c1d933e7f793ce40da04807b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def managed(self):"},{"line_number":53,"context_line":"        managed \u003d False"},{"line_number":54,"context_line":"        for record in self.records:"},{"line_number":55,"context_line":"            if record.managed:"},{"line_number":56,"context_line":"                return True"},{"line_number":57,"context_line":"        return managed"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_79e1d9cf","line":55,"in_reply_to":"9aa53dc9_7909d9dc","updated":"2015-04-08 18:21:10.000000000","message":"nope, just the recordsets that are managed SOA and NS recordsets. This only runs on records in the individual RRset","commit_id":"b7a90d440d739b79068c5147227584e2e7c1dd58"}]}