)]}'
{"contrib/devstack/gate_hook.sh":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"23d2eb998835f4ed9e0947981261f4626175106c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"echo \"DESIGNATE_PERIODIC_RECOVERY_INTERVAL\u003d20\" \u003e\u003e $BASE/new/devstack/localrc"},{"line_number":15,"context_line":"echo \"DESIGNATE_PERIODIC_SYNC_INTERVAL\u003d20\" \u003e\u003e $BASE/new/devstack/localrc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"echo \"LIBS_FROM_GIT\u003dtempest-lib\" \u003e\u003e $BASE/new/devstack/localrc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Pass through any DESIGNATE_ env vars to the localrc file"},{"line_number":20,"context_line":"env | grep -E \"^DESIGNATE_\" \u003e\u003e $BASE/new/devstack/localrc || :"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3afb71cf_74857bab","line":17,"updated":"2015-06-08 14:24:49.000000000","message":"Can we get this into it\u0027s own change? That way, the revert when tempest-lib releases is easy.","commit_id":"c444023cc828b069f864602e2acb559b325d322a"}],"functionaltests/api/v2/base.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"91dbb011700400d580cd1f9a989d12b685ed7601","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u00272fdadfb1-cf96-4259-ac6b-bb7b6d2ff98g\u0027,"},{"line_number":25,"context_line":"    \u00272fdadfb1cf964259ac6bbb7b6d2ff9GG\u0027,"},{"line_number":26,"context_line":"    \u002712345\u0027"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DesignateV2Test(BaseDesignateTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_aaedb2f0","line":27,"updated":"2015-05-18 16:02:00.000000000","message":"I don\u0027t think these are being used anywhere?","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"5c6e168de3bb0df38a95bcdef3ef1ca3f162ea91","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u00272fdadfb1-cf96-4259-ac6b-bb7b6d2ff98g\u0027,"},{"line_number":25,"context_line":"    \u00272fdadfb1cf964259ac6bbb7b6d2ff9GG\u0027,"},{"line_number":26,"context_line":"    \u002712345\u0027"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DesignateV2Test(BaseDesignateTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_fdb01645","line":27,"in_reply_to":"7a016987_aaedb2f0","updated":"2015-05-18 16:43:14.000000000","message":"Done","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"}],"functionaltests/api/v2/test_tld.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"91dbb011700400d580cd1f9a989d12b685ed7601","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        resp, old_model \u003d self._create_tld(post_model)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        patch_model \u003d datagen.random_tld_data()"},{"line_number":46,"context_line":"        del patch_model.name  # don\u0027t try to override the tld name"},{"line_number":47,"context_line":"        resp, new_model \u003d TLDClient.as_user(\u0027admin\u0027).patch_tld("},{"line_number":48,"context_line":"            old_model.id, patch_model)"},{"line_number":49,"context_line":"        self.assertEqual(resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_e7d763bd","line":46,"updated":"2015-05-18 16:02:00.000000000","message":"I don\u0027t think we need this del. Designate lets you update the tld name on a patch, so we should test that here.","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"5c6e168de3bb0df38a95bcdef3ef1ca3f162ea91","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        resp, old_model \u003d self._create_tld(post_model)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        patch_model \u003d datagen.random_tld_data()"},{"line_number":46,"context_line":"        del patch_model.name  # don\u0027t try to override the tld name"},{"line_number":47,"context_line":"        resp, new_model \u003d TLDClient.as_user(\u0027admin\u0027).patch_tld("},{"line_number":48,"context_line":"            old_model.id, patch_model)"},{"line_number":49,"context_line":"        self.assertEqual(resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9db5a232","line":46,"in_reply_to":"7a016987_e7d763bd","updated":"2015-05-18 16:43:14.000000000","message":"Done","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"91dbb011700400d580cd1f9a989d12b685ed7601","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        client \u003d TLDClient.as_user(\u0027admin\u0027)"},{"line_number":77,"context_line":"        self._assert_exception("},{"line_number":78,"context_line":"            exceptions.NotFound, \u0027tld_not_found\u0027, 404, client.delete_tld,"},{"line_number":79,"context_line":"            str(uuid.uuid4()))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_get_tld_invalid_uuid(self):"},{"line_number":82,"context_line":"        client \u003d TLDClient.as_user(\u0027admin\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6a09fadc","line":79,"updated":"2015-05-18 16:02:00.000000000","message":"self.assertRaises should return the caught exception, so you can do:\n\n    e \u003d self.assertRaises(exceptions.NotFound, client.delete_tld, str(uuid.uuid4())\n    self.assertEqual(e.resp_body[\u0027code\u0027], 404)\n    ...","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"5c6e168de3bb0df38a95bcdef3ef1ca3f162ea91","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        client \u003d TLDClient.as_user(\u0027admin\u0027)"},{"line_number":77,"context_line":"        self._assert_exception("},{"line_number":78,"context_line":"            exceptions.NotFound, \u0027tld_not_found\u0027, 404, client.delete_tld,"},{"line_number":79,"context_line":"            str(uuid.uuid4()))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_get_tld_invalid_uuid(self):"},{"line_number":82,"context_line":"        client \u003d TLDClient.as_user(\u0027admin\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_1d809245","line":79,"in_reply_to":"7a016987_6a09fadc","updated":"2015-05-18 16:43:14.000000000","message":"I did it this way to contain the code in one place..","commit_id":"95cace41e7a7fa0e86e6454a36df6390d47eff32"}],"functionaltests/api/v2/test_zone.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"7612f1dbba3dfe77006f39b7e34a4c313d9430c9","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def setup(self):"},{"line_number":75,"context_line":"        super(ZoneTest, self).setUp()"},{"line_number":76,"context_line":"        self.increase_quotas(user\u003d\u0027default\u0027)"},{"line_number":77,"context_line":"        self.increase_quotas(user\u003d\u0027alt\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _create_zone(self, zone_model, user):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_a16b77f0","line":76,"updated":"2015-06-09 16:50:37.000000000","message":"I think you need a self._ensure_quotas() in this setup too.","commit_id":"f4d4f0b9b0761b9c9de17ba384bb00113b5ea4c2"}]}