)]}'
{".testr.conf":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":5,"context_line":"             OS_DEBUG\u003d${OS_DEBUG:-1} \\"},{"line_number":6,"context_line":"             OS_TEST_TIMEOUT\u003d${OS_TEST_TIMEOUT:-160} \\"},{"line_number":7,"context_line":"             ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./designate/tests} $LISTOPT $IDOPTION \\"},{"line_number":8,"context_line":"             | cat"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"test_id_option\u003d--load-list $IDFILE"},{"line_number":11,"context_line":"test_list_option\u003d--list"}],"source_content_type":"text/plain","patch_set":10,"id":"ba15a1d1_d8e0f498","line":8,"updated":"2015-09-22 20:59:23.000000000","message":"Can you please explain this change? Maybe in the commit message? Why is it needed?","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"}],"tools/run-py3-tests.sh":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#py34 so skipping that until the issue is fixed"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"rm -rf  .testrepository"},{"line_number":7,"context_line":"testr init"},{"line_number":8,"context_line":"testr run \u0027^(?!.*test_nsd4)\u0027"}],"source_content_type":"text/x-sh","patch_set":10,"id":"ba15a1d1_98983c1d","line":7,"updated":"2015-09-22 20:59:23.000000000","message":"If you run \"testr init\" with Python 3 first, Python 2 will be able to use the test repository. So you don\u0027t have to remove it at each run.","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"rm -rf  .testrepository"},{"line_number":7,"context_line":"testr init"},{"line_number":8,"context_line":"testr run \u0027^(?!.*test_nsd4)\u0027"}],"source_content_type":"text/x-sh","patch_set":10,"id":"ba15a1d1_b82f40a0","line":8,"updated":"2015-09-22 20:59:23.000000000","message":"You can use testtools to avoid completly test repository. But it\u0027s less convenient, you have to explicit the list of executed tests. (Whitelist approach, whereas you took the blacklist approach.)","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"}],"tox.ini":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py27,flake8,py34"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[tox:jenkins]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"ba15a1d1_d88eb4cf","line":3,"updated":"2015-09-22 20:59:23.000000000","message":"Use \"envlist \u003d py34,py27,flake8\" to workaround the testrepository compatibility issue between Python 2 and Python 3.","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:py34]"},{"line_number":21,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":22,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":23,"context_line":"whitelist_externals \u003d find"},{"line_number":24,"context_line":"                      sh"},{"line_number":25,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":10,"id":"ba15a1d1_58b94478","line":22,"updated":"2015-09-22 20:59:23.000000000","message":"No need to repeat requirements.","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":23,"context_line":"whitelist_externals \u003d find"},{"line_number":24,"context_line":"                      sh"},{"line_number":25,"context_line":"commands \u003d"},{"line_number":26,"context_line":"   find {toxinidir} -not -path \u0027{toxinidir}/.tox/*\u0027 -name \u0027*.pyc\u0027 -delete"},{"line_number":27,"context_line":"   sh tools/run-py3-tests.sh"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"ba15a1d1_18ac2c34","line":26,"updated":"2015-09-22 20:59:23.000000000","message":"Why do you remove .pyc files?","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"eaa4ae66af9485e59806cf83b488da46c7232a28","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                      sh"},{"line_number":25,"context_line":"commands \u003d"},{"line_number":26,"context_line":"   find {toxinidir} -not -path \u0027{toxinidir}/.tox/*\u0027 -name \u0027*.pyc\u0027 -delete"},{"line_number":27,"context_line":"   sh tools/run-py3-tests.sh"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:docs]"},{"line_number":30,"context_line":"commands \u003d python setup.py build_sphinx -E"}],"source_content_type":"text/x-properties","patch_set":10,"id":"ba15a1d1_984d9c9b","line":27,"updated":"2015-09-22 20:59:23.000000000","message":"Note: nova uses bash instead of sh to run shell scripts. I don\u0027t know which one is better.","commit_id":"6bcd1d5f4afda031ac84d50dbb02f90b2159147f"}]}
