)]}'
{"designate/objects/adapters/base.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"677477aa933e945d0e7e9c1b80f129e9fee28a15","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                        values, output_object, *args, **kwargs)"},{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                # type_ \u003d \u0027object\u0027"},{"line_number":154,"context_line":"                return cls.get_object_adapter("},{"line_number":155,"context_line":"                    format_,"},{"line_number":156,"context_line":"                    output_object)._parse_object("},{"line_number":157,"context_line":"                        values, output_object, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_963d402d","line":154,"updated":"2015-07-28 11:54:24.000000000","message":"A nitpick on style: this code is doing 3 things in one SLOC: calling get_object_adaptor, _parse_list and returning. This could be on three lines instead.","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"07e73d679a884b4014cf4a4033cb0cb71645be76","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            error_message \u003d str.format("},{"line_number":164,"context_line":"                \u0027Provided object does not match schema. \u0027"},{"line_number":165,"context_line":"                \u0027Got a TypeError with message %s\u0027 % e.message)"},{"line_number":166,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        except AttributeError as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_085c0fec","line":165,"updated":"2015-07-20 23:57:23.000000000","message":"Hi, did we miss here six.text_type(e) or any specific reason for leaving this?","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d729af71ae1d2b265b82f376184f1c2330521f2e","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            error_message \u003d str.format("},{"line_number":164,"context_line":"                \u0027Provided object does not match schema. \u0027"},{"line_number":165,"context_line":"                \u0027Got a TypeError with message %s\u0027 % e.message)"},{"line_number":166,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        except AttributeError as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1b1d1bbd","line":165,"in_reply_to":"3a50d1a3_085c0fec","updated":"2015-07-21 12:24:15.000000000","message":"nope, I just missed it  - done","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"07e73d679a884b4014cf4a4033cb0cb71645be76","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                      (output_object.obj_name(), values))"},{"line_number":171,"context_line":"            error_message \u003d str.format("},{"line_number":172,"context_line":"                \u0027Provided object is not valid. \u0027"},{"line_number":173,"context_line":"                \u0027Got an AttributeError with message %s\u0027 % e.message)"},{"line_number":174,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        except exceptions.InvalidObject:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_a8739b7f","line":173,"updated":"2015-07-20 23:57:23.000000000","message":"ditto","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d729af71ae1d2b265b82f376184f1c2330521f2e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                      (output_object.obj_name(), values))"},{"line_number":171,"context_line":"            error_message \u003d str.format("},{"line_number":172,"context_line":"                \u0027Provided object is not valid. \u0027"},{"line_number":173,"context_line":"                \u0027Got an AttributeError with message %s\u0027 % e.message)"},{"line_number":174,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        except exceptions.InvalidObject:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_db7d73e8","line":173,"in_reply_to":"3a50d1a3_a8739b7f","updated":"2015-07-21 12:24:15.000000000","message":"Done","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"07e73d679a884b4014cf4a4033cb0cb71645be76","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            error_message \u003d str.format("},{"line_number":185,"context_line":"                \u0027Provided object is not valid. \u0027"},{"line_number":186,"context_line":"                \u0027Got a %s error with message %s\u0027 %"},{"line_number":187,"context_line":"                (type(e).__name__, e.message))"},{"line_number":188,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_4809b7dc","line":187,"updated":"2015-07-20 23:57:23.000000000","message":"ditto","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d729af71ae1d2b265b82f376184f1c2330521f2e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            error_message \u003d str.format("},{"line_number":185,"context_line":"                \u0027Provided object is not valid. \u0027"},{"line_number":186,"context_line":"                \u0027Got a %s error with message %s\u0027 %"},{"line_number":187,"context_line":"                (type(e).__name__, e.message))"},{"line_number":188,"context_line":"            raise exceptions.InvalidObject(error_message)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_7b845fd3","line":187,"in_reply_to":"3a50d1a3_4809b7dc","updated":"2015-07-21 12:24:15.000000000","message":"Done","commit_id":"c8d988a74e5a5e0ce8d6f634120f90c264125a9e"}],"designate/objects/recordset.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5434c353a4ff39d8f0f79009da2c0d1bd3327aa1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                error_indexes.append(i)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            except AttributeError as e:"},{"line_number":212,"context_line":"                e \u003d ValidationError()"},{"line_number":213,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":214,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":215,"context_line":"                e.validator_value \u003d [self.type]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_d6d2e8d0","line":212,"updated":"2015-07-28 11:54:33.000000000","message":"This 6-lines pattern is repeated, maybe it could be refactored into a function.","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f24b1465caa2f0dc089bc323702fe07d678d230c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                error_message \u003d str.format("},{"line_number":224,"context_line":"                    \u0027Provided object is not valid. \u0027"},{"line_number":225,"context_line":"                    \u0027Got a %s error with message %s\u0027 %"},{"line_number":226,"context_line":"                    (type(e).__name__, e.message))"},{"line_number":227,"context_line":"                raise exceptions.InvalidObject(error_message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_a294e5e1","line":226,"updated":"2015-07-14 12:47:10.000000000","message":"e.message does not exists in py3, can we make it compatible.","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9d301501f62a273ccf8b8b50b547deabfc612c8e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                error_message \u003d str.format("},{"line_number":224,"context_line":"                    \u0027Provided object is not valid. \u0027"},{"line_number":225,"context_line":"                    \u0027Got a %s error with message %s\u0027 %"},{"line_number":226,"context_line":"                    (type(e).__name__, e.message))"},{"line_number":227,"context_line":"                raise exceptions.InvalidObject(error_message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_1baea985","line":226,"in_reply_to":"3a50d1a3_5603ad73","updated":"2015-07-20 17:21:35.000000000","message":"Done - there is conflicting info on this though, I have seen people recommend using e.args[0] or similar as well.\n\nWent with the standard we have in the rest of the codebase.","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"6a84bf94cddd0c7d505817121c9a84875c7a1d19","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                error_message \u003d str.format("},{"line_number":224,"context_line":"                    \u0027Provided object is not valid. \u0027"},{"line_number":225,"context_line":"                    \u0027Got a %s error with message %s\u0027 %"},{"line_number":226,"context_line":"                    (type(e).__name__, e.message))"},{"line_number":227,"context_line":"                raise exceptions.InvalidObject(error_message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5603ad73","line":226,"in_reply_to":"9a41bdd9_51a1c544","updated":"2015-07-20 15:36:50.000000000","message":"`six.text_type(e)` is the closest thing to a match. JSONSchema\u0027s exceptions are just weird, in that they have a single line `e.message`, and a multiline value for `six.text_type(e)`. All normal exceptions have a single line for `six.text_type(e)`.","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"76e0e0766039905cf4f6440f8dbad3d517775f1e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                error_message \u003d str.format("},{"line_number":224,"context_line":"                    \u0027Provided object is not valid. \u0027"},{"line_number":225,"context_line":"                    \u0027Got a %s error with message %s\u0027 %"},{"line_number":226,"context_line":"                    (type(e).__name__, e.message))"},{"line_number":227,"context_line":"                raise exceptions.InvalidObject(error_message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_d032c5a6","line":226,"in_reply_to":"9a41bdd9_a294e5e1","updated":"2015-07-15 15:46:01.000000000","message":"what is the recommended replacement? \n\nstr(Exception) can return any information at all (and for a lot of libraries does return a lot more than the original message).","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"447d0bdc7b0ab580fcc85ba9944fa7ebb63c742a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                error_message \u003d str.format("},{"line_number":224,"context_line":"                    \u0027Provided object is not valid. \u0027"},{"line_number":225,"context_line":"                    \u0027Got a %s error with message %s\u0027 %"},{"line_number":226,"context_line":"                    (type(e).__name__, e.message))"},{"line_number":227,"context_line":"                raise exceptions.InvalidObject(error_message)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_51a1c544","line":226,"in_reply_to":"9a41bdd9_d032c5a6","updated":"2015-07-15 23:52:24.000000000","message":"I think six.text_type(e) should work fine.","commit_id":"b50f09f520a0f1a8052c2be1b8410a92eb2c6df1"}]}