)]}'
{"designate/schema/format.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ddd6692dada7c8f62aef2114daff53b07d5bd268","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#              trailing newline is NOT matched. See bug #1471158."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RE_DOMAINNAME \u003d \\"},{"line_number":31,"context_line":"    r\u0027^(\\*\\.)?(?!.{255,})(?:(?!\\-)[A-Za-z0-9_\\-]{1,63}(?\u003c!\\-)\\.)+\\Z\u0027"},{"line_number":32,"context_line":"RE_HOSTNAME \u003d r\u0027^(?!.{255,})(?:(?:^\\*|(?!\\-)[A-Za-z0-9_\\-]{1,63})(?\u003c!\\-)\\.)+\\Z\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RE_SRV_HOST_NAME \u003d r\u0027^(?:(?!\\-)(?:\\_[A-Za-z0-9_\\-]{1,63}\\.){2})(?!.{255,})\u0027 \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_2baed098","line":31,"updated":"2015-07-30 11:51:16.000000000","message":"2 things 1) The RE_HOSTNAME regex below allows wildcards, 2) this updated regex allows domain names of 257 chars, while the max would have needed to be 255.","commit_id":"0ee8eeae4a4e94a74af999db7b439534739efe85"}],"designate/tests/test_schema/test_format.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ddd6692dada7c8f62aef2114daff53b07d5bd268","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        ]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        invalid_domainnames \u003d ["},{"line_number":175,"context_line":"            \u0027*.example.com.\u0027,"},{"line_number":176,"context_line":"            \u0027**.example.com.\u0027,"},{"line_number":177,"context_line":"            \u0027*.*.example.org.\u0027,"},{"line_number":178,"context_line":"            \u0027a.*.example.org.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4b86bc17","side":"PARENT","line":175,"updated":"2015-07-30 11:51:16.000000000","message":"*.example.com. really is a invalid domain name, it is however a valid hostname.","commit_id":"1e266b1634dd54e26703c8660ce3461e91fc081b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ddd6692dada7c8f62aef2114daff53b07d5bd268","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def test_is_domainname(self):"},{"line_number":153,"context_line":"        valid_domainnames \u003d ["},{"line_number":154,"context_line":"            \u0027example.com.\u0027,"},{"line_number":155,"context_line":"            \u0027*.example.com.\u0027,"},{"line_number":156,"context_line":"            \u0027www.example.com.\u0027,"},{"line_number":157,"context_line":"            \u002712345.example.com.\u0027,"},{"line_number":158,"context_line":"            \u0027192-0-2-1.example.com.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_0b80b4f6","line":155,"updated":"2015-07-30 11:51:16.000000000","message":"*.example.com. really is a invalid domain name, it is however a valid hostname.","commit_id":"0ee8eeae4a4e94a74af999db7b439534739efe85"}]}