)]}'
{"functionaltests/api/v2/test_recordset_unauthed.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"8cedc7d9205f2f33afa1c0a36a48ddd465192a0c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    except exceptions.Unauthorized as e:"},{"line_number":105,"context_line":"        return (True, e)"},{"line_number":106,"context_line":"    except Exception as e:"},{"line_number":107,"context_line":"        return (False, e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1998c0bf","line":107,"updated":"2015-09-15 21:01:08.000000000","message":"I would like to put this method on a base test case class, and then use self.assertRaises() to check for the exception (http://testtools.readthedocs.org/en/latest/api.html#testtools.TestCase.assertRaises - I think tempest-lib uses testtools), instead of self.assertTrue().\n\nThat should gives us a slightly better error message than \"False is not True\": http://logs.openstack.org/45/223745/1/check/gate-designate-dsvm-bind9/27f47d2/console.html#_2015-09-15_20_02_08_655\n\nOh, and I remember there\u0027s a method here: https://github.com/openstack/designate/blob/master/functionaltests/api/v2/base.py#L46 that others have used to test for exceptions that would be fine to use, too.","commit_id":"fd3eeac9fce13ddb6eb5121595f002c15d41199d"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"33e82ffe3b66365593aa447d69cc6098eaf436df","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(RecordsetTest, self).setUp()"},{"line_number":31,"context_line":"        self.increase_quotas(user\u003d\u0027admin\u0027)"},{"line_number":32,"context_line":"        resp, self.zone \u003d ZoneClient.as_user(\u0027default\u0027).post_zone("},{"line_number":33,"context_line":"            datagen.random_zone_data())"},{"line_number":34,"context_line":"        ZoneClient.as_user(\u0027default\u0027).wait_for_zone(self.zone.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_f8845b5e","line":31,"updated":"2015-09-18 15:46:27.000000000","message":"This should be user\u003d\u0027default\u0027 for the quota increase. All the quota requests are made by the admin user, and the user param specifies which user\u0027s quotas to change... which is confusing maybe, since everywhere else the user param is who makes the request.","commit_id":"d36b1f2a90b01bb0cf5a043144a57dc834a609fa"}]}
