)]}'
{"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"41533ad6b24f02c6ef590899f32d98605cb6e0bd","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        managed \u003d []"},{"line_number":617,"context_line":"        for rs in recordsets:"},{"line_number":618,"context_line":"            if rs.managed:"},{"line_number":619,"context_line":"                managed.append(rs)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        if len(managed) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_8e983d6c","line":618,"updated":"2015-10-02 12:11:24.000000000","message":"records have the managed\u003dTrue flag, not recordsets","commit_id":"c59a2a012e61a80ea4d985db04ac29a582c745d1"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"61040b561895afef8c6ec88055a93f19f8665894","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        managed \u003d []"},{"line_number":617,"context_line":"        for rs in recordsets:"},{"line_number":618,"context_line":"            if rs.managed:"},{"line_number":619,"context_line":"                managed.append(rs)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        if len(managed) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_f48f4873","line":618,"in_reply_to":"9a1a9d01_8e983d6c","updated":"2015-10-02 12:55:02.000000000","message":"https://github.com/openstack/designate/blob/master/designate/objects/recordset.py#L54-L60","commit_id":"c59a2a012e61a80ea4d985db04ac29a582c745d1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"371121d9923d68d0f57786ed82ba9d0d853dcaa4","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        managed \u003d []"},{"line_number":617,"context_line":"        for rs in recordsets:"},{"line_number":618,"context_line":"            if rs.managed:"},{"line_number":619,"context_line":"                managed.append(rs)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        if len(managed) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_93382b3f","line":618,"in_reply_to":"9a1a9d01_f48f4873","updated":"2015-10-05 12:04:28.000000000","message":"Ah..","commit_id":"c59a2a012e61a80ea4d985db04ac29a582c745d1"}],"designate/tests/unit/test_central/test_basic.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"d1c4a33e35d0615c94623bac446ac3c235c229d2","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    def test__add_ns_creation(self):"},{"line_number":679,"context_line":"        self.service._create_ns \u003d Mock()"},{"line_number":680,"context_line":"        self.service.find_recordset \u003d Mock("},{"line_number":681,"context_line":"            side_effect\u003dexceptions.RecordSetNotFound"},{"line_number":682,"context_line":"        )"},{"line_number":683,"context_line":"        self.service._add_ns("},{"line_number":684,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a4ddef15","side":"PARENT","line":681,"updated":"2015-10-05 09:45:44.000000000","message":"Are you testing the condition where RecordSetNotFound is being raised by _add_ns() somewhere else?","commit_id":"66613e9b2d90eb2e6094aa562b2a2e50386373ce"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"371121d9923d68d0f57786ed82ba9d0d853dcaa4","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    def test__add_ns_creation(self):"},{"line_number":679,"context_line":"        self.service._create_ns \u003d Mock()"},{"line_number":680,"context_line":"        self.service.find_recordset \u003d Mock("},{"line_number":681,"context_line":"            side_effect\u003dexceptions.RecordSetNotFound"},{"line_number":682,"context_line":"        )"},{"line_number":683,"context_line":"        self.service._add_ns("},{"line_number":684,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b32befea","side":"PARENT","line":681,"in_reply_to":"9a1a9d01_a4ddef15","updated":"2015-10-05 12:04:28.000000000","message":"As the code was switched from find_recordset to find_recordsets, the RecrdSetNotFound exception is no longer raised - intsead and empty array is returned.","commit_id":"66613e9b2d90eb2e6094aa562b2a2e50386373ce"}]}