)]}'
{"designate/api/v1/domains.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"73b8bf01ff0acb07e03b301068d5761ce9c2a991","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    domains \u003d central_api.find_domains(context, criterion\u003d{\"type\": \"PRIMARY\"})"},{"line_number":87,"context_line":"    for zone in list(domains):"},{"line_number":88,"context_line":"        if zone.action \u003d\u003d \u0027DELETE\u0027 and zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":89,"context_line":"            domains.remove(zone)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    return flask.jsonify(domains_schema.filter({\u0027domains\u0027: domains}))"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_44eeceed","line":89,"updated":"2015-11-16 10:28:23.000000000","message":"I think this can be simplified, any zone with action\u003dDELETE should be excluded, we so we can just add action\u003dDELETE to the criterion. Same for others I believe?","commit_id":"3561d44ecdc6e9702f5c745db6fd700db7963ba4"}],"designate/api/v1/records.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4b9046b24fff6e95b5eca38fe12445a16790bf94","unresolved":false,"context_lines":[{"line_number":42,"context_line":"def _find_or_create_recordset(context, domain_id, name, type, ttl):"},{"line_number":43,"context_line":"    central_api \u003d central_rpcapi.CentralAPI.get_instance()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    criterion \u003d {\"id\": domain_id, \"type\": \"PRIMARY\", \"actions\": \"!DELETE\"}"},{"line_number":46,"context_line":"    central_api.find_domain(context, criterion\u003dcriterion)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_410cee40","line":45,"updated":"2015-11-18 16:17:59.000000000","message":"s/actions/action/","commit_id":"a4db814bb16033ce21b40f0c8ec37223bbf0ebf6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4b9046b24fff6e95b5eca38fe12445a16790bf94","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    # NOTE: We need to ensure the domain actually exists, otherwise we may"},{"line_number":248,"context_line":"    #       return a record not found instead of a domain not found"},{"line_number":249,"context_line":"    criterion \u003d {\"id\": domain_id, \"type\": \"PRIMARY\", \"actions\": \"!DELETE\"}"},{"line_number":250,"context_line":"    central_api.find_domain(context, criterion\u003dcriterion)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    # Find the record"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_ac011107","line":249,"updated":"2015-11-18 16:17:59.000000000","message":"s/actions/action/","commit_id":"a4db814bb16033ce21b40f0c8ec37223bbf0ebf6"}],"designate/tests/test_api/test_v1/test_records.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"41d4258f6b83eda03b7cbff2dea96190856f8e48","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        self.delete(\u0027/domains/%s\u0027 % self.zone[\u0027id\u0027])"},{"line_number":810,"context_line":"        self.post(\u0027domains/%s/records\u0027 % self.zone[\u0027id\u0027],"},{"line_number":811,"context_line":"                  data\u003dfixture, status_code\u003d404)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"    def test_update_record_deleting_zone(self):"},{"line_number":814,"context_line":"        # Create a record"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_9128d2e3","line":811,"updated":"2015-11-18 22:14:30.000000000","message":"FYI to reviewers - This is real bug in the tests. As PM wasn\u0027t running, the delete request never get\u0027s processed. and a 400 comes back. In \"real life\", where it\u0027s running and not overloaded, a 404 is what we actually return.","commit_id":"a0ff7859a756002b39cd520ac20c3d79cef7b32a"}]}