)]}'
{"contrib/archive/backends/impl_multi.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 for record in self.central.find_records("},{"line_number":129,"context_line":"                     context, {\u0027domain_id\u0027: full_domain[\u0027id\u0027]})]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":132,"context_line":"        self.master.create_recordset(context, domain, recordset)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_d73b0eea","side":"PARENT","line":131,"updated":"2015-11-17 13:26:22.000000000","message":"\"domain\" to be renamed here and below?","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 for record in self.central.find_records("},{"line_number":129,"context_line":"                     context, {\u0027domain_id\u0027: full_domain[\u0027id\u0027]})]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":132,"context_line":"        self.master.create_recordset(context, domain, recordset)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_40474c4b","side":"PARENT","line":131,"in_reply_to":"ba8a016a_59866c66","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 for record in self.central.find_records("},{"line_number":129,"context_line":"                     context, {\u0027domain_id\u0027: full_domain[\u0027id\u0027]})]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":132,"context_line":"        self.master.create_recordset(context, domain, recordset)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_59866c66","side":"PARENT","line":131,"in_reply_to":"ba8a016a_d73b0eea","updated":"2015-11-17 14:10:16.000000000","message":"yes - good catch","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"}],"contrib/tempest/config.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cfg.StrOpt(\u0027password\u0027,"},{"line_number":68,"context_line":"               help\u003d\"API key to use when authenticating.\","},{"line_number":69,"context_line":"               secret\u003dTrue),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027domain_name\u0027,"},{"line_number":71,"context_line":"               help\u003d\"Domain name for authentication (Keystone V3).\""},{"line_number":72,"context_line":"                    \"The same domain applies to user and project\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027alt_username\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_4203de0d","side":"PARENT","line":70,"updated":"2015-11-17 13:26:22.000000000","message":"I assume domain_name is not to be changed?","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cfg.StrOpt(\u0027password\u0027,"},{"line_number":68,"context_line":"               help\u003d\"API key to use when authenticating.\","},{"line_number":69,"context_line":"               secret\u003dTrue),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027domain_name\u0027,"},{"line_number":71,"context_line":"               help\u003d\"Domain name for authentication (Keystone V3).\""},{"line_number":72,"context_line":"                    \"The same domain applies to user and project\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027alt_username\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_998cd480","side":"PARENT","line":70,"in_reply_to":"ba8a016a_4203de0d","updated":"2015-11-17 14:10:16.000000000","message":"nope.","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cfg.StrOpt(\u0027password\u0027,"},{"line_number":68,"context_line":"               help\u003d\"API key to use when authenticating.\","},{"line_number":69,"context_line":"               secret\u003dTrue),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027domain_name\u0027,"},{"line_number":71,"context_line":"               help\u003d\"Domain name for authentication (Keystone V3).\""},{"line_number":72,"context_line":"                    \"The same domain applies to user and project\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027alt_username\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_606930be","side":"PARENT","line":70,"in_reply_to":"ba8a016a_998cd480","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"}],"designate/api/admin/views/base.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    as part of the API call."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    For example, in the V2 API, we did s/domain/zone/. Adapting a record"},{"line_number":36,"context_line":"    resources \"zone_id\" \u003c-\u003e \"zone_id\" is the responsibility of a View."},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    _resource_name \u003d None"},{"line_number":39,"context_line":"    _collection_name \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_13d1c7cd","line":36,"updated":"2015-11-16 23:13:18.000000000","message":"Might want to revert this one. zone_id is zone id!","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    as part of the API call."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    For example, in the V2 API, we did s/domain/zone/. Adapting a record"},{"line_number":36,"context_line":"    resources \"zone_id\" \u003c-\u003e \"zone_id\" is the responsibility of a View."},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    _resource_name \u003d None"},{"line_number":39,"context_line":"    _collection_name \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_39d12858","line":36,"in_reply_to":"ba8a016a_13d1c7cd","updated":"2015-11-17 14:10:16.000000000","message":"good catch","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    as part of the API call."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    For example, in the V2 API, we did s/domain/zone/. Adapting a record"},{"line_number":36,"context_line":"    resources \"zone_id\" \u003c-\u003e \"zone_id\" is the responsibility of a View."},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    _resource_name \u003d None"},{"line_number":39,"context_line":"    _collection_name \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_20ba4824","line":36,"in_reply_to":"ba8a016a_39d12858","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/api/v1/records.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    central_api \u003d central_rpcapi.CentralAPI.get_instance()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return central_api.find_recordset(context, {"},{"line_number":36,"context_line":"        \u0027zone_id\u0027: domain_id,"},{"line_number":37,"context_line":"        \u0027name\u0027: name,"},{"line_number":38,"context_line":"        \u0027type\u0027: type,"},{"line_number":39,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_02f716f6","line":36,"updated":"2015-11-17 13:26:22.000000000","message":"domain_id is not being renamed across the file.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    central_api \u003d central_rpcapi.CentralAPI.get_instance()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return central_api.find_recordset(context, {"},{"line_number":36,"context_line":"        \u0027zone_id\u0027: domain_id,"},{"line_number":37,"context_line":"        \u0027name\u0027: name,"},{"line_number":38,"context_line":"        \u0027type\u0027: type,"},{"line_number":39,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_79bfb0fb","line":36,"in_reply_to":"ba8a016a_02f716f6","updated":"2015-11-17 14:10:16.000000000","message":"nope - in the v1 API I made as little changes as possible","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/api/v2/controllers/recordsets.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        request \u003d pecan.request"},{"line_number":51,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # NOTE: We need to ensure the zonoe actually exists, otherwise we may"},{"line_number":54,"context_line":"        #       return deleted recordsets instead of a zone not found"},{"line_number":55,"context_line":"        self.central_api.get_zone(context, zone_id)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_93aa9718","line":53,"updated":"2015-11-16 23:13:18.000000000","message":"s/zonoe/zone","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        request \u003d pecan.request"},{"line_number":51,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # NOTE: We need to ensure the zonoe actually exists, otherwise we may"},{"line_number":54,"context_line":"        #       return deleted recordsets instead of a zone not found"},{"line_number":55,"context_line":"        self.central_api.get_zone(context, zone_id)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_f941600c","line":53,"in_reply_to":"ba8a016a_93aa9718","updated":"2015-11-17 14:10:16.000000000","message":"doh!","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        request \u003d pecan.request"},{"line_number":51,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # NOTE: We need to ensure the zonoe actually exists, otherwise we may"},{"line_number":54,"context_line":"        #       return deleted recordsets instead of a zone not found"},{"line_number":55,"context_line":"        self.central_api.get_zone(context, zone_id)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_60de106f","line":53,"in_reply_to":"ba8a016a_f941600c","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/central/service.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return self.storage.count_tenants(context)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Domain Methods"},{"line_number":834,"context_line":"    @notification(\u0027dns.domain.create\u0027)"},{"line_number":835,"context_line":"    @synchronized_domain(new_domain\u003dTrue)"},{"line_number":836,"context_line":"    def create_domain(self, context, domain):"},{"line_number":837,"context_line":"        # TODO(kiall): Refactor this method into *MUCH* smaller chunks."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_5d1e5f64","side":"PARENT","line":834,"updated":"2015-11-17 13:26:22.000000000","message":"the dns.domain.create / update / delete notifications are not being renamed","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return self.storage.count_tenants(context)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Domain Methods"},{"line_number":834,"context_line":"    @notification(\u0027dns.domain.create\u0027)"},{"line_number":835,"context_line":"    @synchronized_domain(new_domain\u003dTrue)"},{"line_number":836,"context_line":"    def create_domain(self, context, domain):"},{"line_number":837,"context_line":"        # TODO(kiall): Refactor this method into *MUCH* smaller chunks."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_f90f20df","side":"PARENT","line":834,"in_reply_to":"ba8a016a_5d1e5f64","updated":"2015-11-17 14:10:16.000000000","message":"No, we are emitting 2 events now. one for domain (for people that were listening for \"domain\") and the new one - zone","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"}],"designate/context.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _all_tenants \u003d False"},{"line_number":31,"context_line":"    _abandon \u003d None"},{"line_number":32,"context_line":"    original_project \u003d None"},{"line_number":33,"context_line":"    _edit_managed_records \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, auth_token\u003dNone, user\u003dNone, tenant\u003dNone, domain\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_3649598c","line":32,"updated":"2015-11-16 23:13:18.000000000","message":"This doesn\u0027t seem to be renamed elsewhere. The s/tenant/project should probably happen in another changeset. \n\nAs an aside, the fact we have a class attribute that also gets sets in __init__seems weird. That should change all instances when any instance is created. Is that the intent?","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _all_tenants \u003d False"},{"line_number":31,"context_line":"    _abandon \u003d None"},{"line_number":32,"context_line":"    original_project \u003d None"},{"line_number":33,"context_line":"    _edit_managed_records \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, auth_token\u003dNone, user\u003dNone, tenant\u003dNone, domain\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_192a242d","line":32,"in_reply_to":"ba8a016a_3649598c","updated":"2015-11-17 14:10:16.000000000","message":"it should not be renamed, not sure about the scoping.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/locale/designate-log-warning.pot":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"#, python-format"},{"line_number":131,"context_line":"msgid \"Abandoning zone \u0027%(zone)s\u0027\""},{"line_number":132,"context_line":"msgstr \"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#: designate/mdns/handler.py:132"},{"line_number":135,"context_line":"#, python-format"},{"line_number":136,"context_line":"msgid \"NOTIFY for %(name)s from non-master server %(addr)s, ignoring.\""}],"source_content_type":"application/mspowerpoint","patch_set":11,"id":"ba8a016a_9dc5a78f","side":"PARENT","line":133,"updated":"2015-11-17 13:26:22.000000000","message":"There are messages in the designate-log-*.pot files using %(domain) for string formatting.","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"#, python-format"},{"line_number":131,"context_line":"msgid \"Abandoning zone \u0027%(zone)s\u0027\""},{"line_number":132,"context_line":"msgstr \"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#: designate/mdns/handler.py:132"},{"line_number":135,"context_line":"#, python-format"},{"line_number":136,"context_line":"msgid \"NOTIFY for %(name)s from non-master server %(addr)s, ignoring.\""}],"source_content_type":"application/mspowerpoint","patch_set":11,"id":"ba8a016a_79c9f077","side":"PARENT","line":133,"in_reply_to":"ba8a016a_9dc5a78f","updated":"2015-11-17 14:10:16.000000000","message":"these files are automatically generated. we need to revert these changes","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"}],"designate/mdns/handler.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            response.flags |\u003d dns.flags.AA"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        except exceptions.NotFound:"},{"line_number":389,"context_line":"            # If an FQDN exists, like www.rackspace.com, but the specific"},{"line_number":390,"context_line":"            # record type doesn\u0027t exist, like type SPF, then the return code"},{"line_number":391,"context_line":"            # would be NOERROR and the SOA record is returned.  This tells"},{"line_number":392,"context_line":"            # caching nameservers that the FQDN does exist, so don\u0027t negatively"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_b603090f","line":389,"updated":"2015-11-16 23:13:18.000000000","message":"We should switch this to be www.example.com :)","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            response.flags |\u003d dns.flags.AA"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        except exceptions.NotFound:"},{"line_number":389,"context_line":"            # If an FQDN exists, like www.rackspace.com, but the specific"},{"line_number":390,"context_line":"            # record type doesn\u0027t exist, like type SPF, then the return code"},{"line_number":391,"context_line":"            # would be NOERROR and the SOA record is returned.  This tells"},{"line_number":392,"context_line":"            # caching nameservers that the FQDN does exist, so don\u0027t negatively"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_59a50cb3","line":389,"in_reply_to":"ba8a016a_b603090f","updated":"2015-11-17 14:10:16.000000000","message":"yes. separate patch :)","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            # caching nameservers that the FQDN does exist, so don\u0027t negatively"},{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_c941523b","line":395,"updated":"2015-11-16 23:13:18.000000000","message":"Revert.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            # caching nameservers that the FQDN does exist, so don\u0027t negatively"},{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_d991fc53","line":395,"in_reply_to":"ba8a016a_c941523b","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            # caching nameservers that the FQDN does exist, so don\u0027t negatively"},{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_200488be","line":395,"in_reply_to":"ba8a016a_d991fc53","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_a9488e5c","line":396,"updated":"2015-11-16 23:13:18.000000000","message":"Revert.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_40ff4caa","line":396,"in_reply_to":"ba8a016a_999b7472","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            # cache it, but the specific record doesn\u0027t exist."},{"line_number":394,"context_line":"            #"},{"line_number":395,"context_line":"            # If an FQDN doesn\u0027t exist with any record type, that is NXzone."},{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_999b7472","line":396,"in_reply_to":"ba8a016a_a9488e5c","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_29733eb3","line":399,"updated":"2015-11-16 23:13:18.000000000","message":"Revert the NXzone.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_39892827","line":399,"in_reply_to":"ba8a016a_29733eb3","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            # However, an authoritative nameserver shouldn\u0027t return NXzone"},{"line_number":397,"context_line":"            # for a zone it isn\u0027t authoritative for.  It would be more"},{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e02c404c","line":399,"in_reply_to":"ba8a016a_39892827","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"},{"line_number":403,"context_line":"            # To simply things currently this returns a REFUSED in all cases."},{"line_number":404,"context_line":"            # If zone transfers needs different errors, we could revisit this."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_c9af12e2","line":401,"updated":"2015-11-16 23:13:18.000000000","message":"Revert the NXzone.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"},{"line_number":403,"context_line":"            # To simply things currently this returns a REFUSED in all cases."},{"line_number":404,"context_line":"            # If zone transfers needs different errors, we could revisit this."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_f982c0ff","line":401,"in_reply_to":"ba8a016a_c9af12e2","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            # appropriate for it to return REFUSED.  It should still return"},{"line_number":399,"context_line":"            # NXzone if it is authoritative for a zone but the FQDN doesn\u0027t"},{"line_number":400,"context_line":"            # exist, like abcdef.rackspace.com.  Of course, a wildcard within a"},{"line_number":401,"context_line":"            # zone would mean that NXzone isn\u0027t ever returned for a zone."},{"line_number":402,"context_line":"            #"},{"line_number":403,"context_line":"            # To simply things currently this returns a REFUSED in all cases."},{"line_number":404,"context_line":"            # If zone transfers needs different errors, we could revisit this."}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_c029fc38","line":401,"in_reply_to":"ba8a016a_f982c0ff","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/quota/base.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                if value \u003e\u003d quotas[resource]:"},{"line_number":37,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":38,"context_line":"            else:"},{"line_number":39,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""},{"line_number":40,"context_line":"                                                      \" resource\", resource)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_quotas(self, context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e98696b8","line":39,"updated":"2015-11-16 23:13:18.000000000","message":"I\u0027m OK with this here, but just wanted to raise a flag as it is outside the scope of s/domain/zone.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                if value \u003e\u003d quotas[resource]:"},{"line_number":37,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":38,"context_line":"            else:"},{"line_number":39,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""},{"line_number":40,"context_line":"                                                      \" resource\", resource)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_quotas(self, context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_b9cbd852","line":39,"in_reply_to":"ba8a016a_e98696b8","updated":"2015-11-17 14:10:16.000000000","message":"yup, it is out of scope. I put it in as I was getting very confused ... on balance I am OK with this staying in.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/resources/templates/export-zone.jinja2":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"$ORIGIN {{ domain.name }}"},{"line_number":2,"context_line":"$TTL {{ domain.ttl }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for recordset in recordsets -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba8a016a_65a069a0","side":"PARENT","line":1,"updated":"2015-11-17 13:26:22.000000000","message":"There\u0027s a jinja template designate/resources/templates/bind9-zone.jinja2 that uses \"domain\" and appears to be referenced only by unit tests.","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"$ORIGIN {{ domain.name }}"},{"line_number":2,"context_line":"$TTL {{ domain.ttl }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for recordset in recordsets -%}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba8a016a_59e18ccf","side":"PARENT","line":1,"in_reply_to":"ba8a016a_65a069a0","updated":"2015-11-17 14:10:16.000000000","message":"humm. will dig into that","commit_id":"3e9ec422abb14673653a37152271b76c49482a6a"}],"designate/schema/format.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":119,"context_line":"@draft3_format_checker.checks(\"domain-name\")"},{"line_number":120,"context_line":"@draft4_format_checker.checks(\"domainname\")"},{"line_number":121,"context_line":"@draft3_format_checker.checks(\"zone-name\")"},{"line_number":122,"context_line":"@draft4_format_checker.checks(\"zonename\")"},{"line_number":123,"context_line":"def is_zonename(instance):"},{"line_number":124,"context_line":"    if not isinstance(instance, compat.str_types):"},{"line_number":125,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_691dc672","line":122,"updated":"2015-11-16 23:13:18.000000000","message":"I\u0027m not familiar with the checkers here, but want to raise a flag in case a rename removes the `domain-name` and `domainname` checks.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"@draft3_format_checker.checks(\"domain-name\")"},{"line_number":120,"context_line":"@draft4_format_checker.checks(\"domainname\")"},{"line_number":121,"context_line":"@draft3_format_checker.checks(\"zone-name\")"},{"line_number":122,"context_line":"@draft4_format_checker.checks(\"zonename\")"},{"line_number":123,"context_line":"def is_zonename(instance):"},{"line_number":124,"context_line":"    if not isinstance(instance, compat.str_types):"},{"line_number":125,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_392cc801","line":122,"in_reply_to":"ba8a016a_691dc672","updated":"2015-11-17 14:10:16.000000000","message":"the decorators take care of this.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/sqlalchemy/base.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                table.c.created_at,                         # 2 - RS Created"},{"line_number":323,"context_line":"                table.c.updated_at,                         # 3 - RS Updated"},{"line_number":324,"context_line":"                table.c.tenant_id,                          # 4 - RS Tenant"},{"line_number":325,"context_line":"                table.c.zone_id,                          # 5 - RS Zone"},{"line_number":326,"context_line":"                table.c.name,                               # 6 - RS Name"},{"line_number":327,"context_line":"                table.c.type,                               # 7 - RS Type"},{"line_number":328,"context_line":"                table.c.ttl,                                # 8 - RS TTL"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_c90cf244","line":325,"updated":"2015-11-16 23:13:18.000000000","message":"Whitespace.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                table.c.created_at,                         # 2 - RS Created"},{"line_number":323,"context_line":"                table.c.updated_at,                         # 3 - RS Updated"},{"line_number":324,"context_line":"                table.c.tenant_id,                          # 4 - RS Tenant"},{"line_number":325,"context_line":"                table.c.zone_id,                          # 5 - RS Zone"},{"line_number":326,"context_line":"                table.c.name,                               # 6 - RS Name"},{"line_number":327,"context_line":"                table.c.type,                               # 7 - RS Type"},{"line_number":328,"context_line":"                table.c.ttl,                                # 8 - RS TTL"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_20c9e878","line":325,"in_reply_to":"ba8a016a_1939c441","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                table.c.created_at,                         # 2 - RS Created"},{"line_number":323,"context_line":"                table.c.updated_at,                         # 3 - RS Updated"},{"line_number":324,"context_line":"                table.c.tenant_id,                          # 4 - RS Tenant"},{"line_number":325,"context_line":"                table.c.zone_id,                          # 5 - RS Zone"},{"line_number":326,"context_line":"                table.c.name,                               # 6 - RS Name"},{"line_number":327,"context_line":"                table.c.type,                               # 7 - RS Type"},{"line_number":328,"context_line":"                table.c.ttl,                                # 8 - RS TTL"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_1939c441","line":325,"in_reply_to":"ba8a016a_c90cf244","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                relation_table.c.created_at,                # 12 - R Created"},{"line_number":334,"context_line":"                relation_table.c.updated_at,                # 13 - R Updated"},{"line_number":335,"context_line":"                relation_table.c.tenant_id,                 # 14 - R Tenant"},{"line_number":336,"context_line":"                relation_table.c.zone_id,                 # 15 - R Zone"},{"line_number":337,"context_line":"                relation_table.c.recordset_id,              # 16 - R RSet"},{"line_number":338,"context_line":"                relation_table.c.data,                      # 17 - R Data"},{"line_number":339,"context_line":"                relation_table.c.description,               # 18 - R Desc"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e909b632","line":336,"updated":"2015-11-16 23:13:18.000000000","message":"Whitespace.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                relation_table.c.created_at,                # 12 - R Created"},{"line_number":334,"context_line":"                relation_table.c.updated_at,                # 13 - R Updated"},{"line_number":335,"context_line":"                relation_table.c.tenant_id,                 # 14 - R Tenant"},{"line_number":336,"context_line":"                relation_table.c.zone_id,                 # 15 - R Zone"},{"line_number":337,"context_line":"                relation_table.c.recordset_id,              # 16 - R RSet"},{"line_number":338,"context_line":"                relation_table.c.data,                      # 17 - R Data"},{"line_number":339,"context_line":"                relation_table.c.description,               # 18 - R Desc"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_00a5c4b3","line":336,"in_reply_to":"ba8a016a_9945b4b4","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                relation_table.c.created_at,                # 12 - R Created"},{"line_number":334,"context_line":"                relation_table.c.updated_at,                # 13 - R Updated"},{"line_number":335,"context_line":"                relation_table.c.tenant_id,                 # 14 - R Tenant"},{"line_number":336,"context_line":"                relation_table.c.zone_id,                 # 15 - R Zone"},{"line_number":337,"context_line":"                relation_table.c.recordset_id,              # 16 - R RSet"},{"line_number":338,"context_line":"                relation_table.c.data,                      # 17 - R Data"},{"line_number":339,"context_line":"                relation_table.c.description,               # 18 - R Desc"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_9945b4b4","line":336,"in_reply_to":"ba8a016a_e909b632","updated":"2015-11-17 14:10:16.000000000","message":":doh:","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/storage/impl_sqlalchemy/migrate_repo/versions/080_domain_to_zone_rename.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# See https://blueprints.launchpad.net/nova/+spec/backportable-db-migrations"},{"line_number":18,"context_line":"# http://lists.openstack.org/pipermail/openstack-dev/2013-March/006827.html"},{"line_number":19,"context_line":"from sqlalchemy.schema import MetaData, Table, Index"},{"line_number":20,"context_line":"from migrate.changeset.constraint import UniqueConstraint, \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_8816c4ef","line":17,"updated":"2015-11-17 13:26:22.000000000","message":"Can you please add some comments on what this file and 081_add_FKs.py are doing?","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# See https://blueprints.launchpad.net/nova/+spec/backportable-db-migrations"},{"line_number":18,"context_line":"# http://lists.openstack.org/pipermail/openstack-dev/2013-March/006827.html"},{"line_number":19,"context_line":"from sqlalchemy.schema import MetaData, Table, Index"},{"line_number":20,"context_line":"from migrate.changeset.constraint import UniqueConstraint, \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_d9225c01","line":17,"in_reply_to":"ba8a016a_8816c4ef","updated":"2015-11-17 14:10:16.000000000","message":"sure - that is a good idea","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# See https://blueprints.launchpad.net/nova/+spec/backportable-db-migrations"},{"line_number":18,"context_line":"# http://lists.openstack.org/pipermail/openstack-dev/2013-March/006827.html"},{"line_number":19,"context_line":"from sqlalchemy.schema import MetaData, Table, Index"},{"line_number":20,"context_line":"from migrate.changeset.constraint import UniqueConstraint, \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_60dcd0e4","line":17,"in_reply_to":"ba8a016a_d9225c01","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/tests/__init__.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                REPOSITORY, manage_database.INIT_VERSION))"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        if os.getenv(\u0027DESIGNATE_SQL_DEBUG\u0027, \"True\").lower() in _TRUE_VALUES:"},{"line_number":300,"context_line":"            connection_debug \u003d 0"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            connection_debug \u003d 0"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_4c9b30ca","line":300,"updated":"2015-11-16 23:13:18.000000000","message":"We lost a 5 here.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                REPOSITORY, manage_database.INIT_VERSION))"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        if os.getenv(\u0027DESIGNATE_SQL_DEBUG\u0027, \"True\").lower() in _TRUE_VALUES:"},{"line_number":300,"context_line":"            connection_debug \u003d 0"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            connection_debug \u003d 0"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_b96e782d","line":300,"in_reply_to":"ba8a016a_4c9b30ca","updated":"2015-11-17 14:10:16.000000000","message":"yup. - good catch","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/tests/test_api/test_v1/test_domains.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"5ee583fc5a99d79d37f069b001141df44b4e3e1e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(\u0027serial\u0027, response.json[\u0027properties\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_zones_schema(self):"},{"line_number":50,"context_line":"        response \u003d self.get(\u0027schemas/domain\u0027)"},{"line_number":51,"context_line":"        self.assertIn(\u0027description\u0027, response.json)"},{"line_number":52,"context_line":"        self.assertIn(\u0027additionalProperties\u0027, response.json)"},{"line_number":53,"context_line":"        self.assertIn(\u0027properties\u0027, response.json)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e8b0b0df","line":50,"updated":"2015-11-17 13:26:22.000000000","message":"Was this testing the wrong thing before?","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"2c7139f48dadb5bffe8986ce6d4703d993af0235","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(\u0027serial\u0027, response.json[\u0027properties\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_zones_schema(self):"},{"line_number":50,"context_line":"        response \u003d self.get(\u0027schemas/domain\u0027)"},{"line_number":51,"context_line":"        self.assertIn(\u0027description\u0027, response.json)"},{"line_number":52,"context_line":"        self.assertIn(\u0027additionalProperties\u0027, response.json)"},{"line_number":53,"context_line":"        self.assertIn(\u0027properties\u0027, response.json)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e08f6021","line":50,"in_reply_to":"ba8a016a_3961283a","updated":"2015-11-17 15:22:40.000000000","message":"Done","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(\u0027serial\u0027, response.json[\u0027properties\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_zones_schema(self):"},{"line_number":50,"context_line":"        response \u003d self.get(\u0027schemas/domain\u0027)"},{"line_number":51,"context_line":"        self.assertIn(\u0027description\u0027, response.json)"},{"line_number":52,"context_line":"        self.assertIn(\u0027additionalProperties\u0027, response.json)"},{"line_number":53,"context_line":"        self.assertIn(\u0027properties\u0027, response.json)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_3961283a","line":50,"in_reply_to":"ba8a016a_e8b0b0df","updated":"2015-11-17 14:10:16.000000000","message":"nope.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}],"designate/tests/test_central/test_service.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(set([n.hostname for n in pool.ns_records]),"},{"line_number":471,"context_line":"                         set([n.data for n in ns_recordset.records]))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        return zone"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def test_create_zone_duplicate_different_pools(self):"},{"line_number":476,"context_line":"        fixture \u003d self.get_zone_fixture()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_cc72c07c","line":473,"updated":"2015-11-16 23:13:18.000000000","message":"Is there a reason to drop the assertion regarding the notifier?","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8a0f4af520035127a81ef8c5f9ff62f205ae56bb","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(set([n.hostname for n in pool.ns_records]),"},{"line_number":471,"context_line":"                         set([n.data for n in ns_recordset.records]))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        return zone"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def test_create_zone_duplicate_different_pools(self):"},{"line_number":476,"context_line":"        fixture \u003d self.get_zone_fixture()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_b9dc38e5","line":473,"in_reply_to":"ba8a016a_cc72c07c","updated":"2015-11-17 14:10:16.000000000","message":"yes, kinda.\nWe now emit 2 events, and this is not compatible with \"assert_called_once_with()\"","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        notified_zone \u003d mock_notifier.call_args[0][-1]"},{"line_number":854,"context_line":"        self.assertIsInstance(notified_zone, objects.Zone)"},{"line_number":855,"context_line":"        self.assertEqual(zone.id, notified_zone.id)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    def test_update_zone_without_id(self):"},{"line_number":858,"context_line":"        # Create a zone"},{"line_number":859,"context_line":"        zone \u003d self.create_zone(email\u003d\u0027info@example.org\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_8c6cb89d","line":856,"updated":"2015-11-16 23:13:18.000000000","message":"Again, we lost the notifier assertion.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f4b4aa7795c3c3f574bfe7eaa45f1c46793f6503","unresolved":false,"context_lines":[{"line_number":961,"context_line":"        notified_zone \u003d mock_notifier.call_args[0][-1]"},{"line_number":962,"context_line":"        self.assertIsInstance(notified_zone, objects.Zone)"},{"line_number":963,"context_line":"        self.assertEqual(deleted_zone.id, notified_zone.id)"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"    def test_delete_parent_zone(self):"},{"line_number":966,"context_line":"        # Create the Parent Zone using fixture 0"},{"line_number":967,"context_line":"        parent_zone \u003d self.create_zone(fixture\u003d0)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_ccf960ca","line":964,"updated":"2015-11-16 23:13:18.000000000","message":"One more notifier assertion dropped.","commit_id":"77c94faf6cd7a7e495e919099b53976127acc110"}]}