)]}'
{"designate/__init__.py":[{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"fdf3ecb1f4527c083315532905dc63ae03f42f2f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.IntOpt(\u0027default-soa-minimum\u0027, default\u003d3600),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Supported record types"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027supported-record-type\u0027, help\u003d\u0027Supported record types\u0027,"},{"line_number":64,"context_line":"                default\u003d[\u0027A\u0027, \u0027AAAA\u0027, \u0027CNAME\u0027, \u0027MX\u0027, \u0027SRV\u0027, \u0027TXT\u0027, \u0027SPF\u0027, \u0027NS\u0027,"},{"line_number":65,"context_line":"                         \u0027PTR\u0027, \u0027SSHFP\u0027, \u0027SOA\u0027]),"},{"line_number":66,"context_line":"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_583fff86","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"updated":"2016-01-29 17:23:11.000000000","message":"Could you also add this new option to etc/designate/designate.conf.sample ?","commit_id":"c0a1af82dcda0f7c503171b5e09398ab32d202eb"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"719ce09f8f869186258dfe8b8678bc23fc2fc835","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.IntOpt(\u0027default-soa-minimum\u0027, default\u003d3600),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Supported record types"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027supported-record-type\u0027, help\u003d\u0027Supported record types\u0027,"},{"line_number":64,"context_line":"                default\u003d[\u0027A\u0027, \u0027AAAA\u0027, \u0027CNAME\u0027, \u0027MX\u0027, \u0027SRV\u0027, \u0027TXT\u0027, \u0027SPF\u0027, \u0027NS\u0027,"},{"line_number":65,"context_line":"                         \u0027PTR\u0027, \u0027SSHFP\u0027, \u0027SOA\u0027]),"},{"line_number":66,"context_line":"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_6e6d4e30","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"in_reply_to":"7a5de9d1_583fff86","updated":"2016-01-29 19:45:56.000000000","message":"It has the default value defined here, not sure if necessary to do the same in designate.conf.sample, same case for default-soa-*","commit_id":"c0a1af82dcda0f7c503171b5e09398ab32d202eb"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"874bad878d3acb9dc3eeb36cad0d64969d7712ec","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.IntOpt(\u0027default-soa-minimum\u0027, default\u003d3600),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Supported record types"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027supported-record-type\u0027, help\u003d\u0027Supported record types\u0027,"},{"line_number":64,"context_line":"                default\u003d[\u0027A\u0027, \u0027AAAA\u0027, \u0027CNAME\u0027, \u0027MX\u0027, \u0027SRV\u0027, \u0027TXT\u0027, \u0027SPF\u0027, \u0027NS\u0027,"},{"line_number":65,"context_line":"                         \u0027PTR\u0027, \u0027SSHFP\u0027, \u0027SOA\u0027]),"},{"line_number":66,"context_line":"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_3d7c1ceb","line":63,"updated":"2016-02-01 22:33:33.000000000","message":"We might want to make this `supported-record-types` (\u0027s\u0027 at the end) since it is a list. Not going to -1 for it though.","commit_id":"1da296d17008344ac04aa6390bcfd324747c9887"}],"designate/schema/format.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"de8a86522609fd9c891aa3c77450262709917a33","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"RECORD_TYPES \u003d set(cfg.CONF.supported_record_type)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# NOTE(kiall): All of the below regular expressions are termined with"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_aff759f4","line":27,"updated":"2016-01-27 10:34:06.000000000","message":"The variable name could be more explicit, SUPPORTED_RECORD_TYPES","commit_id":"50f25662e3e5c78037465d3830c7559b7b705e0f"},{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"de8a86522609fd9c891aa3c77450262709917a33","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return True"},{"line_number":155,"context_line":"    else:"},{"line_number":156,"context_line":"        return False"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"@draft3_format_checker.checks(\"tld-name\")"},{"line_number":160,"context_line":"@draft4_format_checker.checks(\"tldname\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_4f96e595","line":157,"updated":"2016-01-27 10:34:06.000000000","message":"return (instance in RECORD_TYPES)","commit_id":"50f25662e3e5c78037465d3830c7559b7b705e0f"}]}