)]}'
{"designate/exceptions.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"f5d0de112296ad77d6e6c2807b30b34ada0ae675","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    error_type \u003d \u0027no_servers_configured\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class NoFiltersConfigured(ConfigurationError):"},{"line_number":100,"context_line":"    error_code \u003d 500"},{"line_number":101,"context_line":"    error_type \u003d \u0027no_filters_configured\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_e3b65d3c","line":99,"updated":"2016-03-07 20:15:50.000000000","message":"gah - yes","commit_id":"f1daa9ef158d9203413ea59131fc19652b7a216f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b247c669eb0cbab5e2aa97804e1aeb2eca4632d0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    error_type \u003d \u0027no_servers_configured\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class NoFiltersConfigured(ConfigurationError):"},{"line_number":100,"context_line":"    error_code \u003d 500"},{"line_number":101,"context_line":"    error_type \u003d \u0027no_filters_configured\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e096deee","line":99,"range":{"start_line":99,"start_character":6,"end_line":99,"end_character":25},"updated":"2016-03-02 19:38:55.000000000","message":"leftover from splitting this out?","commit_id":"f1daa9ef158d9203413ea59131fc19652b7a216f"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"66a01a4668fa3d0b1dd945ff55f036b2d05e4c86","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    error_type \u003d \u0027no_servers_configured\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class NoFiltersConfigured(ConfigurationError):"},{"line_number":100,"context_line":"    error_code \u003d 500"},{"line_number":101,"context_line":"    error_type \u003d \u0027no_filters_configured\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_5415d63d","line":99,"in_reply_to":"5aef4532_e3b65d3c","updated":"2016-03-09 16:45:48.000000000","message":"Done","commit_id":"f1daa9ef158d9203413ea59131fc19652b7a216f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aada6a09a386a894690f03281af1270c55f6c479","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    error_type \u003d \u0027no_servers_configured\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class MultiplePoolsFound(ConfigurationError):"},{"line_number":100,"context_line":"    error_code \u003d 500"},{"line_number":101,"context_line":"    error_type \u003d \u0027multiple_pools_found\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6b29c4e5","line":99,"range":{"start_line":99,"start_character":6,"end_line":99,"end_character":24},"updated":"2016-03-10 18:30:25.000000000","message":"Leftover? Harmless and needed real soon anyway, will let slide.","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"266846b63e6395cc18d5d0667d841b0becf4cd02","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def create_zone_master(self, context, zone_id, zone_master):"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        LOG.error(zone_master.to_dict())"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        zone_master.zone_id \u003d zone_id"},{"line_number":566,"context_line":"        return self._create(tables.zone_masters, zone_master,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_22923058","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":17},"updated":"2016-02-25 17:11:17.000000000","message":"Probably don\u0027t want this in there ;)","commit_id":"f1daa9ef158d9203413ea59131fc19652b7a216f"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"66a01a4668fa3d0b1dd945ff55f036b2d05e4c86","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def create_zone_master(self, context, zone_id, zone_master):"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        LOG.error(zone_master.to_dict())"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        zone_master.zone_id \u003d zone_id"},{"line_number":566,"context_line":"        return self._create(tables.zone_masters, zone_master,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_310bfc2b","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":17},"in_reply_to":"9aed3d3a_22923058","updated":"2016-03-09 16:45:48.000000000","message":"Done","commit_id":"f1daa9ef158d9203413ea59131fc19652b7a216f"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"53dab918fa1f0a8c004f590756a289d7f6531a4d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            exceptions.ZoneNotFound,"},{"line_number":307,"context_line":"            [\u0027attributes\u0027, \u0027recordsets\u0027, \u0027masters\u0027])"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if zone.obj_attr_is_set(\u0027attributes\u0027) and len(zone.masters) \u003e 0:"},{"line_number":310,"context_line":"            # Gather the Attribute ID\u0027s we have"},{"line_number":311,"context_line":"            have \u003d set([r.id for r in self._find_zone_attributes("},{"line_number":312,"context_line":"                context, {\u0027zone_id\u0027: zone.id})])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_c6f1ef96","line":309,"updated":"2016-03-10 18:42:31.000000000","message":"Done","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aada6a09a386a894690f03281af1270c55f6c479","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            exceptions.ZoneNotFound,"},{"line_number":307,"context_line":"            [\u0027attributes\u0027, \u0027recordsets\u0027, \u0027masters\u0027])"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if zone.obj_attr_is_set(\u0027attributes\u0027) and len(zone.masters) \u003e 0:"},{"line_number":310,"context_line":"            # Gather the Attribute ID\u0027s we have"},{"line_number":311,"context_line":"            have \u003d set([r.id for r in self._find_zone_attributes("},{"line_number":312,"context_line":"                context, {\u0027zone_id\u0027: zone.id})])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_8b71b00e","line":309,"range":{"start_line":309,"start_character":59,"end_line":309,"end_character":66},"updated":"2016-03-10 18:30:25.000000000","message":"Shouldn\u0027t this be zone.attributes? Also prevents the deletion of the last attribute","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"53dab918fa1f0a8c004f590756a289d7f6531a4d","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                attr.zone_id \u003d zone.id"},{"line_number":347,"context_line":"                self.create_zone_attribute(context, zone.id, attr)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if zone.obj_attr_is_set(\u0027masters\u0027) and len(zone.masters) \u003e 0:"},{"line_number":350,"context_line":"            # Gather the Attribute ID\u0027s we have"},{"line_number":351,"context_line":"            have \u003d set([r.id for r in self._find_zone_masters("},{"line_number":352,"context_line":"                context, {\u0027zone_id\u0027: zone.id})])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a6eca3bb","line":349,"updated":"2016-03-10 18:42:31.000000000","message":"Done","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aada6a09a386a894690f03281af1270c55f6c479","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                attr.zone_id \u003d zone.id"},{"line_number":347,"context_line":"                self.create_zone_attribute(context, zone.id, attr)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if zone.obj_attr_is_set(\u0027masters\u0027) and len(zone.masters) \u003e 0:"},{"line_number":350,"context_line":"            # Gather the Attribute ID\u0027s we have"},{"line_number":351,"context_line":"            have \u003d set([r.id for r in self._find_zone_masters("},{"line_number":352,"context_line":"                context, {\u0027zone_id\u0027: zone.id})])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_8b8d30d5","line":349,"range":{"start_line":349,"start_character":7,"end_line":349,"end_character":69},"updated":"2016-03-10 18:30:25.000000000","message":"prevents the deletion of the last master (i.e. moving from SECONDARY -\u003e PRIMARY)","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"}],"designate/storage/impl_sqlalchemy/tables.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"53dab918fa1f0a8c004f590756a289d7f6531a4d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"POOL_PROVISIONERS \u003d [\u0027UNMANAGED\u0027]"},{"line_number":37,"context_line":"ACTIONS \u003d [\u0027CREATE\u0027, \u0027DELETE\u0027, \u0027UPDATE\u0027, \u0027NONE\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ZONE_ATTRIBUTE_KEYS \u003d (\u0027master\u0027,)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ZONE_TYPES \u003d (\u0027PRIMARY\u0027, \u0027SECONDARY\u0027,)"},{"line_number":42,"context_line":"ZONE_TASK_TYPES \u003d [\u0027IMPORT\u0027, \u0027EXPORT\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_062e37fa","line":39,"updated":"2016-03-10 18:42:31.000000000","message":"Done","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aada6a09a386a894690f03281af1270c55f6c479","unresolved":false,"context_lines":[{"line_number":36,"context_line":"POOL_PROVISIONERS \u003d [\u0027UNMANAGED\u0027]"},{"line_number":37,"context_line":"ACTIONS \u003d [\u0027CREATE\u0027, \u0027DELETE\u0027, \u0027UPDATE\u0027, \u0027NONE\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ZONE_ATTRIBUTE_KEYS \u003d (\u0027master\u0027,)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ZONE_TYPES \u003d (\u0027PRIMARY\u0027, \u0027SECONDARY\u0027,)"},{"line_number":42,"context_line":"ZONE_TASK_TYPES \u003d [\u0027IMPORT\u0027, \u0027EXPORT\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_eb65d41d","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":19},"updated":"2016-03-10 18:30:25.000000000","message":"leftover?","commit_id":"a44f0065e7db10cf30a010ad38861f15444609f9"}]}