)]}'
{"designate/service.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"db135fb002b1f53a5630f492bc6e75fa151ae0e3","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            # ending unexpectedly. Ensure proper ordering of blocks, and"},{"line_number":268,"context_line":"            # ensure no exceptions are generated from within."},{"line_number":269,"context_line":"            except socket.timeout:"},{"line_number":270,"context_line":"                client.close()"},{"line_number":271,"context_line":"                LOG.warning(_LW(\"TCP Timeout from: %(host)s:%(port)d\") %"},{"line_number":272,"context_line":"                            {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_5d9f1350","line":270,"updated":"2016-02-26 15:02:15.000000000","message":"All the client.close() could be moved to one line at the end in a finally clause.","commit_id":"2a7a4cd2772df189dd328d7a6d347223e27e3226"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"320b3423ad25705dace92c6890d7a0a4086fc879","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            # ending unexpectedly. Ensure proper ordering of blocks, and"},{"line_number":268,"context_line":"            # ensure no exceptions are generated from within."},{"line_number":269,"context_line":"            except socket.timeout:"},{"line_number":270,"context_line":"                client.close()"},{"line_number":271,"context_line":"                LOG.warning(_LW(\"TCP Timeout from: %(host)s:%(port)d\") %"},{"line_number":272,"context_line":"                            {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_cebb0fe4","line":270,"in_reply_to":"9aed3d3a_5d9f1350","updated":"2016-02-29 15:15:38.000000000","message":"It looks like the else clause intends for the client to be open for further asynchronous processing; while I could move these close() invocations to a finally block, I\u0027d have to track with a flag to ensure it\u0027s NOT closed for the else clause.\n\nI\u0027ll submit another patch with what I came up with, and can revert if it\u0027s agreed that it\u0027s too verbose.","commit_id":"2a7a4cd2772df189dd328d7a6d347223e27e3226"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5ee4f5a5dde18f4c5f7b3c4908f43ca9837e8adf","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            # ending unexpectedly. Ensure proper ordering of blocks, and"},{"line_number":268,"context_line":"            # ensure no exceptions are generated from within."},{"line_number":269,"context_line":"            except socket.timeout:"},{"line_number":270,"context_line":"                client.close()"},{"line_number":271,"context_line":"                LOG.warning(_LW(\"TCP Timeout from: %(host)s:%(port)d\") %"},{"line_number":272,"context_line":"                            {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_eeb89377","line":270,"in_reply_to":"9aed3d3a_5d9f1350","updated":"2016-02-29 15:18:01.000000000","message":"Let\u0027s keep this change to just 1 change.. Reworking how the close\u0027s are called is unrelated to the issue this patch is fixing.","commit_id":"2a7a4cd2772df189dd328d7a6d347223e27e3226"},{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"db135fb002b1f53a5630f492bc6e75fa151ae0e3","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                LOG.warning(_LW(\"Invalid packet from: %(host)s:%(port)d\") %"},{"line_number":284,"context_line":"                         {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            except Exception:"},{"line_number":287,"context_line":"                client.close()"},{"line_number":288,"context_line":"                LOG.exception(_LE(\"Unknown exception handling TCP request \""},{"line_number":289,"context_line":"                                  \"from: %(host)s:%(port)d\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_7de817e3","line":286,"updated":"2016-02-26 15:02:15.000000000","message":"BTW, this could the unknown exception message","commit_id":"2a7a4cd2772df189dd328d7a6d347223e27e3226"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"320b3423ad25705dace92c6890d7a0a4086fc879","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                LOG.warning(_LW(\"Invalid packet from: %(host)s:%(port)d\") %"},{"line_number":284,"context_line":"                         {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            except Exception:"},{"line_number":287,"context_line":"                client.close()"},{"line_number":288,"context_line":"                LOG.exception(_LE(\"Unknown exception handling TCP request \""},{"line_number":289,"context_line":"                                  \"from: %(host)s:%(port)d\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_4ed37f04","line":286,"in_reply_to":"9aed3d3a_7de817e3","updated":"2016-02-29 15:15:38.000000000","message":"Do you mean this could be the cause of the exception that this change was addressing?  From what we observed it was a KeyError being thrown from inside the \"except socket.error\" block.\n\nUnfortunately new exceptions raised from inside that block wouldn\u0027t be caught by this block.","commit_id":"2a7a4cd2772df189dd328d7a6d347223e27e3226"}]}