)]}'
{"devstack/gate/post_test_hook.sh":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5193d3f4e60c933cc56c3edba116405c4c0eee69","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# Run the Designate Tempest tests"},{"line_number":37,"context_line":"sudo ./run_tempest_tests.sh"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DESIGNATE_CLI_DIR\u003d${DESIGNATE_CLI_DIR:-/opt/stack/new/python-designateclient}"},{"line_number":40,"context_line":"CLI_TEMPEST_CONFIG\u003d\"$DESIGNATE_CLI_DIR/tempest.conf\""},{"line_number":41,"context_line":"cp $TEMPEST_CONFIG $CLI_TEMPEST_CONFIG"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_8785cdae","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":49},"updated":"2016-03-29 19:42:03.000000000","message":"should use \"$BASE\" in place of /opt/stack (some gate jobs apparently use a different path)","commit_id":"f9a60520c45f77113d6f51e3d24428578bf9599e"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5193d3f4e60c933cc56c3edba116405c4c0eee69","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DESIGNATE_CLI_DIR\u003d${DESIGNATE_CLI_DIR:-/opt/stack/new/python-designateclient}"},{"line_number":40,"context_line":"CLI_TEMPEST_CONFIG\u003d\"$DESIGNATE_CLI_DIR/tempest.conf\""},{"line_number":41,"context_line":"cp $TEMPEST_CONFIG $CLI_TEMPEST_CONFIG"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# TODO(pglass) - update cli tests to look in the [auth] section for admin creds"},{"line_number":44,"context_line":"iniset $CLI_TEMPEST_CONFIG identity admin_username ${ADMIN_USERNAME:-\"admin\"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_e7abe91b","line":41,"updated":"2016-03-29 19:42:03.000000000","message":"Nit: Ideally, the CLI tests could be told to use $TEMPEST_CONFIG without needing to copy it around..","commit_id":"f9a60520c45f77113d6f51e3d24428578bf9599e"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"48d8847dc7195e81bcd21331804ee41ba418e060","unresolved":false,"context_lines":[{"line_number":34,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Run the Designate Tempest tests"},{"line_number":37,"context_line":"sudo BASE\u003d$BASE ./run_tempest_tests.sh"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# TODO(pglass) - update cli tests to look in the [auth] section for admin creds"},{"line_number":40,"context_line":"iniset $TEMPEST_CONFIG identity admin_username ${ADMIN_USERNAME:-\"admin\"}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"ba0121b8_e48f31ca","line":37,"updated":"2016-03-30 14:32:24.000000000","message":"Have you tried using the login shell (e.g. sudo -i ./run_tempest_tests.sh) rather than having to pass the env vars explicitly?","commit_id":"c3a547e6c5523df0bca29ab1f5dcf1b72ebf11d8"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"993897298e38aa70e47c7c9c6453a9c9a2d0686f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Run the Designate Tempest tests"},{"line_number":37,"context_line":"sudo BASE\u003d$BASE ./run_tempest_tests.sh"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# TODO(pglass) - update cli tests to look in the [auth] section for admin creds"},{"line_number":40,"context_line":"iniset $TEMPEST_CONFIG identity admin_username ${ADMIN_USERNAME:-\"admin\"}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"ba0121b8_ff917a9a","line":37,"in_reply_to":"ba0121b8_e48f31ca","updated":"2016-03-30 14:34:55.000000000","message":"Nevermind, you\u0027re trying to bubble up variables from the non-privileged user into the sudo session, I don\u0027t believe my suggestion applies.","commit_id":"c3a547e6c5523df0bca29ab1f5dcf1b72ebf11d8"}]}
