)]}'
{"designate/api/v2/controllers/common.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9bb13d8fb35352f246dc6d2cd3ee7888b2612d3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiall Mac Innes \u003ckiall@hpe.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_25f7d0f6","line":1,"updated":"2016-04-21 16:05:45.000000000","message":"RAX might like new headers","commit_id":"fd0fb282e49aeedbf280e6d959123da0dfe2c370"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a744ae9939347eea23366253112a9955b75fbc0c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    return recordsets"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def get_canonical_location(request, zone_id, rrset_id):"},{"line_number":45,"context_line":"    return \u0027{base_url}/v2/zones/{zone_id}/recordsets/{id}\u0027.format("},{"line_number":46,"context_line":"            base_url\u003drequest.host_url, zone_id\u003dzone_id,"},{"line_number":47,"context_line":"            id\u003drrset_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_55bf6160","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":26},"updated":"2016-05-11 15:24:52.000000000","message":"nit (only if there is another patchset) - this should really have rrset in the name as it is in the common utils module","commit_id":"378a82151de32fef0bedc985e0c300a71d8d00db"}],"designate/objects/adapters/api_v2/base.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9bb13d8fb35352f246dc6d2cd3ee7888b2612d3a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                (base_uri, cls._get_path(request, object), object.id)}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"},{"line_number":94,"context_line":"    def _get_path(cls, request, object\u003dNone):"},{"line_number":95,"context_line":"        path \u003d request.path.lstrip(\u0027/\u0027).split(\u0027/\u0027)"},{"line_number":96,"context_line":"        item_path \u003d \u0027\u0027"},{"line_number":97,"context_line":"        for part in path:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_65d9c883","line":94,"updated":"2016-04-21 16:05:45.000000000","message":"We can just override the call in the recordset adaptor to avoid leaving this unused for other objects","commit_id":"fd0fb282e49aeedbf280e6d959123da0dfe2c370"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"5a2137e6e1735ee194c2fe95d4a72b49b5453a18","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            base_uri \u003d cls.BASE_URI"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if cls.__name__ \u003d\u003d \u0027RecordSetAPIv2Adapter\u0027:"},{"line_number":91,"context_line":"            path \u003d cls._get_path(request, object)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            path \u003d cls._get_path(request)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return {\u0027self\u0027: \u0027%s%s/%s\u0027 % (base_uri, path, object.id)}"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1c3f3026","line":93,"range":{"start_line":90,"start_character":8,"end_line":93,"end_character":41},"updated":"2016-05-04 14:51:47.000000000","message":"This is okay, I guess. However, all implementations of _get_path() should accept the same inputs, so that callers don\u0027t need to guess at how to invoke the method.","commit_id":"03360edf8d40b72f84568d5ca8ba54423ec047aa"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"aa39ae09a2c224bc9443697d3498c5029bd67002","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            base_uri \u003d cls.BASE_URI"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if cls.__name__ \u003d\u003d \u0027RecordSetAPIv2Adapter\u0027:"},{"line_number":91,"context_line":"            path \u003d cls._get_path(request, object)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            path \u003d cls._get_path(request)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return {\u0027self\u0027: \u0027%s%s/%s\u0027 % (base_uri, path, object.id)}"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_2b345bdc","line":93,"range":{"start_line":90,"start_character":8,"end_line":93,"end_character":41},"in_reply_to":"1a122d0e_1c3f3026","updated":"2016-05-04 15:59:30.000000000","message":"The previous patch did that, but Graham commented that he kind of likes to see the current one I think.\n\nhttps://review.openstack.org/#/c/301430/3/designate/objects/adapters/api_v2/base.py","commit_id":"03360edf8d40b72f84568d5ca8ba54423ec047aa"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"2b3594da945a711f1c5ccb295090618d6152b14b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            base_uri \u003d cls.BASE_URI"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if cls.__name__ \u003d\u003d \u0027RecordSetAPIv2Adapter\u0027:"},{"line_number":91,"context_line":"            path \u003d cls._get_path(request, object)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            path \u003d cls._get_path(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_daff7565","line":90,"updated":"2016-05-09 16:17:31.000000000","message":"I know this was addressed by Graham and Eric, but I was curious if you could improve on this by modifying base\u0027s _get_path to have *args in its arglist.\n\nThat way you could pass the object to both implementations and it wouldn\u0027t complain about unused variables (and you wouldn\u0027t have to have this classname-specific code).","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"2b3594da945a711f1c5ccb295090618d6152b14b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            base_uri \u003d cls.BASE_URI"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if cls.__name__ \u003d\u003d \u0027RecordSetAPIv2Adapter\u0027:"},{"line_number":91,"context_line":"            path \u003d cls._get_path(request, object)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            path \u003d cls._get_path(request)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_3a4b21b2","line":91,"updated":"2016-05-09 16:17:31.000000000","message":"Nitpick: this variable name shadows the Python global variable \"object\".","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"}],"designate/objects/adapters/api_v2/recordset.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"0bbe01d920574e701784ba16392952aef7810799","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        ori_path \u003d request.path"},{"line_number":121,"context_line":"        if \u0027zones\u0027 not in ori_path and object is not None:"},{"line_number":122,"context_line":"            ori_path \u003d ori_path.replace(\u0027/v2\u0027,"},{"line_number":123,"context_line":"                                        \u0027/v2/zones/{0}\u0027.format(object.zone_id))"},{"line_number":124,"context_line":"        path \u003d ori_path.lstrip(\u0027/\u0027).split(\u0027/\u0027)"},{"line_number":125,"context_line":"        item_path \u003d \u0027\u0027"},{"line_number":126,"context_line":"        for part in path:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_fc440b75","line":123,"updated":"2016-04-18 14:52:40.000000000","message":"Generally, I\u0027d argue against doing string transforms on the path like this. For example:\n\n  \u003e\u003e\u003e \u0027foo\u0027.replace(\u0027o\u0027, \u0027aa\u0027)\n  \u0027faaaa\u0027\n\nIf you happen to have a /v2 anywhere in the URL, it\u0027ll get clobbered. \n\nA better path (pun intended) would be to go ahead an parse it (split.(\u0027/\u0027)), and in this case, just adjust the path accordingly before looping below.","commit_id":"e1c340324baa4afe60a6926891f32c07f334a266"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"3fec4ca19f0d9397b52307b48666a654c267fb19","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        ori_path \u003d request.path"},{"line_number":121,"context_line":"        if \u0027zones\u0027 not in ori_path and object is not None:"},{"line_number":122,"context_line":"            ori_path \u003d ori_path.replace(\u0027/v2\u0027,"},{"line_number":123,"context_line":"                                        \u0027/v2/zones/{0}\u0027.format(object.zone_id))"},{"line_number":124,"context_line":"        path \u003d ori_path.lstrip(\u0027/\u0027).split(\u0027/\u0027)"},{"line_number":125,"context_line":"        item_path \u003d \u0027\u0027"},{"line_number":126,"context_line":"        for part in path:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_42c3ec8a","line":123,"in_reply_to":"1a122d0e_fc440b75","updated":"2016-04-21 13:29:39.000000000","message":"Done","commit_id":"e1c340324baa4afe60a6926891f32c07f334a266"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9bb13d8fb35352f246dc6d2cd3ee7888b2612d3a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                \u0027immutable\u0027: True"},{"line_number":34,"context_line":"            },"},{"line_number":35,"context_line":"            \"zone_name\": {"},{"line_number":36,"context_line":"                \u0027immutable\u0027: True,"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            \"type\": {"},{"line_number":39,"context_line":"                \u0027rename\u0027: \u0027type\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_85dce475","line":36,"updated":"2016-04-21 16:05:45.000000000","message":"Should be read_only - it is never set from the API","commit_id":"fd0fb282e49aeedbf280e6d959123da0dfe2c370"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"2b3594da945a711f1c5ccb295090618d6152b14b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            new_recordset, recordset, *args, **kwargs)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def _get_path(cls, request, object\u003dNone):"},{"line_number":120,"context_line":"        ori_path \u003d request.path"},{"line_number":121,"context_line":"        path \u003d ori_path.lstrip(\u0027/\u0027).split(\u0027/\u0027)"},{"line_number":122,"context_line":"        insert_zones \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_5a9545dc","line":119,"updated":"2016-05-09 16:17:31.000000000","message":"Similar nitpick to base.py: object shadows the global variable \"object\"","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"2b3594da945a711f1c5ccb295090618d6152b14b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            to_insert \u003d \u0027zones/{0}\u0027.format(object.zone_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        item_path \u003d \u0027\u0027"},{"line_number":129,"context_line":"        for part in path:"},{"line_number":130,"context_line":"            if part \u003d\u003d cls.MODIFICATIONS[\u0027options\u0027][\u0027collection_name\u0027]:"},{"line_number":131,"context_line":"                item_path +\u003d \u0027/\u0027 + part"},{"line_number":132,"context_line":"                return item_path"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_ee96fa4a","line":129,"updated":"2016-05-09 16:17:31.000000000","message":"Since there\u0027s a bit of logic happening here, I\u0027m wondering if a unit test or two might be helpful in demonstrating behavior to someone looking to modify this behavior in the future?","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a744ae9939347eea23366253112a9955b75fbc0c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            new_recordset, recordset, *args, **kwargs)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def _get_path(cls, request, obj, *args):"},{"line_number":120,"context_line":"        ori_path \u003d request.path"},{"line_number":121,"context_line":"        path \u003d ori_path.lstrip(\u0027/\u0027).split(\u0027/\u0027)"},{"line_number":122,"context_line":"        insert_zones \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_156158a9","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":42},"updated":"2016-05-11 15:24:52.000000000","message":"what are we using this for?","commit_id":"378a82151de32fef0bedc985e0c300a71d8d00db"}],"designate/objects/recordset.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9bb13d8fb35352f246dc6d2cd3ee7888b2612d3a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                \u0027format\u0027: \u0027domainname\u0027,"},{"line_number":102,"context_line":"                \u0027maxLength\u0027: 255,"},{"line_number":103,"context_line":"            },"},{"line_number":104,"context_line":"            \u0027immutable\u0027: True"},{"line_number":105,"context_line":"        },"},{"line_number":106,"context_line":"        \u0027name\u0027: {"},{"line_number":107,"context_line":"            \u0027schema\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_45f2cc07","line":104,"updated":"2016-04-21 16:05:45.000000000","message":"ReadOnly","commit_id":"fd0fb282e49aeedbf280e6d959123da0dfe2c370"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"0bbe01d920574e701784ba16392952aef7810799","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        id_zname_map \u003d {}"},{"line_number":681,"context_line":"        for r in rows:"},{"line_number":682,"context_line":"            id_zname_map[r[0]] \u003d r[1]"},{"line_number":683,"context_line":"        formatted_ids \u003d six.moves.map(operator.itemgetter(0), rows)"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        resultproxy \u003d self.session.execute(count_q)"},{"line_number":686,"context_line":"        result \u003d resultproxy.fetchone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_874ca471","line":683,"updated":"2016-04-18 14:52:40.000000000","message":"At first I thought the above comments regarding rs id and zone id were superfluous, but they make sense when you get here for the itemgetter.","commit_id":"e1c340324baa4afe60a6926891f32c07f334a266"}],"doc/source/install/ubuntu-dev.rst":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"b5a244c8457b36663e38180ffc65607a48fa6986","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"   $ cd openstack/designate"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"::"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":" If Designate was installed into a virtualenv, make sure your virtualenv is sourced"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_dfe807b7","line":309,"updated":"2016-05-09 15:36:11.000000000","message":"Ah hah! This is why you\u0027d get an error. This signals to rst that you want a pre-formatted block following the `::`. I believe we can drop it and all should be good.","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"3c8f9e3d8d7d9eb1db5f81ce283dfa435b9ff3e3","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"::"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":" If Designate was installed into a virtualenv, make sure your virtualenv is sourced"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"::"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_bbdd8e72","line":311,"updated":"2016-05-06 19:07:14.000000000","message":"Looks like a stray space slipped in.","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"2aef3d3e8d5681ea9debb30f88f335b712f23bc8","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"::"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":" If Designate was installed into a virtualenv, make sure your virtualenv is sourced"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"::"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_59a1d7a2","line":311,"in_reply_to":"dab17558_bbdd8e72","updated":"2016-05-09 15:19:55.000000000","message":"I got a warning from tox -e docs if there is no space at the beginning.","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"}],"doc/source/rest/v2/recordsets.rst":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"3c8f9e3d8d7d9eb1db5f81ce283dfa435b9ff3e3","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                \"type\": \"SOA\""},{"line_number":349,"context_line":"             },"},{"line_number":350,"context_line":"             {"},{"line_number":351,"context_line":"                \"name\": \"jjli.com.\","},{"line_number":352,"context_line":"                \"id\": \"12caacfd-f0fc-4bcb-aa24-c42769897822\","},{"line_number":353,"context_line":"                \"type\": \"SOA\","},{"line_number":354,"context_line":"                \"zone_name\": \"jjli.com.\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_3b5ebee9","line":351,"updated":"2016-05-06 19:07:14.000000000","message":"Should probably switch to an example.org|net|com domain.","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"2aef3d3e8d5681ea9debb30f88f335b712f23bc8","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                \"type\": \"SOA\""},{"line_number":349,"context_line":"             },"},{"line_number":350,"context_line":"             {"},{"line_number":351,"context_line":"                \"name\": \"jjli.com.\","},{"line_number":352,"context_line":"                \"id\": \"12caacfd-f0fc-4bcb-aa24-c42769897822\","},{"line_number":353,"context_line":"                \"type\": \"SOA\","},{"line_number":354,"context_line":"                \"zone_name\": \"jjli.com.\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_54c6be48","line":351,"in_reply_to":"dab17558_3b5ebee9","updated":"2016-05-09 15:19:55.000000000","message":"Done","commit_id":"53e2df4facb5e506332954df8a8ff222af0e9318"}],"functionaltests/api/v2/clients/recordset_client.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"5a2137e6e1735ee194c2fe95d4a72b49b5453a18","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            uri \u003d self.create_uri(\"/zones/{0}/recordsets\".format(zone_id),"},{"line_number":32,"context_line":"                                  filters\u003dfilters)"},{"line_number":33,"context_line":"        return uri"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def recordset_uri(self, zone_id, recordset_id, cross_zone\u003dFalse):"},{"line_number":36,"context_line":"        return \"{0}/{1}\".format(self.recordsets_uri(zone_id, cross_zone),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_576223d9","line":33,"updated":"2016-05-04 14:51:47.000000000","message":"Ignore this, since we\u0027re migrating these functional tests over to the tempest plugin, but I think there should be a new client class for the /v2/recordsets endpoint.","commit_id":"03360edf8d40b72f84568d5ca8ba54423ec047aa"},{"author":{"_account_id":6662,"name":"James Li","email":"yueli.m@gmail.com","username":"james-li-3"},"change_message_id":"aa39ae09a2c224bc9443697d3498c5029bd67002","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            uri \u003d self.create_uri(\"/zones/{0}/recordsets\".format(zone_id),"},{"line_number":32,"context_line":"                                  filters\u003dfilters)"},{"line_number":33,"context_line":"        return uri"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def recordset_uri(self, zone_id, recordset_id, cross_zone\u003dFalse):"},{"line_number":36,"context_line":"        return \"{0}/{1}\".format(self.recordsets_uri(zone_id, cross_zone),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ab7b4b7a","line":33,"in_reply_to":"1a122d0e_576223d9","updated":"2016-05-04 15:59:30.000000000","message":"yeah a new client class would be ideal. Do you want me to make that change in this patch?","commit_id":"03360edf8d40b72f84568d5ca8ba54423ec047aa"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"73ee46f96e5caff6878fc4cb81057905e19ec8bf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            uri \u003d self.create_uri(\"/zones/{0}/recordsets\".format(zone_id),"},{"line_number":32,"context_line":"                                  filters\u003dfilters)"},{"line_number":33,"context_line":"        return uri"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def recordset_uri(self, zone_id, recordset_id, cross_zone\u003dFalse):"},{"line_number":36,"context_line":"        return \"{0}/{1}\".format(self.recordsets_uri(zone_id, cross_zone),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_cb4e87c1","line":33,"in_reply_to":"1a122d0e_ab7b4b7a","updated":"2016-05-04 16:05:03.000000000","message":"You don\u0027t need to. We have to rewrite clients when we move things over to the tempest plugin anyway.","commit_id":"03360edf8d40b72f84568d5ca8ba54423ec047aa"}]}