)]}'
{"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ec9307fb5cef4e21df8326e20e6d949ce8e0b2ea","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        return ns"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _add_ns(self, context, zone, ns_record):"},{"line_number":551,"context_line":"        # Get NS recordset, ensure we always get the managed one if it exists"},{"line_number":552,"context_line":"        # regardless of pagination"},{"line_number":553,"context_line":"        # If the zone doesn\u0027t have an NS recordset yet, create one"},{"line_number":554,"context_line":"        recordsets \u003d self.find_recordsets("},{"line_number":555,"context_line":"            context, criterion\u003d{\u0027zone_id\u0027: zone[\u0027id\u0027], \u0027type\u0027: \"NS\"},"},{"line_number":556,"context_line":"            sort_key\u003d\u0027created_at\u0027, sort_dir\u003d\u0027asc\u0027"},{"line_number":557,"context_line":"        )"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        managed \u003d []"},{"line_number":560,"context_line":"        for rs in recordsets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_13c0c27a","line":557,"range":{"start_line":551,"start_character":8,"end_line":557,"end_character":9},"updated":"2016-05-09 19:39:57.000000000","message":"If the intent here is to find the managed records, should we not instead filter on the managed\u003dTrue column vs sorting by date created? Though, to be 100% correct, we probably still want to page the results.\n\nIf NS are added/removed over time from the pool, the created date wont be enough to ensure we find all the matching rows.","commit_id":"e52fceb330c14ab35092849d6bfaa838f6c1b3c5"}]}