)]}'
{"designate/metrics.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"537062297d61a6766095929850d5cf8d118b8ed9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Do not start sending metrics yet."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        self._client \u003d monascastatsd.Client(dimensions\u003d{"},{"line_number":71,"context_line":"            \u0027product\u0027: \u0027designate\u0027"},{"line_number":72,"context_line":"        })"},{"line_number":73,"context_line":"        # cfg.CONF is not available at this time"},{"line_number":74,"context_line":"        # Buffer all metrics until init() is called"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_54b6d58a","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":20},"updated":"2016-08-25 09:57:18.000000000","message":"This should line up with the other Monasca Designate stuff from [1] - e.g. service_name\u003ddns\n\n[1]: https://github.com/openstack/monasca-agent/blob/master/monasca_setup/detection/plugins/designate.py","commit_id":"4e20dd6ef1ae9497c8d487866f23a874d726e2ed"},{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"be539ea71328aabbe244cd3da24eb8f019f3fed2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Do not start sending metrics yet."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        self._client \u003d monascastatsd.Client(dimensions\u003d{"},{"line_number":71,"context_line":"            \u0027product\u0027: \u0027designate\u0027"},{"line_number":72,"context_line":"        })"},{"line_number":73,"context_line":"        # cfg.CONF is not available at this time"},{"line_number":74,"context_line":"        # Buffer all metrics until init() is called"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_03feca37","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":20},"in_reply_to":"1ac06dbe_54b6d58a","updated":"2016-08-25 15:58:36.000000000","message":"We have access to the real service name and the Monasca address and port only after Metrics.__init__() has been run and there is no way in the client to update the dimensions dictionary for the metric producers that have already been instantiated (as decorators).\n\nI opened https://bugs.launchpad.net/monasca/+bug/1616060 and we can update this file once the bug is fixed.\n\nAn alternative could be that we proxy every call to the statsd client and we instantiate it only when we have all the right values.","commit_id":"4e20dd6ef1ae9497c8d487866f23a874d726e2ed"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"537062297d61a6766095929850d5cf8d118b8ed9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                \u0027host\u0027: conf.hostname,"},{"line_number":87,"context_line":"                \u0027port\u0027: conf.port"},{"line_number":88,"context_line":"            })"},{"line_number":89,"context_line":"            self._client.connection._flush_buffer()"},{"line_number":90,"context_line":"            self._client.connection.close_buffer()"},{"line_number":91,"context_line":"            self._client.connection.connect(conf.hostname, conf.port)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            LOG.info(_LI(\"Statsd disabled\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_17745f9a","line":90,"range":{"start_line":89,"start_character":12,"end_line":90,"end_character":50},"updated":"2016-08-25 09:57:18.000000000","message":"This looks like we\u0027re using a private API, is this necessary? Can we leave a comment with details why?","commit_id":"4e20dd6ef1ae9497c8d487866f23a874d726e2ed"},{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"be539ea71328aabbe244cd3da24eb8f019f3fed2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                \u0027host\u0027: conf.hostname,"},{"line_number":87,"context_line":"                \u0027port\u0027: conf.port"},{"line_number":88,"context_line":"            })"},{"line_number":89,"context_line":"            self._client.connection._flush_buffer()"},{"line_number":90,"context_line":"            self._client.connection.close_buffer()"},{"line_number":91,"context_line":"            self._client.connection.connect(conf.hostname, conf.port)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            LOG.info(_LI(\"Statsd disabled\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_37dd0e71","line":90,"range":{"start_line":89,"start_character":12,"end_line":90,"end_character":50},"in_reply_to":"1ac06dbe_17745f9a","updated":"2016-08-25 15:58:36.000000000","message":"Yes we are, I opened a bug report to fix this and it\u0027s linked in a comment above (in __init__)","commit_id":"4e20dd6ef1ae9497c8d487866f23a874d726e2ed"}],"etc/designate/designate.conf.sample":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"537062297d61a6766095929850d5cf8d118b8ed9","unresolved":false,"context_lines":[{"line_number":535,"context_line":"##################"},{"line_number":536,"context_line":"[monasca:statsd]"},{"line_number":537,"context_line":"# Disabled by default"},{"line_number":538,"context_line":"# enabled \u003d False"},{"line_number":539,"context_line":"# Statsd server hostname"},{"line_number":540,"context_line":"# hostname \u003d 127.0.0.1"},{"line_number":541,"context_line":"# Statsd server UDP port"},{"line_number":542,"context_line":"# port \u003d 8125"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"1ac06dbe_97896fcd","line":542,"range":{"start_line":538,"start_character":0,"end_line":542,"end_character":13},"updated":"2016-08-25 09:57:18.000000000","message":"Convention is for no space between a commented config option and the # (Makes actual comments visible from commented config options)","commit_id":"4e20dd6ef1ae9497c8d487866f23a874d726e2ed"}]}