)]}'
{"designate/notification_handler/neutron.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"28ae32b93300012be08bc7bd4f5b3313accb01c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027control-exchange\u0027, default\u003d\u0027neutron\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027zone-id\u0027),"},{"line_number":33,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, default\u003d["},{"line_number":34,"context_line":"                    \u0027%(octet0)s-%(octet1)s-%(octet2)s-%(octet3)s.%(zone)s\u0027]),"},{"line_number":35,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, default\u003dNone),"},{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, default\u003dNone)"},{"line_number":37,"context_line":"], group\u003d\u0027handler:neutron_floatingip\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_952a16e6","line":34,"updated":"2016-07-08 17:34:37.000000000","message":"we should mark this as deprecated - http://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.DeprecatedOpt","commit_id":"8d6927861579e1ce29de1f028569b52b335a072d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cb602d04de227458d1248afed0f0d4d01e4caf3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027control-exchange\u0027, default\u003d\u0027neutron\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027zone-id\u0027),"},{"line_number":33,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, default\u003dNone),"},{"line_number":34,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, default\u003dNone, deprecated_opts\u003d["},{"line_number":35,"context_line":"        cfg.DeprecatedOpt(\u0027format\u0027), ]),"},{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, default\u003dNone)"},{"line_number":37,"context_line":"], group\u003d\u0027handler:neutron_floatingip\u0027)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e53e28d9","line":35,"range":{"start_line":34,"start_character":44,"end_line":35,"end_character":38},"updated":"2016-07-19 10:51:36.000000000","message":"While this works, it\u0027s not the pattern we tend to use. We use something like this:\n\n    cfg.PortOpt(\u0027api_port\u0027,\n                deprecated_for_removal\u003dTrue,\n                deprecated_reason\u003d\"Replaced by \u0027listen\u0027 option\",\n                help\u003d\u0027API Port Number\u0027),\n\nThe reason is important, so users and others can see what they need to do in order to stop using the deprecated option.","commit_id":"c691fce200f6791b16459dfc9022155c53160540"}],"designate/notification_handler/nova.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"28ae32b93300012be08bc7bd4f5b3313accb01c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027control-exchange\u0027, default\u003d\u0027nova\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027zone-id\u0027),"},{"line_number":33,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, default\u003d["},{"line_number":34,"context_line":"                    \u0027%(octet0)s-%(octet1)s-%(octet2)s-%(octet3)s.%(zone)s\u0027]),"},{"line_number":35,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, default\u003dNone),"},{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, default\u003dNone)"},{"line_number":37,"context_line":"], group\u003d\u0027handler:nova_fixed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_752faaf6","line":34,"updated":"2016-07-08 17:34:37.000000000","message":"we should mark this as deprecated - http://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.DeprecatedOpt","commit_id":"8d6927861579e1ce29de1f028569b52b335a072d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cb602d04de227458d1248afed0f0d4d01e4caf3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027control-exchange\u0027, default\u003d\u0027nova\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027zone-id\u0027),"},{"line_number":33,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, default\u003dNone),"},{"line_number":34,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, default\u003dNone, deprecated_opts\u003d["},{"line_number":35,"context_line":"        cfg.DeprecatedOpt(\u0027format\u0027), ]),"},{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, default\u003dNone)"},{"line_number":37,"context_line":"], group\u003d\u0027handler:nova_fixed\u0027)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_a51b907f","line":35,"range":{"start_line":34,"start_character":4,"end_line":35,"end_character":40},"updated":"2016-07-19 10:51:36.000000000","message":"Same comment as the other handler :)","commit_id":"c691fce200f6791b16459dfc9022155c53160540"}]}