)]}'
{"designate/notification_handler/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"1bb233b3bf61a591a26833b9181d6eaf06178633","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class BaseAddressHandler(NotificationHandler):"},{"line_number":92,"context_line":"    default_formatv4 \u003d \u0027%(hostname)s.%(domain)s\u0027"},{"line_number":93,"context_line":"    default_formatv6 \u003d \u0027%(hostname)s.%(domain)s\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_ip_data(self, addr_dict):"},{"line_number":96,"context_line":"        ip \u003d addr_dict[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_53f372d6","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":48},"updated":"2016-08-16 13:12:06.000000000","message":"I think I see a bug here (and in the original code). We do this..\n    \n    format \u003d self._get_formatv4()\n    for fmt in format:\n       # Do stuff\n\nwhere `self._get_formatv4()` can return `self.default_formatv4`.. Resulting in:\n\n\t\u003e\u003e\u003e default_formatv4 \u003d \u0027%(hostname)s.%(domain)s\u0027\n\t\u003e\u003e\u003e for f in default_formatv4:\n\t...     print f\n\t... \n\t%\n\t(\n\th\n\to\n\ts\n\tt\n\tn\n\ta\n\tm\n\te\n\t)\n\ts\n\t.\n\t%\n\t(\n\td\n\to\n\tm\n\ta\n\ti\n\tn\n\t)\n\ts\n\t\u003e\u003e\u003e \n\nI believe these values should then be:\n\n    default_formatv4 \u003d (\u0027%(hostname)s.%(domain)s\u0027,)\n\n(Note the addition of the trailing comma inside the braces)\n\nThough, I have no idea why this is working. Is `self._get_formatv4()` always returning from config? If the config optiones have these values set as their default, then maybe the `self._get_formatv*()` methods shouldn\u0027t attempt to return the default variables?","commit_id":"572c88309d5492ded13395f20df94aa3bca37dd9"}]}