)]}'
{"designate/mdns/handler.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c24743e2fbb5d38385076355d5194bd74ef750a7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                return None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            packets \u003d self._axfr_cache[zone.name][\u0027packets\u0027]"},{"line_number":262,"context_line":"            for p in packets:"},{"line_number":263,"context_line":"                p.id \u003d request.id"},{"line_number":264,"context_line":"                p.write_header()"},{"line_number":265,"context_line":"            metrics.counter(name\u003d\u0027mdns.axfr.cache.hits\u0027).increment()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_9a2e74f8","line":262,"updated":"2017-05-19 17:05:36.000000000","message":"I would personally prefer to write p out as packet, for packet in packets.","commit_id":"391534468c08f3018fadd34c41ff615bf81bc566"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c24743e2fbb5d38385076355d5194bd74ef750a7","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        if size_threshold is -1:"},{"line_number":304,"context_line":"            return"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        t \u003d time.time()"},{"line_number":307,"context_line":"        cache_items \u003d []"},{"line_number":308,"context_line":"        for zone_name in self._axfr_cache.keys():"},{"line_number":309,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_da1cecc2","line":306,"updated":"2017-05-19 17:05:36.000000000","message":"t \u003d\u003e start_time maybe?","commit_id":"391534468c08f3018fadd34c41ff615bf81bc566"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c24743e2fbb5d38385076355d5194bd74ef750a7","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                        outgoing_packets.append(p)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if renderer is not None:"},{"line_number":448,"context_line":"            p \u003d self._finalize_packet(renderer, request)"},{"line_number":449,"context_line":"            yield p"},{"line_number":450,"context_line":"            if CONF[\u0027service:mdns\u0027].axfr_caching_enabled \u003d\u003d \u0027local\u0027:"},{"line_number":451,"context_line":"                outgoing_packets.append(p)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_5a38dc3b","line":448,"updated":"2017-05-19 17:05:36.000000000","message":"Same here, no reason to hold back on verbosity. :p","commit_id":"391534468c08f3018fadd34c41ff615bf81bc566"}]}