)]}'
{"designate/backend/impl_infoblox/connector.py":[{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"59b66fab6b7c9baae0ff7f16df3512d3848d1ca9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.session.verify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_caa8428f","line":65,"updated":"2016-09-02 03:53:37.000000000","message":"This  will not  work,  as  this  will  always  set\n\nself.session.verify\u003dTrue\n\n\u003e\u003e\u003e x\u003d\u0027True\u0027\n\u003e\u003e\u003e y\u003dbool(x)\n\u003e\u003e\u003e print y\nTrue\n\u003e\u003e\u003e x\u003d\u0027False\u0027\n\u003e\u003e\u003e y\u003dbool(x)\n\u003e\u003e\u003e print y\nTrue","commit_id":"4d8356e14f2d2131a1a29b05488cf839110b5e24"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"2881e65d99fce82733ec7ad371ad56c8b39592ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.session.verify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_ca32025e","line":65,"in_reply_to":"fa7ab95a_caa8428f","updated":"2016-09-02 04:03:37.000000000","message":"Actual problem is integer/string representation of boolean. values are represented as below .\nFrom the pools.yaml the connector object reads sslverify as 0 or 1.\n\u003e\u003e\u003e bool(0)\nFalse\n\u003e\u003e\u003e bool(1)\nTrue\n\u003e\u003e\u003e","commit_id":"4d8356e14f2d2131a1a29b05488cf839110b5e24"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"ac48097738306da5f5fa0b26be9641bd754f7522","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.sslverify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_eae986b8","line":65,"updated":"2016-09-02 04:00:42.000000000","message":"This  will not  work,  as  this  will  always  set\nself.session.verify\u003dTrue\n\u003e\u003e\u003e x\u003d\u0027True\u0027\n\u003e\u003e\u003e y\u003dbool(x)\n\u003e\u003e\u003e print y\nTrue\n\u003e\u003e\u003e x\u003d\u0027False\u0027\n\u003e\u003e\u003e y\u003dbool(x)\n\u003e\u003e\u003e print y\nTrue","commit_id":"51efb88790f7463fbdd673771ee735b56bc9cc32"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"dc6e0ffd69c5f46a29f2e1b9133825408d4dc9f8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.sslverify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_eab8a677","line":65,"in_reply_to":"fa7ab95a_ca9cc210","updated":"2016-09-02 04:17:40.000000000","message":"DO  you mean  use  user should","commit_id":"51efb88790f7463fbdd673771ee735b56bc9cc32"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"b5e4e7243317e05714b31e00098a4b661aba849c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.sslverify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ca3842f1","line":65,"in_reply_to":"fa7ab95a_eab8a677","updated":"2016-09-02 04:18:53.000000000","message":"Do  you mean  user  should  provide  0/1 in  pools.yaml  rather  than  True/False ?","commit_id":"51efb88790f7463fbdd673771ee735b56bc9cc32"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"8eb72a4f9fb9aaf83634558ff28ac620945b3671","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.session.mount(\u0027http://\u0027, adapter)"},{"line_number":63,"context_line":"        self.session.mount(\u0027https://\u0027, adapter)"},{"line_number":64,"context_line":"        self.session.auth \u003d (self.username, self.password)"},{"line_number":65,"context_line":"        self.session.verify \u003d bool(self.sslverify)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _construct_url(self, relative_path, query_params\u003dNone, extattrs\u003dNone):"},{"line_number":68,"context_line":"        if query_params is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ca9cc210","line":65,"in_reply_to":"fa7ab95a_eae986b8","updated":"2016-09-02 04:12:48.000000000","message":"please refer my comments in 2nd patchset.","commit_id":"51efb88790f7463fbdd673771ee735b56bc9cc32"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"0442032f09b2fab96884d517f503c704861b1d8d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        other_opts \u003d [\u0027sslverify\u0027, \u0027network_view\u0027, \u0027dns_view\u0027, \u0027multi_tenant\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        for opt in reqd_opts + other_opts:"},{"line_number":51,"context_line":"            if opt \u003d\u003d other_opts[0]:"},{"line_number":52,"context_line":"                # NOTE(selvakumar): This check is for sslverify option."},{"line_number":53,"context_line":"                # type of sslverify is unicode string from designate DB"},{"line_number":54,"context_line":"                # if the value is 0 getattr called and the default value being"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_d993534e","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":35},"updated":"2016-09-02 23:13:25.000000000","message":"Best to hardcode \u0027sslverify\u0027 here, rather than assume the list above won\u0027t change.","commit_id":"f56ed91c2afaf4d821aac206d244e7a638a62f0a"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"d12a6c33e0742e5a3b8f69ec2e9cc11ec6127fa8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        other_opts \u003d [\u0027sslverify\u0027, \u0027network_view\u0027, \u0027dns_view\u0027, \u0027multi_tenant\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        for opt in reqd_opts + other_opts:"},{"line_number":51,"context_line":"            if opt \u003d\u003d other_opts[0]:"},{"line_number":52,"context_line":"                # NOTE(selvakumar): This check is for sslverify option."},{"line_number":53,"context_line":"                # type of sslverify is unicode string from designate DB"},{"line_number":54,"context_line":"                # if the value is 0 getattr called and the default value being"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_7e2f88a1","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":35},"in_reply_to":"9a89bdaa_d993534e","updated":"2016-09-03 06:08:24.000000000","message":"Done","commit_id":"f56ed91c2afaf4d821aac206d244e7a638a62f0a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"0442032f09b2fab96884d517f503c704861b1d8d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                # type of sslverify is unicode string from designate DB"},{"line_number":54,"context_line":"                # if the value is 0 getattr called and the default value being"},{"line_number":55,"context_line":"                # picked from config.py i.e True always."},{"line_number":56,"context_line":"                setattr(self, opt, bool(int(options.get(opt))))"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            setattr(self, opt, options.get(opt) or getattr(config, opt))"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_d9e193d2","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":62},"updated":"2016-09-02 23:13:25.000000000","message":"We should probably defer this to the bool_from_string() method. e.g.:\n\n    from oslo.utils import strutils\n\n    strutils.bool_from_string(options.get(opt), default\u003dTrue)\n\nthis will also fix the CI failures your hitting","commit_id":"f56ed91c2afaf4d821aac206d244e7a638a62f0a"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"d12a6c33e0742e5a3b8f69ec2e9cc11ec6127fa8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                # type of sslverify is unicode string from designate DB"},{"line_number":54,"context_line":"                # if the value is 0 getattr called and the default value being"},{"line_number":55,"context_line":"                # picked from config.py i.e True always."},{"line_number":56,"context_line":"                setattr(self, opt, bool(int(options.get(opt))))"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            setattr(self, opt, options.get(opt) or getattr(config, opt))"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_be175053","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":62},"in_reply_to":"9a89bdaa_d9e193d2","updated":"2016-09-03 06:08:24.000000000","message":"Done","commit_id":"f56ed91c2afaf4d821aac206d244e7a638a62f0a"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"f1a2fab81d2dfc5438ff6189347b96bb3efa4f39","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                if not strutils.is_int_like(options.get(opt)):"},{"line_number":58,"context_line":"                    option_value \u003d options.get(opt)"},{"line_number":59,"context_line":"                else:"},{"line_number":60,"context_line":"                    option_value \u003d strutils.bool_from_string(options.get(opt),"},{"line_number":61,"context_line":"                                                             default\u003dTrue)"},{"line_number":62,"context_line":"                setattr(self, opt, option_value)"},{"line_number":63,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_12b2ff4b","line":60,"updated":"2016-09-08 18:32:03.000000000","message":"How does this fix bug 1618688 ? You need to be able to pass in one of these three options for sslverify:\n\nTrue\nFalse\n/path/to/cert\n\nThe third option isn\u0027t possible with this code.","commit_id":"102f1d2546e90be7dd5a488a61f6eabaf2f84aaa"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"fa6435a9f2ea98600f3ab3ae8359b475886958c8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                if not strutils.is_int_like(options.get(opt)):"},{"line_number":58,"context_line":"                    option_value \u003d options.get(opt)"},{"line_number":59,"context_line":"                else:"},{"line_number":60,"context_line":"                    option_value \u003d strutils.bool_from_string(options.get(opt),"},{"line_number":61,"context_line":"                                                             default\u003dTrue)"},{"line_number":62,"context_line":"                setattr(self, opt, option_value)"},{"line_number":63,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_72fd0bb0","line":60,"in_reply_to":"9a89bdaa_124e7f3a","updated":"2016-09-08 18:40:04.000000000","message":"Doh. I missed the \"not\" on line 57!","commit_id":"102f1d2546e90be7dd5a488a61f6eabaf2f84aaa"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"e2ec5e9b097eb88904a6a6fac3b0488631c9b3be","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                if not strutils.is_int_like(options.get(opt)):"},{"line_number":58,"context_line":"                    option_value \u003d options.get(opt)"},{"line_number":59,"context_line":"                else:"},{"line_number":60,"context_line":"                    option_value \u003d strutils.bool_from_string(options.get(opt),"},{"line_number":61,"context_line":"                                                             default\u003dTrue)"},{"line_number":62,"context_line":"                setattr(self, opt, option_value)"},{"line_number":63,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_124e7f3a","line":60,"in_reply_to":"9a89bdaa_12b2ff4b","updated":"2016-09-08 18:37:07.000000000","message":"If user specifies sslverify\u003dFalse in pools.yaml then else condition at Line 60 matches. \n\nIf user specifies sslverify\u003d /path/to/cert then Line 58 i.e option_value being set the value for sslverify (self.sslverify\u003d/path/to/cert )\n\nI tested by giving path of certificate to sslverify in pools.yaml and it worked\n\nSo only two options user needs to give either by False and the path/to/certificate.","commit_id":"102f1d2546e90be7dd5a488a61f6eabaf2f84aaa"}]}