)]}'
{"designate/metrics.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8ed03ad9107d2f7d72986bfeada9103eb5c18789","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    import monascastatsd as stats_client"},{"line_number":42,"context_line":"except Exception:"},{"line_number":43,"context_line":"    import designate.metrics_client.noop as stats_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_e8a8c379","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":17},"updated":"2016-11-03 16:52:28.000000000","message":"Nit: This is a tad too generic an exception to catch here, and could hide issues from users.\n\nUsing this instead would clean it up:\n\n    \n    stats_client \u003d oslo_utils.importutils.import_any(\u0027monascastatsd\u0027, \u0027designate.metrics_client.noop\u0027)","commit_id":"417efcc510ef476e550c03ef6d33899bf5b5ca99"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6a39c35033c06d9d02ced02c34d4e8901fb19845","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    import monascastatsd as stats_client"},{"line_number":42,"context_line":"except Exception:"},{"line_number":43,"context_line":"    import designate.metrics_client.noop as stats_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_04401006","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":17},"in_reply_to":"ba5da102_e8a8c379","updated":"2016-11-03 18:58:44.000000000","message":"I did not know that was a thing. I shall follow up with this. Thanks.","commit_id":"417efcc510ef476e550c03ef6d33899bf5b5ca99"}]}
