)]}'
{"designate/storage/impl_sqlalchemy/migrate_repo/versions/070_liberty.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3763f9ba956edece95d0f8de669a1f36b74b693e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"           server_default\u003d\u00270\u0027),"},{"line_number":95,"context_line":"    Column(\u0027deleted_at\u0027, DateTime, nullable\u003dTrue, default\u003dNone),"},{"line_number":96,"context_line":"    Column(\u0027description\u0027, Unicode(160), nullable\u003dTrue),"},{"line_number":97,"context_line":"    Column(\u0027status\u0027, Enum(name\u003d\u0027domains_resource_statuses\u0027,"},{"line_number":98,"context_line":"                          *RESOURCE_STATUSES),"},{"line_number":99,"context_line":"           nullable\u003dFalse, server_default\u003d\u0027PENDING\u0027, default\u003d\u0027PENDING\u0027),"},{"line_number":100,"context_line":"    Column(\u0027action\u0027, Enum(name\u003d\u0027actions\u0027, *ACTIONS),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_e0c88157","line":97,"range":{"start_line":97,"start_character":26,"end_line":97,"end_character":59},"updated":"2016-11-11 11:11:54.000000000","message":"I believe Enum name fields are unused on sqlite and mysql, meaning changing these is historical migrations should be harmless for both. Though I\u0027d like to check :)","commit_id":"469a84ecf6d3a688837bfbbf887b5a1919e4df68"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3763f9ba956edece95d0f8de669a1f36b74b693e","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":374,"context_line":"            conn.execute(\"SET foreign_key_checks \u003d 0;\")"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        pools.create(checkfirst\u003dTrue)"},{"line_number":377,"context_line":"        pool_ns_records.create(checkfirst\u003dTrue)"},{"line_number":378,"context_line":"        pool_attributes.create(checkfirst\u003dTrue)"},{"line_number":379,"context_line":"        domains.create(checkfirst\u003dTrue)"},{"line_number":380,"context_line":"        domain_attributes.create(checkfirst\u003dTrue)"},{"line_number":381,"context_line":"        recordsets.create(checkfirst\u003dTrue)"},{"line_number":382,"context_line":"        records.create(checkfirst\u003dTrue)"},{"line_number":383,"context_line":"        quotas.create(checkfirst\u003dTrue)"},{"line_number":384,"context_line":"        tsigkeys.create(checkfirst\u003dTrue)"},{"line_number":385,"context_line":"        tlds.create(checkfirst\u003dTrue)"},{"line_number":386,"context_line":"        zone_transfer_requests.create(checkfirst\u003dTrue)"},{"line_number":387,"context_line":"        zone_transfer_accepts.create(checkfirst\u003dTrue)"},{"line_number":388,"context_line":"        zone_tasks.create(checkfirst\u003dTrue)"},{"line_number":389,"context_line":"        blacklists.create(checkfirst\u003dTrue)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        pools.insert().execute("},{"line_number":392,"context_line":"            id\u003ddefault_pool_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_e0a16195","line":389,"range":{"start_line":376,"start_character":8,"end_line":389,"end_character":42},"updated":"2016-11-11 11:11:54.000000000","message":"Is checkfirst really necessary? The migrations create and manage the lifecycle of tables from day 1, if it exists, and we\u0027re trying to create it, our migrations either have a much bigger bug or the target DB is out of sync with our expectations?","commit_id":"469a84ecf6d3a688837bfbbf887b5a1919e4df68"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"739b89ce9c9f532ea8f680a54a6cdb1f24ccdb64","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":374,"context_line":"            conn.execute(\"SET foreign_key_checks \u003d 0;\")"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        pools.create(checkfirst\u003dTrue)"},{"line_number":377,"context_line":"        pool_ns_records.create(checkfirst\u003dTrue)"},{"line_number":378,"context_line":"        pool_attributes.create(checkfirst\u003dTrue)"},{"line_number":379,"context_line":"        domains.create(checkfirst\u003dTrue)"},{"line_number":380,"context_line":"        domain_attributes.create(checkfirst\u003dTrue)"},{"line_number":381,"context_line":"        recordsets.create(checkfirst\u003dTrue)"},{"line_number":382,"context_line":"        records.create(checkfirst\u003dTrue)"},{"line_number":383,"context_line":"        quotas.create(checkfirst\u003dTrue)"},{"line_number":384,"context_line":"        tsigkeys.create(checkfirst\u003dTrue)"},{"line_number":385,"context_line":"        tlds.create(checkfirst\u003dTrue)"},{"line_number":386,"context_line":"        zone_transfer_requests.create(checkfirst\u003dTrue)"},{"line_number":387,"context_line":"        zone_transfer_accepts.create(checkfirst\u003dTrue)"},{"line_number":388,"context_line":"        zone_tasks.create(checkfirst\u003dTrue)"},{"line_number":389,"context_line":"        blacklists.create(checkfirst\u003dTrue)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        pools.insert().execute("},{"line_number":392,"context_line":"            id\u003ddefault_pool_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_7738a7d3","line":389,"range":{"start_line":376,"start_character":8,"end_line":389,"end_character":42},"in_reply_to":"9a629dbe_3ff28b06","updated":"2016-11-11 17:17:22.000000000","message":"so it works without the checks.i had to rename the enums","commit_id":"469a84ecf6d3a688837bfbbf887b5a1919e4df68"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1c46899596c9ab335064bbe226da56f9b7f0ffe8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":374,"context_line":"            conn.execute(\"SET foreign_key_checks \u003d 0;\")"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        pools.create(checkfirst\u003dTrue)"},{"line_number":377,"context_line":"        pool_ns_records.create(checkfirst\u003dTrue)"},{"line_number":378,"context_line":"        pool_attributes.create(checkfirst\u003dTrue)"},{"line_number":379,"context_line":"        domains.create(checkfirst\u003dTrue)"},{"line_number":380,"context_line":"        domain_attributes.create(checkfirst\u003dTrue)"},{"line_number":381,"context_line":"        recordsets.create(checkfirst\u003dTrue)"},{"line_number":382,"context_line":"        records.create(checkfirst\u003dTrue)"},{"line_number":383,"context_line":"        quotas.create(checkfirst\u003dTrue)"},{"line_number":384,"context_line":"        tsigkeys.create(checkfirst\u003dTrue)"},{"line_number":385,"context_line":"        tlds.create(checkfirst\u003dTrue)"},{"line_number":386,"context_line":"        zone_transfer_requests.create(checkfirst\u003dTrue)"},{"line_number":387,"context_line":"        zone_transfer_accepts.create(checkfirst\u003dTrue)"},{"line_number":388,"context_line":"        zone_tasks.create(checkfirst\u003dTrue)"},{"line_number":389,"context_line":"        blacklists.create(checkfirst\u003dTrue)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        pools.insert().execute("},{"line_number":392,"context_line":"            id\u003ddefault_pool_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_3ff28b06","line":389,"range":{"start_line":376,"start_character":8,"end_line":389,"end_character":42},"in_reply_to":"9a629dbe_e0a16195","updated":"2016-11-11 15:26:19.000000000","message":"hm. not sure if theses are needed. it does not hurt but i can remove them and try gating again.","commit_id":"469a84ecf6d3a688837bfbbf887b5a1919e4df68"}]}