)]}'
{"designate/tests/unit/test_mdns/test_notify.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"e8be91f432e67150a69189863024d0661e364228","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    @mock.patch.object(notify.dns_query, \u0027tcp\u0027)"},{"line_number":267,"context_line":"    @mock.patch.object(notify.dns_query, \u0027udp\u0027)"},{"line_number":268,"context_line":"    def test_send_dns_message(self, *mocks):"},{"line_number":269,"context_line":"        out \u003d self.notify._send_dns_message(\u0027msg\u0027, \u0027127.0.0.1\u0027, 123, 1)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        assert not notify.dns_query.tcp.called"},{"line_number":272,"context_line":"        notify.dns_query.udp.assert_called_with(\u0027msg\u0027, \u0027127.0.0.1\u0027, port\u003d123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_a12484b2","line":269,"range":{"start_line":269,"start_character":64,"end_line":269,"end_character":67},"updated":"2017-02-01 15:19:17.000000000","message":"I know 123 was picked to avoid sending data to an actual DNS server.. But this is the NTP port, also a UDP service. Now that theres a valid address, this has some risk of causing issues?","commit_id":"4f8e71f4dc265d2ab103515da9f7f169918d4d94"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a5177da72e9fd39ee4823d80c65e3932f3b3d7a5","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    @mock.patch.object(notify.dns_query, \u0027tcp\u0027)"},{"line_number":267,"context_line":"    @mock.patch.object(notify.dns_query, \u0027udp\u0027)"},{"line_number":268,"context_line":"    def test_send_dns_message(self, *mocks):"},{"line_number":269,"context_line":"        out \u003d self.notify._send_dns_message(\u0027msg\u0027, \u0027127.0.0.1\u0027, 123, 1)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        assert not notify.dns_query.tcp.called"},{"line_number":272,"context_line":"        notify.dns_query.udp.assert_called_with(\u0027msg\u0027, \u0027127.0.0.1\u0027, port\u003d123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_818ce880","line":269,"updated":"2017-02-01 15:22:20.000000000","message":"Yes, it could. 1234 is a search agent (that should not be running), or a command and conquer game port so we should be OK with that","commit_id":"4f8e71f4dc265d2ab103515da9f7f169918d4d94"}]}
