)]}'
{"designate/scheduler/filters/in_doubt_default_pool_filter.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"f65e0599436ca7e509430e2d7a0e8194aeaf8bc3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\"If the previous filter(s) didn\u0027t make a clear selection of one pool,"},{"line_number":29,"context_line":"    this filter will choose the default pool."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    If there are no pools available to schedule to, this filter will insert"},{"line_number":32,"context_line":"    the default_pool_id, similar to the fallback filter."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    If there are multiple pools available to schedule to, this filter will"},{"line_number":35,"context_line":"    choose the default pool, regardless whether the default pool is within the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f6e6deb2","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":56},"updated":"2017-02-13 16:18:45.000000000","message":"I am not sure about this mode of operation.\n\nI think *if the default pool is in the set of multiple pools* it should be selected, or the list is passed through.","commit_id":"5a782ce135b3a99fa7745b7917e8ddc93c19f72b"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"876d49de895c87e8c05db7ac730761044c58b2c0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    this filter will choose the default pool."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    If there are no pools available to schedule to, this filter will insert"},{"line_number":32,"context_line":"    the default_pool_id, similar to the fallback filter."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    If there are multiple pools available to schedule to, this filter will"},{"line_number":35,"context_line":"    choose the default pool, regardless whether the default pool is within the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_cba2e1ad","line":32,"updated":"2017-02-14 14:55:07.000000000","message":"Yeah, I think chaining with the fallback + random filter would be the best solution","commit_id":"5a782ce135b3a99fa7745b7917e8ddc93c19f72b"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"58b9af6d5815b38d625b21785527f368b7aa3b5e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\"If the previous filter(s) didn\u0027t make a clear selection of one pool,"},{"line_number":29,"context_line":"    this filter will choose the default pool."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    If there are no pools available to schedule to, this filter will insert"},{"line_number":32,"context_line":"    the default_pool_id, similar to the fallback filter."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    If there are multiple pools available to schedule to, this filter will"},{"line_number":35,"context_line":"    choose the default pool, regardless whether the default pool is within the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_ab330361","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":56},"in_reply_to":"fa31d9ce_f6e6deb2","updated":"2017-02-14 06:19:53.000000000","message":"I see, I would reach my goal if the only action of this filter is: *if the default pool is in the set of multiple pools, select it*.\n\nAn empty set of pools can be handled by chaining with the fallback filter.\n\nAnd the other possibility: having multiple pools in the set and choosing a totally different one - could lead to much confusion and is not really intended. Passing trough is better in this case.","commit_id":"5a782ce135b3a99fa7745b7917e8ddc93c19f72b"}]}
