)]}'
{"designate/tests/unit/test_central/test_basic.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"65c3dc4b0a885fb60a8c6c8a8f1b05cdd3a067d4","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                criterion\u003d\u0027bogus\u0027"},{"line_number":1072,"context_line":"            )"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _test_touch_zone(self, worker_enabled\u003dTrue):"},{"line_number":1075,"context_line":"        if not worker_enabled:"},{"line_number":1076,"context_line":"            self.config("},{"line_number":1077,"context_line":"                enabled\u003d\"False\","}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_76e56ddb","line":1074,"updated":"2017-06-06 04:07:19.000000000","message":"All of these special cases are a code smell. Is there any way we can get around having to do this?\n\nWhat is the story behind these?\n\nMy initial thought for some of these is that mocking zone_api would be sufficient, but perhaps not.","commit_id":"d0065f130ac2a82b303ff6f7074a3f4098834e7f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"7f966cdde4213301ed847293f4e692d8fcd036ce","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                criterion\u003d\u0027bogus\u0027"},{"line_number":1072,"context_line":"            )"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _test_touch_zone(self, worker_enabled\u003dTrue):"},{"line_number":1075,"context_line":"        if not worker_enabled:"},{"line_number":1076,"context_line":"            self.config("},{"line_number":1077,"context_line":"                enabled\u003d\"False\","}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_8f1900d8","line":1074,"in_reply_to":"df140735_76e56ddb","updated":"2017-06-06 08:06:03.000000000","message":"The current UT only test with pool_manager model, not for worker model. I just added some more UT into the old cases for covering worker model.\n\nMocking zone_api does not ensure the code coverage in this case. If we enabled worker model, zone_api will be worker_api, else pool_manager_api.\n\nAnother way to get around this code smell is mocking both pool_manager_api and worker_api, but I do not prefer this way.\n\nHow do you think Tim?","commit_id":"d0065f130ac2a82b303ff6f7074a3f4098834e7f"}],"designate/worker/__init__.py":[{"author":{"_account_id":26734,"name":"Scott McClymont","email":"scott.mcclymont@verizonwireless.com","username":"smcclymont"},"change_message_id":"81cacd7b17889f6390032c24027e77941de97ea1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"OPTS \u003d ["},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dTrue,"},{"line_number":26,"context_line":"                help\u003d\u0027Whether to send events to worker instead of \u0027"},{"line_number":27,"context_line":"                     \u0027Pool Manager\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"                deprecated_reason\u003d\u0027In Queens, this option will disappear\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_910cadec","line":26,"updated":"2017-10-25 11:59:49.000000000","message":"May want to reword this to be a bit clearer. Maybe something like \u0027Enable to send events to worker ... \u0027 etc.","commit_id":"967726a1c148a302b7a161c602e798037d06c6a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4237a42663395b1b7d402e82853f8fe96ada2694","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dTrue,"},{"line_number":26,"context_line":"                help\u003d\u0027Whether to send events to worker instead of \u0027"},{"line_number":27,"context_line":"                     \u0027Pool Manager\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"                deprecated_reason\u003d\u0027In Queens, this option will disappear\u0027"},{"line_number":30,"context_line":"                                  \u0027because pool manager will be removed\u0027),"},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027workers\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027Number of Worker worker processes to spawn\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027threads\u0027, default\u003d200,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_610ed0e6","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":74},"updated":"2019-03-06 09:44:37.000000000","message":"We could target Train now at best I guess.\n\nAlso, are we still planning to remove pool manager completely? Or will we need to continue supporting it for older/specific setups? In that case, we should drop the deprecation completely and just stop at the worker being the default.","commit_id":"98a7567282fa71d6479c81ae487c9e06e2f38303"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4a240507320f983dac2415d054c06cebdacca2a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                     \u0027Pool Manager\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"                deprecated_reason\u003d\u0027In Queens, this option will disappear\u0027"},{"line_number":30,"context_line":"                                  \u0027because pool manager will be removed\u0027),"},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027workers\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027Number of Worker worker processes to spawn\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027threads\u0027, default\u003d200,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_6a5ea5e7","line":30,"updated":"2019-03-06 12:36:03.000000000","message":"Yup - missed that","commit_id":"98a7567282fa71d6479c81ae487c9e06e2f38303"}],"devstack/plugin.sh":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4a240507320f983dac2415d054c06cebdacca2a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"# Install and start **Designate** service in Devstack"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"}],"source_content_type":"text/x-sh","patch_set":12,"id":"5fc1f717_0a736182","line":1,"updated":"2019-03-06 12:36:03.000000000","message":"Eh... maybe a rebase conflict error. removing","commit_id":"98a7567282fa71d6479c81ae487c9e06e2f38303"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4237a42663395b1b7d402e82853f8fe96ada2694","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"# Install and start **Designate** service in Devstack"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"}],"source_content_type":"text/x-sh","patch_set":12,"id":"5fc1f717_214a0827","line":1,"updated":"2019-03-06 09:44:37.000000000","message":"I think that this is meant to be sourced from main devstack code, not executed independently, so what is the intention here?","commit_id":"98a7567282fa71d6479c81ae487c9e06e2f38303"}],"releasenotes/notes/pool-manager-disabled-ff8582b5f86d2360.yaml":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c11d6a46bcda8f8e63052bfd1ba6d14351e05ee8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - New installs will now have pool manager disabled by"},{"line_number":4,"context_line":"    default and will use the worker and producer services."},{"line_number":5,"context_line":"    To continue to use pool manager set ``enabled\u003dFalse``"},{"line_number":6,"context_line":"    in the ``[service:worker]`` of your config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f287b81_5472fd12","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":46},"updated":"2017-08-25 08:46:07.000000000","message":"missing period \".\"","commit_id":"2eb109278f4f5f508790fc5fc905a4aaefebc586"},{"author":{"_account_id":26734,"name":"Scott McClymont","email":"scott.mcclymont@verizonwireless.com","username":"smcclymont"},"change_message_id":"81cacd7b17889f6390032c24027e77941de97ea1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - New installs will now have pool manager disabled by"},{"line_number":4,"context_line":"    default and will use the worker and producer services."},{"line_number":5,"context_line":"    To continue to use pool manager set ``enabled\u003dFalse``"},{"line_number":6,"context_line":"    in the ``[service:worker]`` of your config"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4b6375_d1d46522","line":6,"updated":"2017-10-25 11:59:49.000000000","message":"Minor detail but missing the \u0027.\u0027 on this line.","commit_id":"967726a1c148a302b7a161c602e798037d06c6a4"}]}