)]}'
{"designate/scheduler/filters/in_doubt_default_pool_filter.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e72facf4a040ad9250b22076929565007f345d91","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            except Exception:"},{"line_number":53,"context_line":"                return pools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if default_pool in pools:"},{"line_number":56,"context_line":"                pools \u003d objects.PoolList()"},{"line_number":57,"context_line":"                pools.append(default_pool)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2e6fb393","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":27},"updated":"2017-02-28 14:07:00.000000000","message":"I should have caught this in the last iteration - I am not 100% sure if this will match.\n\nWe have our own objects, which for the comparison do a \"to_dict()\" on both and see if they match.\n\nWe may need to iterate and check for the ID\nsomething like\n\n  for pool in pools:\n    if pool.id \u003d\u003d default_pool_id:\n      return PoolList().append(pool)\n\n  return pools","commit_id":"198b29724e0133dcccabd5b116ec36bfde0a2c43"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"923b6811417e6911e0fdbea6e74d36918260bf7c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            except Exception:"},{"line_number":53,"context_line":"                return pools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if default_pool in pools:"},{"line_number":56,"context_line":"                pools \u003d objects.PoolList()"},{"line_number":57,"context_line":"                pools.append(default_pool)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_efc912ae","line":55,"updated":"2017-02-28 15:50:48.000000000","message":"OK, cool, if it works ++","commit_id":"198b29724e0133dcccabd5b116ec36bfde0a2c43"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7d835b294e2713429585528dd4cd876810eac609","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            except Exception:"},{"line_number":53,"context_line":"                return pools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if default_pool in pools:"},{"line_number":56,"context_line":"                pools \u003d objects.PoolList()"},{"line_number":57,"context_line":"                pools.append(default_pool)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_91a0bea7","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":27},"in_reply_to":"ba2be162_2e6fb393","updated":"2017-02-28 14:33:55.000000000","message":"Well after I noticed my error, I went to breakpoint debugging and can confirm that this now works.","commit_id":"198b29724e0133dcccabd5b116ec36bfde0a2c43"}]}