)]}'
{"designate/api/v2/views/zones.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"850d1ab5906a68d9be1e24b00f3582282708a977","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                \"project_id\": zone[\u0027tenant_id\u0027],"},{"line_number":37,"context_line":"                \"name\": zone[\u0027name\u0027],"},{"line_number":38,"context_line":"                \"email\": zone[\u0027email\u0027],"},{"line_number":39,"context_line":"                \"description\": zone[\u0027description\u0027],"},{"line_number":40,"context_line":"                \"ttl\": zone[\u0027ttl\u0027],"},{"line_number":41,"context_line":"                \"serial\": zone[\u0027serial\u0027],"},{"line_number":42,"context_line":"                \"status\": zone[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F8NI%3D","line":39,"updated":"2013-09-16 20:55:13.000000000","message":"This is not in your change.  But wanted to check on this.  Is description the same as the notes field referred to in the v2 spec?","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"06696c51729302ea4becf504e8aa436b33b71c33","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                \"project_id\": zone[\u0027tenant_id\u0027],"},{"line_number":37,"context_line":"                \"name\": zone[\u0027name\u0027],"},{"line_number":38,"context_line":"                \"email\": zone[\u0027email\u0027],"},{"line_number":39,"context_line":"                \"description\": zone[\u0027description\u0027],"},{"line_number":40,"context_line":"                \"ttl\": zone[\u0027ttl\u0027],"},{"line_number":41,"context_line":"                \"serial\": zone[\u0027serial\u0027],"},{"line_number":42,"context_line":"                \"status\": zone[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F6UE%3D","line":39,"in_reply_to":"AAAAS3%2F%2F8NI%3D","updated":"2013-09-17 10:14:16.000000000","message":"Yes, the spec is outdated! All the other OS projects use \"description\" rather than \"notes\"","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"}],"designate/central/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"850d1ab5906a68d9be1e24b00f3582282708a977","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            raise exceptions.DomainHasSubdomain(\u0027Please delete any subdomains \u0027"},{"line_number":533,"context_line":"                                                \u0027before deleting this domain\u0027)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        with self.storage_api.delete_domain(context, domain_id) as domain:"},{"line_number":536,"context_line":"            with wrap_backend_call():"},{"line_number":537,"context_line":"                self.backend.delete_domain(context, domain)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F8Mg%3D","line":535,"updated":"2013-09-16 20:55:13.000000000","message":"Just to make things clearer, could this be renamed?  Otherwise this domain masks the domain on line 518.","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"06696c51729302ea4becf504e8aa436b33b71c33","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            raise exceptions.DomainHasSubdomain(\u0027Please delete any subdomains \u0027"},{"line_number":533,"context_line":"                                                \u0027before deleting this domain\u0027)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        with self.storage_api.delete_domain(context, domain_id) as domain:"},{"line_number":536,"context_line":"            with wrap_backend_call():"},{"line_number":537,"context_line":"                self.backend.delete_domain(context, domain)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F6Tg%3D","line":535,"in_reply_to":"AAAAS3%2F%2F8Mg%3D","updated":"2013-09-17 10:14:16.000000000","message":"These actually are the \"same domain\", the second is an updated version of the first post-deletion (where the second might be \"status \u003d DELETING\").","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"dd7404f550fc54cba0567999a1b86aa0d6496317","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        utils.notify(context, \u0027central\u0027, \u0027domain.delete\u0027, domain)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        return domain"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def count_domains(self, context, criterion\u003dNone):"},{"line_number":544,"context_line":"        if criterion is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FbRQ%3D","line":541,"updated":"2013-09-26 21:42:39.000000000","message":"The equivalent two changes should be made to delete_record","commit_id":"e08845b98035f20e3f320769eb00de22440e0bd8"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"850d1ab5906a68d9be1e24b00f3582282708a977","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        domain.soft_delete(self.session)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return dict(domain)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def count_domains(self, context, criterion\u003dNone):"},{"line_number":340,"context_line":"        query \u003d self.session.query(models.Domain)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F8Lc%3D","line":337,"updated":"2013-09-16 20:55:13.000000000","message":"Why do we return the domain as a dictionary but a record is returned as is below (on line 408)?","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"06696c51729302ea4becf504e8aa436b33b71c33","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        domain.soft_delete(self.session)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return dict(domain)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def count_domains(self, context, criterion\u003dNone):"},{"line_number":340,"context_line":"        query \u003d self.session.query(models.Domain)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F6TY%3D","line":337,"in_reply_to":"AAAAS3%2F%2F8Lc%3D","updated":"2013-09-17 10:14:16.000000000","message":"Looks like a bug! Both should be dict\u0027s","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"06696c51729302ea4becf504e8aa436b33b71c33","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        record.delete(self.session)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return record"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def count_records(self, context, criterion\u003dNone):"},{"line_number":411,"context_line":"        query \u003d self.session.query(models.Record)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F6TM%3D","line":408,"updated":"2013-09-17 10:14:16.000000000","message":"This should be returned as `dict(record)`","commit_id":"169d793115db89ecf54f0932f344a0d0e4688ae0"}]}