)]}'
{"designate/api/v2/controllers/recordsets.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def get_one(self, zone_id, recordset_id):"},{"line_number":36,"context_line":"        \"\"\" Get RecordSet \"\"\""},{"line_number":37,"context_line":"        request \u003d pecan.request"},{"line_number":38,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # TODO(kiall): Validate we have a sane UUID for zone_id and"},{"line_number":41,"context_line":"        #              recordset_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7%2FQ%3D","line":38,"updated":"2013-09-16 22:18:06.000000000","message":"Don\u0027t you need to set the response status in get_one, get_all and patch_one?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def get_one(self, zone_id, recordset_id):"},{"line_number":36,"context_line":"        \"\"\" Get RecordSet \"\"\""},{"line_number":37,"context_line":"        request \u003d pecan.request"},{"line_number":38,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # TODO(kiall): Validate we have a sane UUID for zone_id and"},{"line_number":41,"context_line":"        #              recordset_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F6dY%3D","line":38,"in_reply_to":"AAAAS3%2F%2F7%2FQ%3D","updated":"2013-09-17 09:48:28.000000000","message":"In patch_one, once the async stuff happens, yes.\n\nIn the various get_* methods, no, as the default code of 200 is what we want.","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Fetch the existing recordset"},{"line_number":109,"context_line":"        recordset \u003d central_api.get_recordset(context, zone_id, recordset_id)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        LOG.warn(\u0027Existing RRSet: %r\u0027, recordset)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Convert to APIv2 Format"},{"line_number":114,"context_line":"        recordset \u003d self._view.detail(context, request, recordset)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7%2FE%3D","line":111,"updated":"2013-09-16 22:18:06.000000000","message":"Do we always log this warning and the warning below on line 116?  Do these need to be warnings?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Fetch the existing recordset"},{"line_number":109,"context_line":"        recordset \u003d central_api.get_recordset(context, zone_id, recordset_id)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        LOG.warn(\u0027Existing RRSet: %r\u0027, recordset)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Convert to APIv2 Format"},{"line_number":114,"context_line":"        recordset \u003d self._view.detail(context, request, recordset)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F6c8%3D","line":111,"in_reply_to":"AAAAS3%2F%2F7%2FE%3D","updated":"2013-09-17 09:48:28.000000000","message":"Debugging leftovers :) Most of those will go to LOG.debug() before we merge","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"}],"designate/backend/base.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @abc.abstractmethod"},{"line_number":64,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":65,"context_line":"        \"\"\" Create a DNS recordset \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @abc.abstractmethod"},{"line_number":68,"context_line":"    def update_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7%2Bw%3D","line":65,"updated":"2013-09-16 22:18:06.000000000","message":"Would the backend be the same for v1 and v2?  Would it be recordsets for v1 too?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @abc.abstractmethod"},{"line_number":64,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":65,"context_line":"        \"\"\" Create a DNS recordset \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @abc.abstractmethod"},{"line_number":68,"context_line":"    def update_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F6cs%3D","line":65,"in_reply_to":"AAAAS3%2F%2F7%2Bw%3D","updated":"2013-09-17 09:48:28.000000000","message":"Yes, The V1 API will use central\u0027s recordset methods.. The adaption will happen in the v1 records API, hopefully I\u0027ll get the V1 API fixed up today.","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"}],"designate/central/rpcapi.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return self.call(context, msg)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # RecordSet Methods"},{"line_number":217,"context_line":"    def create_recordset(self, context, domain_id, values,"},{"line_number":218,"context_line":"                         increment_serial\u003dTrue):"},{"line_number":219,"context_line":"        LOG.info(\"create_recordset: Calling central\u0027s create_recordset.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F79E%3D","line":216,"updated":"2013-09-16 22:18:06.000000000","message":"I have the same question that I had earlier - would these methods work for both v1 and v2 - would v1 also deal with recordsets now at all levels other than api?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return self.call(context, msg)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # RecordSet Methods"},{"line_number":217,"context_line":"    def create_recordset(self, context, domain_id, values,"},{"line_number":218,"context_line":"                         increment_serial\u003dTrue):"},{"line_number":219,"context_line":"        LOG.info(\"create_recordset: Calling central\u0027s create_recordset.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F6co%3D","line":216,"in_reply_to":"AAAAS3%2F%2F79E%3D","updated":"2013-09-17 09:48:28.000000000","message":"Yea - We\u0027ll adapt records-\u003erecordsets in the V1 API, and that will call these methods.","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"}],"designate/central/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # Record must be contained in the parent zone"},{"line_number":134,"context_line":"        if not record_name.endswith(domain[\u0027name\u0027]):"},{"line_number":135,"context_line":"            raise exceptions.InvalidRecordSetLocation("},{"line_number":136,"context_line":"                \u0027Record is not contained within it\\\u0027s parent domain\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # CNAME\u0027s must not be created at the zone apex."},{"line_number":139,"context_line":"        if record_type \u003d\u003d \u0027CNAME\u0027 and record_name \u003d\u003d domain[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F78o%3D","line":136,"updated":"2013-09-16 22:18:06.000000000","message":"Something I learned from you in another context that might be applicable here :-)\nThe backslash can be avoided with double quotes.\n\nAlso should the message be referring to a recordset or a record?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # Record must be contained in the parent zone"},{"line_number":134,"context_line":"        if not record_name.endswith(domain[\u0027name\u0027]):"},{"line_number":135,"context_line":"            raise exceptions.InvalidRecordSetLocation("},{"line_number":136,"context_line":"                \u0027Record is not contained within it\\\u0027s parent domain\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # CNAME\u0027s must not be created at the zone apex."},{"line_number":139,"context_line":"        if record_type \u003d\u003d \u0027CNAME\u0027 and record_name \u003d\u003d domain[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F6cE%3D","line":136,"in_reply_to":"AAAAS3%2F%2F78o%3D","updated":"2013-09-17 09:48:28.000000000","message":"Yep - This was done with a simple find/replace, fix anything flake8 moans about..\n\nBut, yea, I missed the Record-\u003eRecordSet piece.","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"}],"designate/resources/schemas/v2/recordset.json":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"6b2dc1448cadfb4828cec7f7dcffb3ea5065e1f7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                \"status\": {"},{"line_number":67,"context_line":"                    \"type\": \"string\","},{"line_number":68,"context_line":"                    \"description\": \"Zone Status\","},{"line_number":69,"context_line":"                    \"enum\": [\"ACTIVE\", \"PENDING\", \"DELETING\", \"ERROR\"],"},{"line_number":70,"context_line":"                    \"readOnly\": true"},{"line_number":71,"context_line":"                },"},{"line_number":72,"context_line":"                \"version\": {"}],"source_content_type":"application/json","patch_set":10,"id":"AAAAS3%2F%2F77U%3D","line":69,"updated":"2013-09-16 22:18:06.000000000","message":"Mugsie has more status values in his change - https://review.openstack.org/#/c/44730/2/designate/storage/impl_sqlalchemy/migrate_repo/versions/021_add_domain_status.py.\n\nWould this be updated later once his change is merged?","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cf1e8cfbd52d53e4d6340338ffd8b3bc84a5766d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                \"status\": {"},{"line_number":67,"context_line":"                    \"type\": \"string\","},{"line_number":68,"context_line":"                    \"description\": \"Zone Status\","},{"line_number":69,"context_line":"                    \"enum\": [\"ACTIVE\", \"PENDING\", \"DELETING\", \"ERROR\"],"},{"line_number":70,"context_line":"                    \"readOnly\": true"},{"line_number":71,"context_line":"                },"},{"line_number":72,"context_line":"                \"version\": {"}],"source_content_type":"application/json","patch_set":10,"id":"AAAAS3%2F%2F6bU%3D","line":69,"in_reply_to":"AAAAS3%2F%2F77U%3D","updated":"2013-09-17 09:48:28.000000000","message":"Yea - i very quickly added this so I could get the RecordSet API working - These have no meaning yet, and the list is incomplete.","commit_id":"0963bb0c81e4c5068ae033b30dfce45daf64fef6"}]}