)]}'
{"designate/backend/impl_powerdns/migrate_repo/versions/006_add_inherit_ttl_col.py":[{"author":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"change_message_id":"ded0a966530ccf32b47162daed02b3769056fdf5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    # a manual post-migration step."},{"line_number":41,"context_line":"    query \u003d records_table.select()"},{"line_number":42,"context_line":"    query \u003d query.where(records_table.c.ttl \u003d\u003d None)  # noqa"},{"line_number":43,"context_line":"    c \u003d query.count()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    if c \u003e 0:"},{"line_number":46,"context_line":"        pmq \u003d (\u0027UPDATE powerdns.records JOIN powerdns.domains ON powerdns.reco\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FAc0%3D","line":43,"updated":"2013-09-13 16:34:28.000000000","message":"should there not be a query.execute() before finding the count?","commit_id":"5fa08d9cc66fcd3a18d95c5e05c468be05ff5eea"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"77fbce7fa96a5e547d6f720ccf8b02ee508a4035","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    # a manual post-migration step."},{"line_number":41,"context_line":"    query \u003d records_table.select()"},{"line_number":42,"context_line":"    query \u003d query.where(records_table.c.ttl \u003d\u003d None)  # noqa"},{"line_number":43,"context_line":"    c \u003d query.count()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    if c \u003e 0:"},{"line_number":46,"context_line":"        pmq \u003d (\u0027UPDATE powerdns.records JOIN powerdns.domains ON powerdns.reco\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FAZ8%3D","line":43,"in_reply_to":"AAAASn%2F%2FAc0%3D","updated":"2013-09-13 16:43:03.000000000","message":"In this case, no.. We don\u0027t want to select all the records into python, and then count, we want to issue a `SELECT COUNT(*) ...` instead.","commit_id":"5fa08d9cc66fcd3a18d95c5e05c468be05ff5eea"}]}