)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Van Hung Pham \u003chungpv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-30 01:08:12 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove translation of log messages"},{"line_number":8,"context_line":"The i18n team has decided not to translate the logs because it seems unlikely  very useful;"},{"line_number":9,"context_line":"operators prefer to have them in English so that they can search for those strings on the internet."},{"line_number":10,"context_line":"Partially fix on designate/designate other paths will be fixed on next commits."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_adcb871c","line":7,"updated":"2017-05-29 09:27:18.000000000","message":"Add a blank line right after the 1st line (title)","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"0bdb14e1275551038b3db6efe19a1ae2251eed2a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove translation of log messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The i18n team has decided not to translate the logs because it seems unlikely  very useful;"},{"line_number":10,"context_line":"operators prefer to have them in English so that they can search for those strings on the internet."},{"line_number":11,"context_line":"Partially fix on designate/designate other paths will be fixed on next commits."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id77a31204e626b29b42a4f23046f6f5b51d9457b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_b0d76024","line":10,"range":{"start_line":10,"start_character":78,"end_line":10,"end_character":99},"updated":"2017-05-29 09:39:46.000000000","message":"long line","commit_id":"85de8b6bebcdfc724332697929fa981d07708f14"}],"designate/coordination.py":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import tooz.coordination"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from designate.utils import generate_uuid"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_cdefdb85","line":28,"updated":"2017-05-29 09:27:18.000000000","message":"It should have 2 blank lines","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            msg \u003d (\"No coordination backend configured, distributed \""},{"line_number":78,"context_line":"                   \"coordination functionality will be disabled. \""},{"line_number":79,"context_line":"                   \"Please configure a coordination backend.\")"},{"line_number":80,"context_line":"            LOG.warning(msg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        super(CoordinationMixin, self).start()"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6da32f51","line":80,"updated":"2017-05-29 09:27:18.000000000","message":"msg is not neccessary\nLOG.warning(\"No coordination ....\")","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            self._coordinator.heartbeat()"},{"line_number":126,"context_line":"        except tooz.coordination.ToozError:"},{"line_number":127,"context_line":"            LOG.exception(\u0027Error sending a heartbeat to coordination \u0027"},{"line_number":128,"context_line":"                          \u0027backend.\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _coordinator_run_watchers(self):"},{"line_number":131,"context_line":"        if not self._coordination_started:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_fb76d93e","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":37},"updated":"2017-05-29 10:19:48.000000000","message":"just make it oneliner","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                self._coordinator.stand_down_group_leader(self._group_id)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        elif self._leader:"},{"line_number":288,"context_line":"            LOG.info(\u0027Standing down as leader candidate for group \u0027"},{"line_number":289,"context_line":"                     \u0027%(group)s\u0027, {\u0027group\u0027: self._group_id})"},{"line_number":290,"context_line":"            self._leader \u003d False"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bbb741d9","line":289,"range":{"start_line":288,"start_character":0,"end_line":289,"end_character":60},"updated":"2017-05-29 10:19:48.000000000","message":"group message into one line","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"}],"designate/dnsutils.py":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        except dns.message.UnknownTSIGKey:"},{"line_number":105,"context_line":"            LOG.error(\"Unknown TSIG key from %(host)s:\""},{"line_number":106,"context_line":"                      \"%(port)d\" % {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":107,"context_line":"                                    \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            response \u003d self._build_error_response()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6d4a0f81","line":106,"updated":"2017-05-29 09:27:18.000000000","message":"Should use this form:\nLOG.info(_LI(\u0027some message: variable\u003d%s\u0027), variable)\n\nSee: https://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        except dns.tsig.BadSignature:"},{"line_number":112,"context_line":"            LOG.error(\"Invalid TSIG signature from %(host)s:\""},{"line_number":113,"context_line":"                      \"%(port)d\" % {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":114,"context_line":"                                    \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"            response \u003d self._build_error_response()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_cd30fb0a","line":113,"updated":"2017-05-29 09:27:18.000000000","message":"ditto","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        except dns.exception.DNSException:"},{"line_number":119,"context_line":"            LOG.error(\"Failed to deserialize packet from %(host)s:\""},{"line_number":120,"context_line":"                      \"%(port)d\" % {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":121,"context_line":"                                    \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            response \u003d self._build_error_response()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_ad35c7f9","line":120,"updated":"2017-05-29 09:27:18.000000000","message":"ditto","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        except dns.message.UnknownTSIGKey:"},{"line_number":105,"context_line":"            LOG.error(\"Unknown TSIG key from %(host)s:\""},{"line_number":106,"context_line":"                      \"%(port)d\", {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":107,"context_line":"                                   \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_7bb1a9e1","line":105,"updated":"2017-05-29 10:19:48.000000000","message":"make it oneline","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            response \u003d self._build_error_response()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        except dns.tsig.BadSignature:"},{"line_number":112,"context_line":"            LOG.error(\"Invalid TSIG signature from %(host)s:\""},{"line_number":113,"context_line":"                      \"%(port)d\", {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":114,"context_line":"                                   \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_5bb6e5db","line":112,"updated":"2017-05-29 10:19:48.000000000","message":"ditto","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            response \u003d self._build_error_response()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        except dns.exception.DNSException:"},{"line_number":119,"context_line":"            LOG.error(\"Failed to deserialize packet from %(host)s:\""},{"line_number":120,"context_line":"                      \"%(port)d\", {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":121,"context_line":"                                   \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_fbc49942","line":119,"updated":"2017-05-29 10:19:48.000000000","message":"ditto","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    yield response.get_wire()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"                else:"},{"line_number":144,"context_line":"                    LOG.error(\"Unexpected response %(resp)s\" %"},{"line_number":145,"context_line":"                              repr(response))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bbdce118","line":144,"updated":"2017-05-29 10:19:48.000000000","message":"just one line","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            break"},{"line_number":349,"context_line":"        except eventlet.Timeout as t:"},{"line_number":350,"context_line":"            if t \u003d\u003d to:"},{"line_number":351,"context_line":"                msg \u003d \"AXFR timed out for %(name)s from %(host)s\""},{"line_number":352,"context_line":"                LOG.error(msg % log_info)"},{"line_number":353,"context_line":"                continue"},{"line_number":354,"context_line":"        except dns.exception.FormError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_7be649eb","line":351,"range":{"start_line":351,"start_character":16,"end_line":351,"end_character":19},"updated":"2017-05-29 10:19:48.000000000","message":"remove this variable","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            to.cancel()"},{"line_number":368,"context_line":"        continue"},{"line_number":369,"context_line":"    else:"},{"line_number":370,"context_line":"        msg \u003d (\"XFR failed for %(name)s. No servers in %(servers)s was \""},{"line_number":371,"context_line":"               \"reached.\")"},{"line_number":372,"context_line":"        raise exceptions.XFRFailure("},{"line_number":373,"context_line":"            msg % {\"name\": zone_name, \"servers\": servers})"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_1bf62d91","line":371,"range":{"start_line":370,"start_character":0,"end_line":371,"end_character":26},"updated":"2017-05-29 10:19:48.000000000","message":"just one line","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        except Exception:"},{"line_number":126,"context_line":"            LOG.exception(\"Unknown exception deserializing packet \""},{"line_number":127,"context_line":"                          \"from %(host)s %(port)d\" %"},{"line_number":128,"context_line":"                          {\u0027host\u0027: request[\u0027addr\u0027][0],"},{"line_number":129,"context_line":"                           \u0027port\u0027: request[\u0027addr\u0027][1]})"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_9ba59db8","line":127,"updated":"2017-05-29 10:15:04.000000000","message":"Should use this form:\n# RIGHT\nraise ValueError(_(\u0027some message: variable\u003d%s\u0027) % variable)\n\nsee: https://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    yield response.get_wire()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"                else:"},{"line_number":144,"context_line":"                    LOG.error(\"Unexpected response %(resp)s\" %"},{"line_number":145,"context_line":"                              repr(response))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_3b945144","line":144,"updated":"2017-05-29 10:15:04.000000000","message":"ditto","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"}],"designate/metrics.py":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from oslo_config import cfg"},{"line_number":41,"context_line":"from oslo_log import log as logging"},{"line_number":42,"context_line":"from oslo_utils import importutils"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"stats_client \u003d importutils.import_any(\u0027monascastatsd\u0027,"},{"line_number":45,"context_line":"                                      \u0027designate.metrics_client.noop\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_ed2a9f8e","line":43,"updated":"2017-05-29 09:27:18.000000000","message":"2 blank lines","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        conf \u003d cfg.CONF[CFG_GROUP]"},{"line_number":86,"context_line":"        if conf.enabled:"},{"line_number":87,"context_line":"            LOG.info(\"Statsd reports to %(host)s %(port)d\" % {"},{"line_number":88,"context_line":"                \u0027host\u0027: conf.hostname,"},{"line_number":89,"context_line":"                \u0027port\u0027: conf.port"},{"line_number":90,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_7b34094b","line":87,"range":{"start_line":87,"start_character":58,"end_line":87,"end_character":60},"updated":"2017-05-29 10:19:48.000000000","message":"why do you not change this too?","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        conf \u003d cfg.CONF[CFG_GROUP]"},{"line_number":86,"context_line":"        if conf.enabled:"},{"line_number":87,"context_line":"            LOG.info(\"Statsd reports to %(host)s %(port)d\" % {"},{"line_number":88,"context_line":"                \u0027host\u0027: conf.hostname,"},{"line_number":89,"context_line":"                \u0027port\u0027: conf.port"},{"line_number":90,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_5b88251e","line":87,"updated":"2017-05-29 10:15:04.000000000","message":"https://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"}],"designate/notifications.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                               (int, float, bool, str, type(None))"},{"line_number":162,"context_line":"                               for val in (old_value, new_value)):"},{"line_number":163,"context_line":"                            old_value, new_value \u003d None, None"},{"line_number":164,"context_line":"                            msg \u003d (\"Nulling notification values after \""},{"line_number":165,"context_line":"                                   \"unexpected values %s\")"},{"line_number":166,"context_line":"                            LOG.warning(msg, (old_value, new_value))"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_9b18fdd3","line":164,"range":{"start_line":164,"start_character":28,"end_line":164,"end_character":31},"updated":"2017-05-29 10:19:48.000000000","message":"no need this variable","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"}],"designate/service.py":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"05ae7d092c8ad862cd06831a5ff14f9126f9a0fa","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # ensure no exceptions are generated from within."},{"line_number":328,"context_line":"            except socket.timeout:"},{"line_number":329,"context_line":"                client.close()"},{"line_number":330,"context_line":"                LOG.warning(\"TCP Timeout from: %(host)s:%(port)d\" %"},{"line_number":331,"context_line":"                            {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            except socket.error as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_d0fe5404","line":330,"updated":"2017-05-29 09:27:18.000000000","message":"LOG.info(_LI(\u0027some message: variable\u003d%s\u0027), variable)","commit_id":"889bebf0c239c6441fd22e7f4b08dd6efa102c84"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                client.close()"},{"line_number":335,"context_line":"                errname \u003d errno.errorcode[e.args[0]]"},{"line_number":336,"context_line":"                LOG.warning("},{"line_number":337,"context_line":"                    \"Socket error %(err)s from: %(host)s:%(port)d\" %"},{"line_number":338,"context_line":"                    {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1], \u0027err\u0027: errname})"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_7bdc0946","line":337,"range":{"start_line":337,"start_character":67,"end_line":337,"end_character":68},"updated":"2017-05-29 10:19:48.000000000","message":"how about this?","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            except Exception:"},{"line_number":341,"context_line":"                client.close()"},{"line_number":342,"context_line":"                LOG.exception(\"Unknown exception handling TCP request \""},{"line_number":343,"context_line":"                              \"from: %(host)s:%(port)d\" %"},{"line_number":344,"context_line":"                              {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _dns_handle_tcp_conn(self, addr, client):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_3be69118","line":343,"range":{"start_line":343,"start_character":56,"end_line":343,"end_character":57},"updated":"2017-05-29 10:19:48.000000000","message":"this too?","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            except socket.error as e:"},{"line_number":439,"context_line":"                errname \u003d errno.errorcode[e.args[0]]"},{"line_number":440,"context_line":"                LOG.warning("},{"line_number":441,"context_line":"                    \"Socket error %(err)s from: %(host)s:%(port)d\" %"},{"line_number":442,"context_line":"                    {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1], \u0027err\u0027: errname})"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_fbeff9e6","line":441,"range":{"start_line":441,"start_character":67,"end_line":441,"end_character":68},"updated":"2017-05-29 10:19:48.000000000","message":"ditto","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            except Exception:"},{"line_number":445,"context_line":"                LOG.exception(\"Unknown exception handling UDP request \""},{"line_number":446,"context_line":"                              \"from: %(host)s:%(port)d\" %"},{"line_number":447,"context_line":"                              {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def _dns_handle_udp_query(self, sock, addr, payload):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_dbec35f5","line":446,"range":{"start_line":446,"start_character":55,"end_line":446,"end_character":57},"updated":"2017-05-29 10:19:48.000000000","message":"ditto","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"938474ba2104f23747057106fb1e68dd6ed497cc","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        except Exception:"},{"line_number":471,"context_line":"            LOG.exception(\"Unhandled exception while processing request \""},{"line_number":472,"context_line":"                          \"from %(host)s:%(port)d\" %"},{"line_number":473,"context_line":"                          {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bbbbc1e3","line":472,"range":{"start_line":472,"start_character":50,"end_line":472,"end_character":52},"updated":"2017-05-29 10:19:48.000000000","message":"this?","commit_id":"1301680ce6fb1da9ad97098d83750acfc210c81f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            except Exception:"},{"line_number":341,"context_line":"                client.close()"},{"line_number":342,"context_line":"                LOG.exception(\"Unknown exception handling TCP request \""},{"line_number":343,"context_line":"                              \"from: %(host)s:%(port)d\" %"},{"line_number":344,"context_line":"                              {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _dns_handle_tcp_conn(self, addr, client):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_bb8e2125","line":343,"updated":"2017-05-29 10:15:04.000000000","message":"https://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            except socket.error as e:"},{"line_number":439,"context_line":"                errname \u003d errno.errorcode[e.args[0]]"},{"line_number":440,"context_line":"                LOG.warning("},{"line_number":441,"context_line":"                    \"Socket error %(err)s from: %(host)s:%(port)d\" %"},{"line_number":442,"context_line":"                    {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1], \u0027err\u0027: errname})"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_3ba2119c","line":441,"updated":"2017-05-29 10:15:04.000000000","message":"ditto","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            except Exception:"},{"line_number":445,"context_line":"                LOG.exception(\"Unknown exception handling UDP request \""},{"line_number":446,"context_line":"                              \"from: %(host)s:%(port)d\" %"},{"line_number":447,"context_line":"                              {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def _dns_handle_udp_query(self, sock, addr, payload):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_1b9f4d51","line":446,"updated":"2017-05-29 10:15:04.000000000","message":"ditto","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"3f1bb64fd703f0525d85ee5e46ae35f535629d9f","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        except Exception:"},{"line_number":471,"context_line":"            LOG.exception(\"Unhandled exception while processing request \""},{"line_number":472,"context_line":"                          \"from %(host)s:%(port)d\" %"},{"line_number":473,"context_line":"                          {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_9bbc7dbc","line":472,"updated":"2017-05-29 10:15:04.000000000","message":"ditto","commit_id":"ef9eb8aa318dcf820775b822932922c0f52a558f"}]}