)]}'
{"designate/objects/fields.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"302931a9db9b945e0d9364c11267353be539f73c","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            return v"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class IPV4AndV6AddressFields(ovoo_fields.Field):"},{"line_number":386,"context_line":"    def __init__(self, field_type\u003dovoo_fields.FieldType, nullable\u003dFalse,"},{"line_number":387,"context_line":"                 read_only\u003dFalse,"},{"line_number":388,"context_line":"                 default\u003dovoo_fields.UnspecifiedDefault):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_44f5a082","line":385,"updated":"2018-01-26 15:17:57.000000000","message":"Maybe keep the class name simpler with just IPAddressFields?","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"441a8d42e4a5494999842b12e411a75db1f2138e","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            return v"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class IPV4AndV6AddressFields(ovoo_fields.Field):"},{"line_number":386,"context_line":"    def __init__(self, field_type\u003dovoo_fields.FieldType, nullable\u003dFalse,"},{"line_number":387,"context_line":"                 read_only\u003dFalse,"},{"line_number":388,"context_line":"                 default\u003dovoo_fields.UnspecifiedDefault):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_fc4e4e36","line":385,"in_reply_to":"5f93b717_44f5a082","updated":"2018-01-31 20:47:18.000000000","message":"I would like to see this changed to IPAdressFields as well.","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"302931a9db9b945e0d9364c11267353be539f73c","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            count \u003d 0"},{"line_number":401,"context_line":"            try:"},{"line_number":402,"context_line":"                address \u003d netaddr.IPAddress(v, version\u003d4)"},{"line_number":403,"context_line":"                # netaddr happly accepts, and expands \"127.0\" into \"127.0.0.0\""},{"line_number":404,"context_line":"                if str(address) !\u003d v:"},{"line_number":405,"context_line":"                    count +\u003d 1"},{"line_number":406,"context_line":"                elif v \u003d\u003d \u00270.0.0.0\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_84eac8a9","line":403,"updated":"2018-01-26 15:17:57.000000000","message":"What is wrong with that, why can\u0027t we just accept that? Same with other valid formats like 127.010.2.3","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"302931a9db9b945e0d9364c11267353be539f73c","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                # netaddr happly accepts, and expands \"127.0\" into \"127.0.0.0\""},{"line_number":404,"context_line":"                if str(address) !\u003d v:"},{"line_number":405,"context_line":"                    count +\u003d 1"},{"line_number":406,"context_line":"                elif v \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":407,"context_line":"                    count +\u003d 1"},{"line_number":408,"context_line":"            except Exception:"},{"line_number":409,"context_line":"                count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_24d174fc","line":406,"updated":"2018-01-26 15:17:57.000000000","message":"What is so special about this that you need to explicitly disallow it?","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"302931a9db9b945e0d9364c11267353be539f73c","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            except Exception:"},{"line_number":414,"context_line":"                count +\u003d 1"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if count \u003d\u003d 2:  # RFC5735"},{"line_number":417,"context_line":"                raise ValueError(\"%s is not IPV4 or IPV6\" % v)"},{"line_number":418,"context_line":"            return v"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_c4bbf0c1","line":416,"updated":"2018-01-26 15:17:57.000000000","message":"I don\u0027t understand the mentioning of this RFC, what does it have to do with this?","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"}],"designate/objects/floating_ip.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"302931a9db9b945e0d9364c11267353be539f73c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FloatingIP(base.DictObjectMixin, base.PersistentObjectMixin,"},{"line_number":22,"context_line":"                 base.DesignateObject):"},{"line_number":23,"context_line":"    fields \u003d {"},{"line_number":24,"context_line":"        \"address\": fields.IPV4AndV6AddressFields(nullable\u003dTrue),"},{"line_number":25,"context_line":"        \"description\": fields.StringFields(nullable\u003dTrue, maxLength\u003d160),"},{"line_number":26,"context_line":"        \"ptrdname\": fields.DomainField(nullable\u003dTrue),"},{"line_number":27,"context_line":"        \"ttl\": fields.IntegerFields(nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_44236006","line":24,"updated":"2018-01-26 15:17:57.000000000","message":"Maybe not the right place to discuss this, as it way the same way before, but do IPv6 FloatingIPs really exist? Neutron seems to only support v4 FIPs unless I\u0027m mistaken.","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"8e55a35b5aa379fed129868aa20baef806bf4774","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FloatingIP(base.DictObjectMixin, base.PersistentObjectMixin,"},{"line_number":22,"context_line":"                 base.DesignateObject):"},{"line_number":23,"context_line":"    fields \u003d {"},{"line_number":24,"context_line":"        \"address\": fields.IPV4AndV6AddressFields(nullable\u003dTrue),"},{"line_number":25,"context_line":"        \"description\": fields.StringFields(nullable\u003dTrue, maxLength\u003d160),"},{"line_number":26,"context_line":"        \"ptrdname\": fields.DomainField(nullable\u003dTrue),"},{"line_number":27,"context_line":"        \"ttl\": fields.IntegerFields(nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f93b717_c7f7ed8a","line":24,"in_reply_to":"5f93b717_44236006","updated":"2018-02-01 09:45:41.000000000","message":"Nice catch, I just look around [1] and I agree that Neutron does not support Floating IP V6 at this time.\n\n\n[1] https://review.openstack.org/#/c/267891/","commit_id":"08e014449fc1d504f21265c67e1f6e11df27804d"}]}