)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Fix some warning about missing help string"},{"line_number":11,"context_line":"- Auto-generate sample config via genconfig testenv."},{"line_number":12,"context_line":"- Add an instruction in README about genconfig"},{"line_number":13,"context_line":"- Centralize backend conf into agent config"},{"line_number":14,"context_line":"- Create config sample along with whole service, backend"},{"line_number":15,"context_line":"- Create opts.py to focus list_opts."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"5f201791_34847cd2","line":13,"updated":"2017-06-28 16:45:59.000000000","message":"We should not do this - there is 2 types of backend, and only one of them uses the agent","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Fix some warning about missing help string"},{"line_number":11,"context_line":"- Auto-generate sample config via genconfig testenv."},{"line_number":12,"context_line":"- Add an instruction in README about genconfig"},{"line_number":13,"context_line":"- Centralize backend conf into agent config"},{"line_number":14,"context_line":"- Create config sample along with whole service, backend"},{"line_number":15,"context_line":"- Create opts.py to focus list_opts."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3f1d235d_99b694fa","line":13,"in_reply_to":"5f201791_34847cd2","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"contrib/archive/backends/impl_ipa/__init__.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"import pprint"},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_d41f88b4","line":15,"updated":"2017-06-28 16:45:59.000000000","message":"This file should not change - it is in an archive","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"import pprint"},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_59d0fc1f","line":15,"in_reply_to":"5f201791_d41f88b4","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"designate/agent/__init__.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\"\"\"GROUP \u003d backend:agent:bind9\"\"\""},{"line_number":60,"context_line":"bind9_group \u003d cfg.OptGroup("},{"line_number":61,"context_line":"    name\u003d\u0027backend:agent:bind9\u0027, title\u003d\"Configuration for bind9 backend\""},{"line_number":62,"context_line":")"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_540c9892","line":59,"updated":"2017-06-28 16:45:59.000000000","message":"I think we should leave these config options where they are.","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\"\"\"GROUP \u003d backend:agent:bind9\"\"\""},{"line_number":60,"context_line":"bind9_group \u003d cfg.OptGroup("},{"line_number":61,"context_line":"    name\u003d\u0027backend:agent:bind9\u0027, title\u003d\"Configuration for bind9 backend\""},{"line_number":62,"context_line":")"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_f9c46861","line":59,"in_reply_to":"5f201791_540c9892","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"\"\"\"GROUP \u003d backend:agent:DynECT\"\"\""},{"line_number":160,"context_line":"impl_dynect \u003d cfg.OptGroup("},{"line_number":161,"context_line":"            name\u003d\u0027backend:dynect\u0027, title\u003d\u0027Backend options for DynECT\u0027"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_340fdc88","line":160,"updated":"2017-06-28 16:45:59.000000000","message":"DynECT does not use the agent, and gets its config from pools.yaml","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"\"\"\"GROUP \u003d backend:agent:DynECT\"\"\""},{"line_number":160,"context_line":"impl_dynect \u003d cfg.OptGroup("},{"line_number":161,"context_line":"            name\u003d\u0027backend:dynect\u0027, title\u003d\u0027Backend options for DynECT\u0027"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_d9a1acab","line":160,"in_reply_to":"5f201791_340fdc88","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\"\"\"GROUP \u003d backend:agent:infoblox\"\"\""},{"line_number":175,"context_line":"impl_infoblox_group \u003d cfg.OptGroup("},{"line_number":176,"context_line":"    name\u003d\u0027backend:infoblox\u0027, title\u003d\"Configuration for Infoblox Backend\""},{"line_number":177,"context_line":")"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_142aa0d9","line":175,"updated":"2017-06-28 16:45:59.000000000","message":"infoblox does not use the agent - it gets its config from pools.yaml","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\"\"\"GROUP \u003d backend:agent:infoblox\"\"\""},{"line_number":175,"context_line":"impl_infoblox_group \u003d cfg.OptGroup("},{"line_number":176,"context_line":"    name\u003d\u0027backend:infoblox\u0027, title\u003d\"Configuration for Infoblox Backend\""},{"line_number":177,"context_line":")"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_b9a4b0ba","line":175,"in_reply_to":"5f201791_142aa0d9","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"\"\"\"GROUP \u003d backend:ipa\"\"\""},{"line_number":251,"context_line":"impl_infoblox_ipa \u003d cfg.OptGroup("},{"line_number":252,"context_line":"            name\u003d\u0027backend:ipa\u0027, title\u003d\"Configuration for IPA Backend\""},{"line_number":253,"context_line":"        )"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_f424c40e","line":251,"updated":"2017-06-28 16:45:59.000000000","message":"this is named wrong - and the IPA backend is archioved, and not working","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"\"\"\"GROUP \u003d backend:ipa\"\"\""},{"line_number":251,"context_line":"impl_infoblox_ipa \u003d cfg.OptGroup("},{"line_number":252,"context_line":"            name\u003d\u0027backend:ipa\u0027, title\u003d\"Configuration for IPA Backend\""},{"line_number":253,"context_line":"        )"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_99ab3488","line":251,"in_reply_to":"5f201791_f424c40e","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"designate/api/__init__.py":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"c7994fd471a2eb7761181fea1942321d69b8be63","unresolved":false,"context_lines":[{"line_number":27,"context_line":"               help\u003d\u0027Number of api greenthreads to spawn\u0027),"},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable-host-header\u0027, default\u003dFalse,"},{"line_number":29,"context_line":"               help\u003d\u0027Enable host request headers\u0027),"},{"line_number":30,"context_line":"    # TODO(trungnv): Fix typo \u0027api-base-uri\u0027 into \u0027api-base-url\u0027"},{"line_number":31,"context_line":"    # along with related things."},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027,"},{"line_number":33,"context_line":"      help\u003d\u0027api-base-uri which have url default is localhost\u0027),"},{"line_number":34,"context_line":"    cfg.IPOpt(\u0027api_host\u0027,"},{"line_number":35,"context_line":"              deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_13eb5f79","line":32,"range":{"start_line":30,"start_character":4,"end_line":32,"end_character":64},"updated":"2017-06-14 02:14:46.000000000","message":"why did you consider this as typo? Otherwise, changing configuration should cause problem when upgrading.","commit_id":"61b8329c61c15bc954cfcea4f7b7ddd7c86ba199"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"a3c6c0dd84eac5ea79163ea2c186d06254505479","unresolved":false,"context_lines":[{"line_number":27,"context_line":"               help\u003d\u0027Number of api greenthreads to spawn\u0027),"},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable-host-header\u0027, default\u003dFalse,"},{"line_number":29,"context_line":"               help\u003d\u0027Enable host request headers\u0027),"},{"line_number":30,"context_line":"    # TODO(trungnv): Fix typo \u0027api-base-uri\u0027 into \u0027api-base-url\u0027"},{"line_number":31,"context_line":"    # along with related things."},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027,"},{"line_number":33,"context_line":"      help\u003d\u0027api-base-uri which have url default is localhost\u0027),"},{"line_number":34,"context_line":"    cfg.IPOpt(\u0027api_host\u0027,"},{"line_number":35,"context_line":"              deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_8ee504ab","line":32,"range":{"start_line":30,"start_character":4,"end_line":32,"end_character":64},"in_reply_to":"7f231b9d_13eb5f79","updated":"2017-06-14 02:50:59.000000000","message":"perhaps this is my mistake. uri is \u0027Uniform Resource Identifier\u0027. I will change in the next PS. Thanks","commit_id":"61b8329c61c15bc954cfcea4f7b7ddd7c86ba199"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b54ee4e7966977fda385de3bbab8f62f9e502339","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable-host-header\u0027, default\u003dFalse,"},{"line_number":29,"context_line":"               help\u003d\u0027Enable host request headers\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027,"},{"line_number":31,"context_line":"      help\u003d\u0027api-base-uri which have url default is localhost\u0027),"},{"line_number":32,"context_line":"    cfg.IPOpt(\u0027api_host\u0027,"},{"line_number":33,"context_line":"              deprecated_for_removal\u003dTrue,"},{"line_number":34,"context_line":"              deprecated_reason\u003d\"Replaced by \u0027listen\u0027 option\","}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_906522e4","line":31,"updated":"2017-06-14 03:02:03.000000000","message":"nit: indent","commit_id":"1d035c8160a453ca97010890a070b41dea2c9457"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b54ee4e7966977fda385de3bbab8f62f9e502339","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    \u0027keystone\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable-api-v1\u0027, default\u003dFalse,"},{"line_number":49,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":50,"context_line":"                deprecated_reason\u003d(\"V1 API is being removed in a future\""},{"line_number":51,"context_line":"                \"release\"),"},{"line_number":52,"context_line":"                help\u003d\u0027enable-api-v1 which removed in a future\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027enable-api-v2\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_90aac2cf","line":50,"range":{"start_line":50,"start_character":34,"end_line":50,"end_character":35},"updated":"2017-06-14 03:02:03.000000000","message":"nit: remove this parentheses","commit_id":"1d035c8160a453ca97010890a070b41dea2c9457"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b54ee4e7966977fda385de3bbab8f62f9e502339","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                \"release\"),"},{"line_number":52,"context_line":"                help\u003d\u0027enable-api-v1 which removed in a future\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027enable-api-v2\u0027, default\u003dTrue,"},{"line_number":54,"context_line":"    help\u003d\u0027enable-api-v2 which enable in a future\u0027),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027enable-api-admin\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"    help\u003d\u0027enable-api-admin\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_309c0ebf","line":54,"updated":"2017-06-14 03:02:03.000000000","message":"ditto","commit_id":"1d035c8160a453ca97010890a070b41dea2c9457"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b54ee4e7966977fda385de3bbab8f62f9e502339","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027enable-api-v2\u0027, default\u003dTrue,"},{"line_number":54,"context_line":"    help\u003d\u0027enable-api-v2 which enable in a future\u0027),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027enable-api-admin\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"    help\u003d\u0027enable-api-admin\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"},{"line_number":58,"context_line":"               help\u003d\"Maximum line size of message headers to be accepted. \""},{"line_number":59,"context_line":"                    \"max_header_line may need to be increased when using \""}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_109fd2b4","line":56,"updated":"2017-06-14 03:02:03.000000000","message":"ditto","commit_id":"1d035c8160a453ca97010890a070b41dea2c9457"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable-host-header\u0027, default\u003dFalse,"},{"line_number":29,"context_line":"               help\u003d\u0027Enable host request headers\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027api-base-uri which have url default is localhost\u0027),"},{"line_number":32,"context_line":"    cfg.IPOpt(\u0027api_host\u0027,"},{"line_number":33,"context_line":"              deprecated_for_removal\u003dTrue,"},{"line_number":34,"context_line":"              deprecated_reason\u003d\"Replaced by \u0027listen\u0027 option\","}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_b41accc2","line":31,"updated":"2017-06-28 16:45:59.000000000","message":"This would be better as \"the url that is used as the base for all API responses. This should consist of the scheme (http or https), the hostname, port, and any paths that are added to the base of Designate\u0027s URLs. For example http://dns.openstack.example.com/dns","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable-host-header\u0027, default\u003dFalse,"},{"line_number":29,"context_line":"               help\u003d\u0027Enable host request headers\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027api-base-uri which have url default is localhost\u0027),"},{"line_number":32,"context_line":"    cfg.IPOpt(\u0027api_host\u0027,"},{"line_number":33,"context_line":"              deprecated_for_removal\u003dTrue,"},{"line_number":34,"context_line":"              deprecated_reason\u003d\"Replaced by \u0027listen\u0027 option\","}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_39cb0073","line":31,"in_reply_to":"5f201791_b41accc2","updated":"2017-07-01 15:00:36.000000000","message":"Done","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                \"release\","},{"line_number":52,"context_line":"                help\u003d\u0027enable-api-v1 which removed in a future\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027enable-api-v2\u0027, default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027enable-api-v2 which enable in a future\u0027),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027enable-api-admin\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"                help\u003d\u0027enable-api-admin\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_947b50f3","line":54,"updated":"2017-06-28 16:45:59.000000000","message":"This does not need help text","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                \"release\","},{"line_number":52,"context_line":"                help\u003d\u0027enable-api-v1 which removed in a future\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027enable-api-v2\u0027, default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027enable-api-v2 which enable in a future\u0027),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027enable-api-admin\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"                help\u003d\u0027enable-api-admin\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_19ca846c","line":54,"in_reply_to":"5f201791_947b50f3","updated":"2017-07-01 15:00:36.000000000","message":"if this isn\u0027t \u0027help\u0027 string then raise warning [1]\n[1] http://paste.ubuntu.com/24995787/","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"designate/backend/agent_backend/impl_bind9.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88422e84d2c40fb41759ce3baddd6ae83b54e3bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from designate import utils"},{"line_number":27,"context_line":"from designate.i18n import _LI"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from designate import agent"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"CFG_GROUP \u003d \u0027backend:agent:bind9\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_fa8bfd1b","line":29,"updated":"2017-06-25 10:05:05.000000000","message":"This import should actually be added above as the first line of the local designate imports.","commit_id":"d382ee20bc444e88f17f87f34c901611088c4937"}],"designate/notification_handler/neutron.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, help\u003d\u0027IPv4 format\u0027),"},{"line_number":37,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":38,"context_line":"                    deprecated_reason\u003d\"Replaced by \u0027formatv4/formatv6\u0027\","},{"line_number":39,"context_line":"                    help\u003d\u0027format which replaced by formatv4/formatv6\u0027"},{"line_number":40,"context_line":"                    ),"},{"line_number":41,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, help\u003d\u0027IPv6 format\u0027)"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_548138c2","line":39,"updated":"2017-06-28 16:45:59.000000000","message":"this can be removed","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, help\u003d\u0027IPv4 format\u0027),"},{"line_number":37,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":38,"context_line":"                    deprecated_reason\u003d\"Replaced by \u0027formatv4/formatv6\u0027\","},{"line_number":39,"context_line":"                    help\u003d\u0027format which replaced by formatv4/formatv6\u0027"},{"line_number":40,"context_line":"                    ),"},{"line_number":41,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, help\u003d\u0027IPv6 format\u0027)"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_3990a04e","line":39,"in_reply_to":"5f201791_548138c2","updated":"2017-07-01 15:00:36.000000000","message":"I will remove in other PS, due to some issues with test-case [1]\n\n[1] http://paste.ubuntu.com/24995858/","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"designate/notification_handler/nova.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"41e25490d09e0af1793be0063e74c4b3e3a57274","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, help\u003d\u0027IPv4 format\u0027),"},{"line_number":37,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":38,"context_line":"                    deprecated_reason\u003d\"Replaced by \u0027formatv4/formatv6\u0027\","},{"line_number":39,"context_line":"                    help\u003d\u0027format which replaced by formatv4/formatv6\u0027"},{"line_number":40,"context_line":"                    ),"},{"line_number":41,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, help\u003d\u0027IPv6 format\u0027)"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f201791_747e74e4","line":39,"updated":"2017-06-28 16:45:59.000000000","message":"this can be removed","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"67d972cb6a3e2f32b9627ef1efcfc9f0cbb6622c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.MultiStrOpt(\u0027formatv4\u0027, help\u003d\u0027IPv4 format\u0027),"},{"line_number":37,"context_line":"    cfg.MultiStrOpt(\u0027format\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":38,"context_line":"                    deprecated_reason\u003d\"Replaced by \u0027formatv4/formatv6\u0027\","},{"line_number":39,"context_line":"                    help\u003d\u0027format which replaced by formatv4/formatv6\u0027"},{"line_number":40,"context_line":"                    ),"},{"line_number":41,"context_line":"    cfg.MultiStrOpt(\u0027formatv6\u0027, help\u003d\u0027IPv6 format\u0027)"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_199f2460","line":39,"in_reply_to":"5f201791_747e74e4","updated":"2017-07-01 15:00:36.000000000","message":"I will remove in other PS, due to some issues with test-case [1]\n\n[1] http://paste.ubuntu.com/24995858/","commit_id":"0b89b571217b309ad6dab892bb6bd7794f5743d8"}],"designate/pool_manager/__init__.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88422e84d2c40fb41759ce3baddd6ae83b54e3bc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d\u0027RPC topic name for pool-manager\u0027)"},{"line_number":75,"context_line":"]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# CONF.register_opts(OPTS, group\u003d\u0027service:pool_manager\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def register_dynamic_pool_options():"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_7a96cd4e","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":1},"updated":"2017-06-25 10:05:05.000000000","message":"Please remove commented out code.","commit_id":"d382ee20bc444e88f17f87f34c901611088c4937"}],"etc/designate/designate-config-generator.conf":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"3b0bf7d4a60c2b27f1b8ac662f7e85360c50a522","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# NOTE(trungnv): generating a backend config location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"namespace \u003d designate"},{"line_number":10,"context_line":"namespace \u003d designate.central"},{"line_number":11,"context_line":"namespace \u003d designate.mdns"},{"line_number":12,"context_line":"namespace \u003d designate.network_api"},{"line_number":13,"context_line":"namespace \u003d designate.network_api.neutron"},{"line_number":14,"context_line":"namespace \u003d designate.metrics"},{"line_number":15,"context_line":"namespace \u003d designate.neutron"},{"line_number":16,"context_line":"namespace \u003d designate.nova"},{"line_number":17,"context_line":"namespace \u003d designate.notifications"},{"line_number":18,"context_line":"namespace \u003d designate.pool_manager"},{"line_number":19,"context_line":"namespace \u003d designate.pool_manager.cache.impl_memcache"},{"line_number":20,"context_line":"namespace \u003d designate.pool_manager.cache.impl_sqlalchemy"},{"line_number":21,"context_line":"namespace \u003d designate.producer"},{"line_number":22,"context_line":"namespace \u003d designate.quota"},{"line_number":23,"context_line":"namespace \u003d designate.scheduler"},{"line_number":24,"context_line":"namespace \u003d designate.sink"},{"line_number":25,"context_line":"namespace \u003d designate.worker"},{"line_number":26,"context_line":"namespace \u003d designate.storage"},{"line_number":27,"context_line":"namespace \u003d designate.dnsutils"},{"line_number":28,"context_line":"namespace \u003d oslo.log"},{"line_number":29,"context_line":"namespace \u003d oslo.messaging"},{"line_number":30,"context_line":"namespace \u003d oslo.policy"}],"source_content_type":"text/plain","patch_set":17,"id":"7f231b9d_6848395b","line":27,"range":{"start_line":9,"start_character":0,"end_line":27,"end_character":30},"updated":"2017-06-15 00:59:19.000000000","message":"lots of namespace here, each namespace require us to put list_opt method in each module.\nhow about centralize list_opt in designate main module, like the way Nova do in Mitaka: https://github.com/openstack/nova/blob/stable/mitaka/nova/opts.py","commit_id":"d4d8ced5519000c98253250365c11c8b1a71509b"}]}