)]}'
{"designate/api/v1/servers.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    values \u003d flask.request.json"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    LOG.warn(\"::APIv1::create_server::\")"},{"line_number":46,"context_line":"    LOG.warn(\"::APIv1::create_server::default_pool_id - %s\", default_pool_id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    server_schema.validate(values)"},{"line_number":49,"context_line":"    server \u003d central_api.create_server(context, default_pool_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fqp0%3D","line":46,"updated":"2013-10-11 14:58:21.000000000","message":"Do these log messages need to be warnings?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    values \u003d flask.request.json"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    LOG.warn(\"::APIv1::create_server::\")"},{"line_number":46,"context_line":"    LOG.warn(\"::APIv1::create_server::default_pool_id - %s\", default_pool_id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    server_schema.validate(values)"},{"line_number":49,"context_line":"    server \u003d central_api.create_server(context, default_pool_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqAk%3D","line":46,"in_reply_to":"AAAATH%2F%2Fqp0%3D","updated":"2013-10-11 16:39:49.000000000","message":"nope. Will take them out","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/api/v2/controllers/pools.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        raise NotImplemented(\u0027Pools Limit of 1\u0027)"},{"line_number":71,"context_line":"        # NOTE: multiple pools not allowed currently, and must have at least 1"},{"line_number":72,"context_line":"        # Currently the SQLA migration creates a default pool for us"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        request \u003d pecan.request"},{"line_number":75,"context_line":"        response \u003d pecan.response"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fumo%3D","line":72,"updated":"2013-10-11 14:58:21.000000000","message":"Is the rest of the code below a placeholder for later?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        raise NotImplemented(\u0027Pools Limit of 1\u0027)"},{"line_number":71,"context_line":"        # NOTE: multiple pools not allowed currently, and must have at least 1"},{"line_number":72,"context_line":"        # Currently the SQLA migration creates a default pool for us"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        request \u003d pecan.request"},{"line_number":75,"context_line":"        response \u003d pecan.response"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqBM%3D","line":72,"in_reply_to":"AAAATH%2F%2FqF0%3D","updated":"2013-10-11 16:39:49.000000000","message":"It is, I will put in a todo to mark it","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f73732219969bf07db6396e931392808167424da","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        raise NotImplemented(\u0027Pools Limit of 1\u0027)"},{"line_number":71,"context_line":"        # NOTE: multiple pools not allowed currently, and must have at least 1"},{"line_number":72,"context_line":"        # Currently the SQLA migration creates a default pool for us"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        request \u003d pecan.request"},{"line_number":75,"context_line":"        response \u003d pecan.response"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqF0%3D","line":72,"in_reply_to":"AAAATH%2F%2Fumo%3D","updated":"2013-10-11 16:22:10.000000000","message":"The code below looks like it should work, but furthur into the stack we don\u0027t support more than 1 pool, so I\u0027d go with \"yes - placeholder\" :)","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":103,"context_line":"        body \u003d request.body_dict"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        LOG.warn(\u0027REQUEST:: %s\u0027, str(request))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # TODO(kiall): Validate we have a sane UUID for pool_id"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fqpg%3D","line":105,"updated":"2013-10-11 14:58:21.000000000","message":"Does this log message need to be a warning?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":103,"context_line":"        body \u003d request.body_dict"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        LOG.warn(\u0027REQUEST:: %s\u0027, str(request))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # TODO(kiall): Validate we have a sane UUID for pool_id"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqA4%3D","line":105,"in_reply_to":"AAAATH%2F%2FqFg%3D","updated":"2013-10-11 16:39:49.000000000","message":"yup, it looks like an errant debug statement that I missed.","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f73732219969bf07db6396e931392808167424da","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":103,"context_line":"        body \u003d request.body_dict"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        LOG.warn(\u0027REQUEST:: %s\u0027, str(request))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # TODO(kiall): Validate we have a sane UUID for pool_id"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqFg%3D","line":105,"in_reply_to":"AAAATH%2F%2Fqpg%3D","updated":"2013-10-11 16:22:10.000000000","message":"Yea - Lets sort all all the log messages in this review. This one in particular is going to log the auth token - an absolute no no :)","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        if request.content_type \u003d\u003d \u0027application/json-patch+json\u0027:"},{"line_number":116,"context_line":"            # Possible pattern:"},{"line_number":117,"context_line":"            #"},{"line_number":118,"context_line":"            # 1) Load existing poool."},{"line_number":119,"context_line":"            # 2) Apply patch, maintain list of changes."},{"line_number":120,"context_line":"            # 3) Return changes, after passing through the code ^ for plain"},{"line_number":121,"context_line":"            #    JSON."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FulE%3D","line":118,"updated":"2013-10-11 14:58:21.000000000","message":"Minor - typo in pool","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        response \u003d pecan.response"},{"line_number":145,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        raise NotImplemented(\u0027Pools Limit of 1\u0027)"},{"line_number":148,"context_line":"        # NOTE: multiple pools not allowed currently, and must have at least 1"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # TODO(kiall): Validate we have a sane UUID for pool_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fukk%3D","line":147,"updated":"2013-10-11 14:58:21.000000000","message":"(1) Can the last pool that exists be deleted?  If not can we just check whether there is one pool and raise a different exception (for phase I too?)\n(2)Is the rest of the code below a placeholder for later?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        response \u003d pecan.response"},{"line_number":145,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        raise NotImplemented(\u0027Pools Limit of 1\u0027)"},{"line_number":148,"context_line":"        # NOTE: multiple pools not allowed currently, and must have at least 1"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # TODO(kiall): Validate we have a sane UUID for pool_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqAs%3D","line":147,"in_reply_to":"AAAATH%2F%2Fukk%3D","updated":"2013-10-11 16:39:49.000000000","message":"It currently can be deleted, and the rest is a placeholder - as the code to create a pool is also not operational","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/api/v2/controllers/servers.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # Convert to APIv2 Format"},{"line_number":104,"context_line":"        server \u003d self._view.detail(context, request, server)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if request.content_type \u003d\u003d \u0027application/json-patch+json\u0027:"},{"line_number":107,"context_line":"            # Possible pattern:"},{"line_number":108,"context_line":"            #"},{"line_number":109,"context_line":"            # 1) Load existing poool."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FuhY%3D","line":106,"updated":"2013-10-11 14:58:21.000000000","message":"Are the comments below valid for patching a server too?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # Convert to APIv2 Format"},{"line_number":104,"context_line":"        server \u003d self._view.detail(context, request, server)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if request.content_type \u003d\u003d \u0027application/json-patch+json\u0027:"},{"line_number":107,"context_line":"            # Possible pattern:"},{"line_number":108,"context_line":"            #"},{"line_number":109,"context_line":"            # 1) Load existing poool."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqAY%3D","line":106,"in_reply_to":"AAAATH%2F%2FuhY%3D","updated":"2013-10-11 16:39:49.000000000","message":"kind of. JSON patch is not really implemented anywhere yet, (that I know of)","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/api/v2/views/pools.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"pool\": {"},{"line_number":34,"context_line":"                \"id\": pool[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": pool[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": pool[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": pool[\u0027created_at\u0027],"},{"line_number":38,"context_line":"                \"updated_at\": pool[\u0027updated_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FugQ%3D","line":35,"updated":"2013-10-11 14:58:21.000000000","message":"Could we have a description field similar to the others?\nWould you be adding status and a list of servers at a later point?  If so a TODO would be helpful here.","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f73732219969bf07db6396e931392808167424da","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"pool\": {"},{"line_number":34,"context_line":"                \"id\": pool[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": pool[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": pool[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": pool[\u0027created_at\u0027],"},{"line_number":38,"context_line":"                \"updated_at\": pool[\u0027updated_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqEw%3D","line":35,"in_reply_to":"AAAATH%2F%2FugQ%3D","updated":"2013-10-11 16:22:10.000000000","message":"++ to description, not sure about the list of servers yet","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"pool\": {"},{"line_number":34,"context_line":"                \"id\": pool[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": pool[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": pool[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": pool[\u0027created_at\u0027],"},{"line_number":38,"context_line":"                \"updated_at\": pool[\u0027updated_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fp%2Fs%3D","line":35,"in_reply_to":"AAAATH%2F%2FugQ%3D","updated":"2013-10-11 16:39:49.000000000","message":"Description yup.\nList of servers no. They are a full nested sub resource, so to get the list of servers you do a GET /pools/\u003cid\u003e/servers","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/api/v2/views/servers.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"server\": {"},{"line_number":34,"context_line":"                \"id\": server[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": server[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": server[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": server[\u0027created_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fugg%3D","line":34,"updated":"2013-10-11 14:58:21.000000000","message":"Should there be a pool_id and status returned too?\nAlso could we have a description field similar to the others?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f73732219969bf07db6396e931392808167424da","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"server\": {"},{"line_number":34,"context_line":"                \"id\": server[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": server[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": server[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": server[\u0027created_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqE8%3D","line":34,"in_reply_to":"AAAATH%2F%2Fugg%3D","updated":"2013-10-11 16:22:10.000000000","message":"++","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"server\": {"},{"line_number":34,"context_line":"                \"id\": server[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": server[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"version\": server[\u0027version\u0027],"},{"line_number":37,"context_line":"                \"created_at\": server[\u0027created_at\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fp%2FU%3D","line":34,"in_reply_to":"AAAATH%2F%2Fugg%3D","updated":"2013-10-11 16:39:49.000000000","message":"description - yep.\nPool ID is redundant info, as you would have needed the pool id to get the server in the first place (GET /pools/\u003cpool_id\u003e/servers/\u003cserver_id\u003e)","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/pool_manager/rpcapi.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _get_topic(self, pool_id):"},{"line_number":37,"context_line":"        return self.topic"},{"line_number":38,"context_line":"        return \"%s-%s\" % (self.topic, pool_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Server Methods"},{"line_number":41,"context_line":"    def create_server(self, context, pool_id, server):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F3R8%3D","line":38,"updated":"2013-10-11 14:58:21.000000000","message":"There are 2 return statements here.","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _get_topic(self, pool_id):"},{"line_number":37,"context_line":"        return self.topic"},{"line_number":38,"context_line":"        return \"%s-%s\" % (self.topic, pool_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Server Methods"},{"line_number":41,"context_line":"    def create_server(self, context, pool_id, server):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fp%2FM%3D","line":38,"in_reply_to":"AAAATH%2F%2F3R8%3D","updated":"2013-10-11 16:39:49.000000000","message":"there is.... heh. good catch","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d15d03a00b3aaec060afb7b4e4a504056d549c7c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        return pool"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def update_pool(self, context, pool_id, values):"},{"line_number":190,"context_line":"        pass"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # return result"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fqug%3D","line":190,"updated":"2013-10-11 14:58:21.000000000","message":"Why is update_pool a pass?  Could you add a comment here explaining the reasoning?","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e4fb39765abed23e6896898c947e4fae97e5b8e2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        return pool"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def update_pool(self, context, pool_id, values):"},{"line_number":190,"context_line":"        pass"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # return result"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fp%2BI%3D","line":190,"in_reply_to":"AAAATH%2F%2FqEs%3D","updated":"2013-10-11 16:39:49.000000000","message":"they should. Not sure why its a pass. Will look, and it there is an issue, I will add a comment","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f73732219969bf07db6396e931392808167424da","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        return pool"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def update_pool(self, context, pool_id, values):"},{"line_number":190,"context_line":"        pass"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # return result"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FqEs%3D","line":190,"in_reply_to":"AAAATH%2F%2Fqug%3D","updated":"2013-10-11 16:22:10.000000000","message":"I reckon this just hasn\u0027t been completed yet.. Pools should be updateable..","commit_id":"4b838030a52aa92e1dc0557e02003f965dec249a"}]}