)]}'
{"designate/central/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e40ae2bea7247ddd56c05403a0acf924b59b610d","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"                msg \u003d _LE(\u0027An undefined error occurred during zone import\u0027)"},{"line_number":2685,"context_line":"                LOG.exception(msg)"},{"line_number":2686,"context_line":"                msg \u003d \u0027An undefined error occurred. %s\u0027\\"},{"line_number":2687,"context_line":"                      % six.text_type(e)[:130]"},{"line_number":2688,"context_line":"                zone_import.message \u003d msg"},{"line_number":2689,"context_line":"                zone_import.status \u003d \u0027ERROR\u0027"},{"line_number":2690,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_ec1e026f","line":2687,"updated":"2017-06-21 17:34:32.000000000","message":"Do we have a good reason to limit these to 130 characters? Couldn\u0027t we just replace this with the more reasonable \u0027...%s\u0027 % e?","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ffe76bc15aa76cf3218e71a40e7356213d565c07","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"                msg \u003d _LE(\u0027An undefined error occurred during zone import\u0027)"},{"line_number":2685,"context_line":"                LOG.exception(msg)"},{"line_number":2686,"context_line":"                msg \u003d \u0027An undefined error occurred. %s\u0027\\"},{"line_number":2687,"context_line":"                      % six.text_type(e)[:130]"},{"line_number":2688,"context_line":"                zone_import.message \u003d msg"},{"line_number":2689,"context_line":"                zone_import.status \u003d \u0027ERROR\u0027"},{"line_number":2690,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_d163bedb","line":2687,"in_reply_to":"5f201791_a6cdbd5e","updated":"2017-06-22 17:12:29.000000000","message":"Makes sense.","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"83fbee74720e224929338d1e577c382c48e8f6bf","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"                msg \u003d _LE(\u0027An undefined error occurred during zone import\u0027)"},{"line_number":2685,"context_line":"                LOG.exception(msg)"},{"line_number":2686,"context_line":"                msg \u003d \u0027An undefined error occurred. %s\u0027\\"},{"line_number":2687,"context_line":"                      % six.text_type(e)[:130]"},{"line_number":2688,"context_line":"                zone_import.message \u003d msg"},{"line_number":2689,"context_line":"                zone_import.status \u003d \u0027ERROR\u0027"},{"line_number":2690,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_a6cdbd5e","line":2687,"in_reply_to":"5f201791_ec1e026f","updated":"2017-06-22 03:25:19.000000000","message":"I\u0027m not sure about the reason to limit the amount of characters. So I decided to just leave it as it is.\ne.message should be replaced with a message instead of an object. That\u0027s why it was replaced by six.text_type(e)","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"}],"designate/mdns/xfr.py":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"295210f4d360b7a9deced899b7b90980dda38298","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            dnspython_zone \u003d dnsutils.do_axfr(zone.name, servers,"},{"line_number":41,"context_line":"                                              timeout\u003dtimeout)"},{"line_number":42,"context_line":"        except exceptions.XFRFailure as e:"},{"line_number":43,"context_line":"            LOG.warning(e)"},{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        zone.update(dnsutils.from_dnspython_zone(dnspython_zone))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_ac4a6c80","line":43,"range":{"start_line":43,"start_character":24,"end_line":43,"end_character":25},"updated":"2017-06-20 03:57:14.000000000","message":"I think this could be e.error_message because we have custom exception in Designate.\n\nCould you validate this point?\n\n[1]. https://github.com/openstack/designate/blob/master/designate/exceptions.py#L22","commit_id":"f7674fd9ad79ff947ee7920a2c40bfcee7d82c8b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e40ae2bea7247ddd56c05403a0acf924b59b610d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            dnspython_zone \u003d dnsutils.do_axfr(zone.name, servers,"},{"line_number":41,"context_line":"                                              timeout\u003dtimeout)"},{"line_number":42,"context_line":"        except exceptions.XFRFailure as e:"},{"line_number":43,"context_line":"            LOG.warning(e.error_message)"},{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        zone.update(dnsutils.from_dnspython_zone(dnspython_zone))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_ac180a81","line":43,"updated":"2017-06-21 17:34:32.000000000","message":"This should just be LOG.warning(e)","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ffe76bc15aa76cf3218e71a40e7356213d565c07","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            dnspython_zone \u003d dnsutils.do_axfr(zone.name, servers,"},{"line_number":41,"context_line":"                                              timeout\u003dtimeout)"},{"line_number":42,"context_line":"        except exceptions.XFRFailure as e:"},{"line_number":43,"context_line":"            LOG.warning(e.error_message)"},{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        zone.update(dnsutils.from_dnspython_zone(dnspython_zone))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_51220ea6","line":43,"in_reply_to":"5f201791_a6f6dd8e","updated":"2017-06-22 17:12:29.000000000","message":"Yep, but LOG.warning(e) and LOG.warning(e.error_message) would produce the same result.\n\nerror_message is set, but does not override any of the basic exception functionality.","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"83fbee74720e224929338d1e577c382c48e8f6bf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            dnspython_zone \u003d dnsutils.do_axfr(zone.name, servers,"},{"line_number":41,"context_line":"                                              timeout\u003dtimeout)"},{"line_number":42,"context_line":"        except exceptions.XFRFailure as e:"},{"line_number":43,"context_line":"            LOG.warning(e.error_message)"},{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        zone.update(dnsutils.from_dnspython_zone(dnspython_zone))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_a6f6dd8e","line":43,"in_reply_to":"5f201791_ac180a81","updated":"2017-06-22 03:25:19.000000000","message":"There are 2 reasons for this decision:\n1) e.message should be replaced with a message instead of an object. \n2) We have custom exception in Designate (error_message)","commit_id":"37cfdcf1af2a5c37aa4c1ca44ad66c4e0c696cef"}],"designate/objects/base.py":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"e7e5746324aeaf749d68c3d225e88423e7c998b2","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            e.path \u003d [\u0027type\u0027]"},{"line_number":326,"context_line":"            e.validator \u003d \u0027required\u0027"},{"line_number":327,"context_line":"            e.validator_value \u003d [e.relation]"},{"line_number":328,"context_line":"            e \u003d \"\u0027%s\u0027 is a required property\" % e.relation"},{"line_number":329,"context_line":"            errors.append(e)"},{"line_number":330,"context_line":"            raise exceptions.InvalidObject("},{"line_number":331,"context_line":"                \"Provided object does not match \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_4c44f81b","line":328,"updated":"2017-06-20 03:14:59.000000000","message":"the same thing!","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e146e7865ac6e6ec646cd818edbaebf5538e4ded","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            e.path \u003d [\u0027type\u0027]"},{"line_number":326,"context_line":"            e.validator \u003d \u0027required\u0027"},{"line_number":327,"context_line":"            e.validator_value \u003d [e.relation]"},{"line_number":328,"context_line":"            e \u003d \"\u0027%s\u0027 is a required property\" % e.relation"},{"line_number":329,"context_line":"            errors.append(e)"},{"line_number":330,"context_line":"            raise exceptions.InvalidObject("},{"line_number":331,"context_line":"                \"Provided object does not match \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_6cb0d4de","line":328,"in_reply_to":"7f231b9d_4c44f81b","updated":"2017-06-20 03:28:23.000000000","message":"Done","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"}],"designate/objects/recordset.py":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"e7e5746324aeaf749d68c3d225e88423e7c998b2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":214,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":215,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":216,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":217,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":218,"context_line":"                # Add it to the list for later"},{"line_number":219,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_8cd57046","line":216,"updated":"2017-06-20 03:14:59.000000000","message":"This is format of ValidationError object in designate, so no need to change.","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e146e7865ac6e6ec646cd818edbaebf5538e4ded","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":214,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":215,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":216,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":217,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":218,"context_line":"                # Add it to the list for later"},{"line_number":219,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_4cb518cd","line":216,"in_reply_to":"7f231b9d_8cd57046","updated":"2017-06-20 03:28:23.000000000","message":"Done","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"e7e5746324aeaf749d68c3d225e88423e7c998b2","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":225,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":226,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":227,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":228,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":229,"context_line":"                # Add it to the list for later"},{"line_number":230,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_6cca14a2","line":227,"updated":"2017-06-20 03:14:59.000000000","message":"ditto","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e146e7865ac6e6ec646cd818edbaebf5538e4ded","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":225,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":226,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":227,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":228,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":229,"context_line":"                # Add it to the list for later"},{"line_number":230,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_2ccadc4e","line":227,"in_reply_to":"7f231b9d_6cca14a2","updated":"2017-06-20 03:28:23.000000000","message":"Done","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"e7e5746324aeaf749d68c3d225e88423e7c998b2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":236,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":237,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":238,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":239,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":240,"context_line":"                # Add it to the list for later"},{"line_number":241,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_2cc41c92","line":238,"updated":"2017-06-20 03:14:59.000000000","message":"ditto","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e146e7865ac6e6ec646cd818edbaebf5538e4ded","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                e.path \u003d [\u0027records\u0027, i]"},{"line_number":236,"context_line":"                e.validator \u003d \u0027format\u0027"},{"line_number":237,"context_line":"                e.validator_value \u003d [self.type]"},{"line_number":238,"context_line":"                e \u003d (\"\u0027%(data)s\u0027 is not a \u0027%(type)s\u0027 Record\""},{"line_number":239,"context_line":"                     % {\u0027data\u0027: record.data, \u0027type\u0027: self.type})"},{"line_number":240,"context_line":"                # Add it to the list for later"},{"line_number":241,"context_line":"                errors.append(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_0cc72048","line":238,"in_reply_to":"7f231b9d_2cc41c92","updated":"2017-06-20 03:28:23.000000000","message":"Done","commit_id":"0c343eaf88edbadf83e132b1cafbf06696d87d56"}]}