)]}'
{"designate/__init__.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83182f60c1f63170a253691a5c23053e4d66bc92","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"designate_opts \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dsocket.gethostname(),"},{"line_number":32,"context_line":"               sample_default\u003d\u0027\u003cHostname\u003e\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Name of this node\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_2505b614","line":32,"updated":"2017-12-07 06:13:16.000000000","message":"Can we please stick to lowercase here?","commit_id":"d0aed5f9aa875917aff635bc6016bf3c8eceb74e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4da089389c4f677347fc08c3f7da22ec6dffc899","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"designate_opts \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dsocket.gethostname(),"},{"line_number":32,"context_line":"               sample_default\u003d\u0027\u003cHostname\u003e\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Name of this node\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_02cf3ab0","line":32,"in_reply_to":"df87a7cf_007d007e","updated":"2017-12-07 15:09:13.000000000","message":"++ - consistency would be good for this","commit_id":"d0aed5f9aa875917aff635bc6016bf3c8eceb74e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"54dd730fe86ca17bf13f4c69358a9dc0de35df6e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"designate_opts \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dsocket.gethostname(),"},{"line_number":32,"context_line":"               sample_default\u003d\u0027\u003cHostname\u003e\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Name of this node\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_007d007e","line":32,"in_reply_to":"df87a7cf_2505b614","updated":"2017-12-07 06:19:07.000000000","message":"Actually I just found that nova uses \"current_hostname\", I guess it makes sense to stick to that, a) for consistency and b) because it describes the default a bit better.","commit_id":"d0aed5f9aa875917aff635bc6016bf3c8eceb74e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83182f60c1f63170a253691a5c23053e4d66bc92","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               help\u003d\u0027Name of this node\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027pybasedir\u0027,"},{"line_number":36,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":37,"context_line":"                                             \u0027../\u0027)),"},{"line_number":38,"context_line":"        help\u003d\u0027Directory where the designate python module is installed\u0027"},{"line_number":39,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_e0001c04","line":36,"updated":"2017-12-07 06:13:16.000000000","message":"This also includes the build path for me, wouldn\u0027t that need fixing, too?","commit_id":"d0aed5f9aa875917aff635bc6016bf3c8eceb74e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4da089389c4f677347fc08c3f7da22ec6dffc899","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               help\u003d\u0027Name of this node\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("},{"line_number":35,"context_line":"        \u0027pybasedir\u0027,"},{"line_number":36,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":37,"context_line":"                                             \u0027../\u0027)),"},{"line_number":38,"context_line":"        help\u003d\u0027Directory where the designate python module is installed\u0027"},{"line_number":39,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_42d9c27c","line":36,"in_reply_to":"df87a7cf_e0001c04","updated":"2017-12-07 15:09:13.000000000","message":"I *think* this is the same across builders, so it will not cause a non reproducible build, where the hostname will change depending on the builder","commit_id":"d0aed5f9aa875917aff635bc6016bf3c8eceb74e"}]}