)]}'
{"designate/scheduler/filters/attribute_filter.py":[{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"8450c811fcc5f80ce917562ac7bc7d88bb3f0f29","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            except exceptions.RelationNotLoaded:"},{"line_number":70,"context_line":"                pool_attributes \u003d {}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            try:"},{"line_number":73,"context_line":"                # Remove the \"pool_id\" attribute, that is used in"},{"line_number":74,"context_line":"                # PoolIDAttributeFilter"},{"line_number":75,"context_line":"                pool_attributes.pop(\u0027pool_id\u0027)"},{"line_number":76,"context_line":"            except KeyError:"},{"line_number":77,"context_line":"                # If the item is not in the dict, it is fine, continue"},{"line_number":78,"context_line":"                pass"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            if pool_attributes \u003d\u003d {}:"},{"line_number":81,"context_line":"                # If we did not send any attribute to filter on, we should"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9fb5a580","line":78,"range":{"start_line":72,"start_character":0,"end_line":78,"end_character":20},"updated":"2018-02-23 15:45:53.000000000","message":"Perhaps simply pool_attributes.pop(\u0027pool_id\u0027, None) and no try-except clause?","commit_id":"3246e36371bbdf3a02ca4270fec764b9c5b94daf"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"5cad95e6322ef0506e22daecc3c3afe0fad1df55","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            except exceptions.RelationNotLoaded:"},{"line_number":70,"context_line":"                pool_attributes \u003d {}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            try:"},{"line_number":73,"context_line":"                # Remove the \"pool_id\" attribute, that is used in"},{"line_number":74,"context_line":"                # PoolIDAttributeFilter"},{"line_number":75,"context_line":"                pool_attributes.pop(\u0027pool_id\u0027)"},{"line_number":76,"context_line":"            except KeyError:"},{"line_number":77,"context_line":"                # If the item is not in the dict, it is fine, continue"},{"line_number":78,"context_line":"                pass"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            if pool_attributes \u003d\u003d {}:"},{"line_number":81,"context_line":"                # If we did not send any attribute to filter on, we should"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_23af1a95","line":78,"range":{"start_line":72,"start_character":0,"end_line":78,"end_character":20},"in_reply_to":"3fa0c359_9fb5a580","updated":"2018-03-11 17:55:28.000000000","message":"Yup - that is better - will update it now.","commit_id":"3246e36371bbdf3a02ca4270fec764b9c5b94daf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab09dc3754f274f131e79bcb21bb7069dd5aa8fe","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            except exceptions.RelationNotLoaded:"},{"line_number":70,"context_line":"                pool_attributes \u003d {}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            pool_attributes.pop(\u0027pool_id\u0027, None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            if pool_attributes \u003d\u003d {}:"},{"line_number":75,"context_line":"                # If we did not send any attribute to filter on, we should"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_f1656ce2","line":72,"updated":"2018-03-11 20:41:06.000000000","message":"I think it would still be worthwhile to keep a comment about why this is done.","commit_id":"91f9de5c952c2814112865ebbb019122334b5c96"}]}