)]}'
{"designate/worker/tasks/zone.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d19dd14fc40eee65642612e12fbed89962e674a","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _validate_action(self, action):"},{"line_number":164,"context_line":"        if action not in [\u0027CREATE\u0027, \u0027UPDATE\u0027, \u0027DELETE\u0027]:"},{"line_number":165,"context_line":"            raise exceptions.BadAction(\u0027Unexpected action: %s\u0027 % action)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _execute(self):"},{"line_number":168,"context_line":"        results \u003d self.executor.run(["}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_12b5c731","line":165,"updated":"2018-08-06 15:38:15.000000000","message":"If we only want a warning logged instead of an exception thrown, why can\u0027t we do this right here and now?","commit_id":"44b64c317c1e3f9ac67bfbd1c85d25d8abbdd677"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9c4cec05f3e56cae48fa157793228969359e1c98","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _validate_action(self, action):"},{"line_number":164,"context_line":"        if action not in [\u0027CREATE\u0027, \u0027UPDATE\u0027, \u0027DELETE\u0027]:"},{"line_number":165,"context_line":"            raise exceptions.BadAction(\u0027Unexpected action: %s\u0027 % action)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _execute(self):"},{"line_number":168,"context_line":"        results \u003d self.executor.run(["}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_121e27ba","line":165,"in_reply_to":"3f79a3b5_12b5c731","updated":"2018-08-06 16:10:02.000000000","message":"We could, but the assumption is that this should interrupt the workflow. So at the very least we would need to change this to return a boolean.","commit_id":"44b64c317c1e3f9ac67bfbd1c85d25d8abbdd677"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e9a44ab7c7f114cb2a7bcdcbf15087e112573914","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _threshold_met(self, results):"},{"line_number":179,"context_line":"        # If we don\u0027t meet threshold for action, update status"},{"line_number":180,"context_line":"        met_action_threshold \u003d self._compare_threshold("},{"line_number":181,"context_line":"            results.count(True), len(results))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if not met_action_threshold:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2fd0abf7","line":180,"updated":"2018-08-06 05:53:41.000000000","message":"We are appending a None value to the list, which will be evaluated the same as False (well anything but True :p)","commit_id":"44b64c317c1e3f9ac67bfbd1c85d25d8abbdd677"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e9a44ab7c7f114cb2a7bcdcbf15087e112573914","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        met_action_threshold \u003d self._compare_threshold("},{"line_number":181,"context_line":"            results.count(True), len(results))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if not met_action_threshold:"},{"line_number":184,"context_line":"            LOG.info(\u0027Could not %(action)s %(zone)s on enough targets. \u0027"},{"line_number":185,"context_line":"                     \u0027Updating status to ERROR\u0027,"},{"line_number":186,"context_line":"                     {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6fe6a3eb","line":183,"updated":"2018-08-06 05:53:41.000000000","message":"We may hit this instead, as we previously completely halted the execution.","commit_id":"44b64c317c1e3f9ac67bfbd1c85d25d8abbdd677"}]}