)]}'
{"designate/backend/impl_pdns4.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9126a4d2a89cad2350b4158b2a74df4b728a0e96","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                LOG.debug(\"%(zone)s was created with an error. Deleting zone\")"},{"line_number":79,"context_line":"                raise exceptions.Backend(e)"},{"line_number":80,"context_line":"            else:"},{"line_number":81,"context_line":"                self.delete_zone(context, zone)"},{"line_number":82,"context_line":"                raise exceptions.Backend(e)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_zone(self, context, zone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_49cd492f","line":81,"updated":"2019-03-14 21:07:20.000000000","message":"Nit: Could be worth just wrapping a try catch delete and log an error, and then raise the error on 82. Not sure if it would be confusing if the delete failed and we raised a delete error on create, or maybe it\u0027s obvious based on the traceback.","commit_id":"83bea3b81861922cef2fe38b04bbc118e05bfbff"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"354168bd87842bf32825b72e6ac64a02de263adb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                LOG.debug(\"%(zone)s was created with an error. Deleting zone\")"},{"line_number":79,"context_line":"                raise exceptions.Backend(e)"},{"line_number":80,"context_line":"            else:"},{"line_number":81,"context_line":"                self.delete_zone(context, zone)"},{"line_number":82,"context_line":"                raise exceptions.Backend(e)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_zone(self, context, zone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c33cace2","line":81,"updated":"2019-03-15 12:55:55.000000000","message":"Yeah - I think it is actually worth pulling this out into a sepaate patch - Will do that naw","commit_id":"83bea3b81861922cef2fe38b04bbc118e05bfbff"}],"doc/source/admin/backends/sample_yaml_snippets/pdns4.yaml":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9126a4d2a89cad2350b4158b2a74df4b728a0e96","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        api_endpoint: http://127.0.0.1:8081"},{"line_number":16,"context_line":"        api_token: changeme"},{"line_number":17,"context_line":"        # If a tsigkey is needed, insert it here"},{"line_number":18,"context_line":"        tsigkey_id: \u003ckeyname\u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_a9ddcde0","line":18,"updated":"2019-03-14 21:07:20.000000000","message":"Maybe just leave this commented out?\n\u003e tsigkey_id: changeme","commit_id":"83bea3b81861922cef2fe38b04bbc118e05bfbff"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"354168bd87842bf32825b72e6ac64a02de263adb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        api_endpoint: http://127.0.0.1:8081"},{"line_number":16,"context_line":"        api_token: changeme"},{"line_number":17,"context_line":"        # If a tsigkey is needed, insert it here"},{"line_number":18,"context_line":"        tsigkey_id: \u003ckeyname\u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_6327f8cb","line":18,"updated":"2019-03-15 12:55:55.000000000","message":"Yeah, I will comment it out, but the \u003ckeyname\u003e is referenced in the docs later on.","commit_id":"83bea3b81861922cef2fe38b04bbc118e05bfbff"}],"releasenotes/notes/pdns4-tsig-1fda534c01d90138.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d0d343c5e6343b2fbb4c4791a472b15282d4f4ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new option for pools using the ``pdns4`` backend - ``tsigkey_id``"},{"line_number":5,"context_line":"    This allows deployers to specify a tsig key that is installed in powerdns"},{"line_number":6,"context_line":"    to use for AFXR requests. This key id is name used to create the key in"},{"line_number":7,"context_line":"    powerdns, not the Designate UUID based ID for the key."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_1705a57a","line":4,"updated":"2019-03-21 09:41:27.000000000","message":"The \" - \" looks confusing in the rendered text, maybe use \": \" instead. Also missing a \".\" at the end of the sentence.","commit_id":"4fe4c521041da931ecc638ff995ce3885f8540e3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d0d343c5e6343b2fbb4c4791a472b15282d4f4ba","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new option for pools using the ``pdns4`` backend - ``tsigkey_id``"},{"line_number":5,"context_line":"    This allows deployers to specify a tsig key that is installed in powerdns"},{"line_number":6,"context_line":"    to use for AFXR requests. This key id is name used to create the key in"},{"line_number":7,"context_line":"    powerdns, not the Designate UUID based ID for the key."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. note:: This is only availible in the 4.2.x versions (and above) of pdns."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_57c80d73","line":6,"updated":"2019-03-21 09:41:27.000000000","message":"\"... is _the_ name ...\"\n\nAlso maybe call the option \"tsigkey_name\" then, to make this clearer?","commit_id":"4fe4c521041da931ecc638ff995ce3885f8540e3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d0d343c5e6343b2fbb4c4791a472b15282d4f4ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to use for AFXR requests. This key id is name used to create the key in"},{"line_number":7,"context_line":"    powerdns, not the Designate UUID based ID for the key."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. note:: This is only availible in the 4.2.x versions (and above) of pdns."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_77c5095b","line":9,"updated":"2019-03-21 09:41:27.000000000","message":"available","commit_id":"4fe4c521041da931ecc638ff995ce3885f8540e3"}]}
