)]}'
{"designate/backend/impl_pdns4.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4325d18990864f2cfa8929a53a784796b3d003e8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self._build_url(zone\u003dzone.name),"},{"line_number":51,"context_line":"            headers\u003dself.headers,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        if zone.status_code is not 200:"},{"line_number":54,"context_line":"            return False"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7c55ee1c","line":53,"updated":"2019-03-21 09:21:11.000000000","message":"Nit: Why not drop the \"not\" and switch the True/False below? Less complicated is better IMO.","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"fadfba11575d46ad4d53e664e33b30b1b17c9f8e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self._build_url(zone\u003dzone.name),"},{"line_number":51,"context_line":"            headers\u003dself.headers,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        if zone.status_code is not 200:"},{"line_number":54,"context_line":"            return False"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_024f93bd","line":53,"in_reply_to":"5fc1f717_7c55ee1c","updated":"2019-03-21 19:27:59.000000000","message":"yup - will do that now","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"11fa1601562e7298b1b0b15683b02f32132c4867","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._check_zone_exists(zone):"},{"line_number":72,"context_line":"            LOG.info("},{"line_number":73,"context_line":"                \u0027%s exists on the server. Deleting zone before creation\u0027 % zone"},{"line_number":74,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d93759e3","line":71,"updated":"2019-03-20 21:46:27.000000000","message":"I don\u0027t think it\u0027s common to delete an existing zone before creating the same zone?","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"fadfba11575d46ad4d53e664e33b30b1b17c9f8e","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._check_zone_exists(zone):"},{"line_number":72,"context_line":"            LOG.info("},{"line_number":73,"context_line":"                \u0027%s exists on the server. Deleting zone before creation\u0027 % zone"},{"line_number":74,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_3de67218","line":71,"in_reply_to":"5fc1f717_d93759e3","updated":"2019-03-21 19:27:59.000000000","message":"In our other drivers we just assume that it is set up correctly ... maybe we should do that ....","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4325d18990864f2cfa8929a53a784796b3d003e8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                self.delete_zone(context, zone)"},{"line_number":78,"context_line":"            except exceptions.Backend:"},{"line_number":79,"context_line":"                LOG.error(\u0027Could not delete pre-existing zone %s\u0027 % zone)"},{"line_number":80,"context_line":"                return"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            requests.post("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b73cd1bf","line":80,"updated":"2019-03-21 09:21:11.000000000","message":"Hmm, I\u0027m not convinced that simply returning without raising an error is really the correct response here, can you explain why you\u0027d do that?","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"fadfba11575d46ad4d53e664e33b30b1b17c9f8e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                self.delete_zone(context, zone)"},{"line_number":78,"context_line":"            except exceptions.Backend:"},{"line_number":79,"context_line":"                LOG.error(\u0027Could not delete pre-existing zone %s\u0027 % zone)"},{"line_number":80,"context_line":"                return"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            requests.post("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5de1fefb","line":80,"in_reply_to":"5fc1f717_b73cd1bf","updated":"2019-03-21 19:27:59.000000000","message":"because I typed return instead fo raise -_-","commit_id":"9e2c13cf020fbd79d0e2a4a65c5037b5a7dcc810"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"86484627fc5df56c3701823b3a7cac2ea1b20f1f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self._build_url(zone\u003dzone.name),"},{"line_number":51,"context_line":"            headers\u003dself.headers,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        return zone.status_code is 200"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def create_zone(self, context, zone):"},{"line_number":56,"context_line":"        \"\"\"Create a DNS zone\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_df42b8ab","line":53,"updated":"2019-03-22 09:21:38.000000000","message":"Hah, that\u0027s even better than my idea, marvelous :-)","commit_id":"02b974756657f09091d5afbcf94e9712a95694cf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c2d8fa6e7e9329de0ac01be9bf90f28defb4378e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    LOG.error(\u0027Could not delete errored zone %s\u0027 % zone)"},{"line_number":94,"context_line":"            raise exceptions.Backend(e)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.mdns_api.notify_zone_changed("},{"line_number":97,"context_line":"            context, zone, self._host, self._port, self.timeout,"},{"line_number":98,"context_line":"            self.retry_interval, self.max_retries, self.delay)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def delete_zone(self, context, zone):"},{"line_number":101,"context_line":"        \"\"\"Delete a DNS zone\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_41802747","line":98,"range":{"start_line":96,"start_character":8,"end_line":98,"end_character":62},"updated":"2019-03-25 09:46:17.000000000","message":"Error: \u0027PDNS4Backend\u0027 object has no attribute \u0027_host\u0027.","commit_id":"4931f86b866251b0ebe2596b75e2c6e7d0d75ac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"917142c41b08da139f82bae75f630719129b7442","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"        if self.tsigkey_name:"},{"line_number":69,"context_line":"            data[\u0027slave_tsig_key_ids\u0027] \u003d [self.tsigkey_name]"},{"line_number":70,"context_line":"        headers \u003d {"},{"line_number":71,"context_line":"            \"X-API-Key\": self.api_token"},{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if self._check_zone_exists(zone):"},{"line_number":75,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_a8f26e99","line":72,"range":{"start_line":70,"start_character":8,"end_line":72,"end_character":9},"updated":"2019-05-03 01:48:39.000000000","message":"Seems this isn\u0027t needed anymore now, causing pep8 failure.","commit_id":"a3a17532b9333fb843223104d976a5f37f7c6024"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"918cbee6984c588f52ea4fd21c5dd807346d2f07","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._check_zone_exists(zone):"},{"line_number":72,"context_line":"            LOG.info("},{"line_number":73,"context_line":"                \u0027%s exists on the server. Deleting zone before creation\u0027 % zone"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_c441660d","line":73,"updated":"2019-05-09 23:38:19.000000000","message":"And here.","commit_id":"9512ef19800532d6d2f2195c76abf5d85de4857c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"918cbee6984c588f52ea4fd21c5dd807346d2f07","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            try:"},{"line_number":77,"context_line":"                self.delete_zone(context, zone)"},{"line_number":78,"context_line":"            except exceptions.Backend:"},{"line_number":79,"context_line":"                LOG.error(\u0027Could not delete pre-existing zone %s\u0027 % zone)"},{"line_number":80,"context_line":"                raise"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_44c0167c","line":79,"updated":"2019-05-09 23:38:19.000000000","message":"Nit: Should be lazy-loaded\n\u003e LOG.error(\u0027Could not delete pre-existing zone %s\u0027, zone)\nNit: Maybe this should be zone.name? see unit-tests","commit_id":"9512ef19800532d6d2f2195c76abf5d85de4857c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"918cbee6984c588f52ea4fd21c5dd807346d2f07","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            # check if the zone was actually created - even with errors pdns"},{"line_number":90,"context_line":"            # will create the zone sometimes"},{"line_number":91,"context_line":"            if self._check_zone_exists(zone):"},{"line_number":92,"context_line":"                LOG.info(\"%s was created with an error. Deleting zone\" % zone)"},{"line_number":93,"context_line":"                try:"},{"line_number":94,"context_line":"                    self.delete_zone(context, zone)"},{"line_number":95,"context_line":"                except exceptions.Backend:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_64bbda0d","line":92,"updated":"2019-05-09 23:38:19.000000000","message":"Same here should be lazy loaded","commit_id":"9512ef19800532d6d2f2195c76abf5d85de4857c"}]}