)]}'
{"id":"openstack%2Fdesignate~647609","triplet_id":"openstack%2Fdesignate~stable%2Frocky~Ibb4fb604957286c6edfe85f72321f199eb3167a7","project":"openstack/designate","branch":"stable/rocky","topic":"bug/1820089","hashtags":[],"change_id":"Ibb4fb604957286c6edfe85f72321f199eb3167a7","subject":"Allow pdns4 backend to select tsigkey","status":"MERGED","created":"2019-03-25 21:10:48.000000000","updated":"2019-05-21 14:14:53.000000000","submitted":"2019-05-21 14:14:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"647609-1558448093578-795c03e7","meta_rev_id":"279165d10b7ce4405a4aff085d57f8dbe3c68f2f","_number":647609,"virtual_id_number":647609,"owner":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"date":"2019-03-28 12:52:56.000000000","_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},{"value":0,"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},{"value":2,"date":"2019-05-21 14:14:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-05-21 13:08:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},{"value":1,"date":"2019-03-25 21:11:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-03-26 20:37:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":1,"date":"2019-05-21 13:08:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},{"value":0,"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},{"value":0,"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},{"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-25 21:11:37.000000000","updated_by":{"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},"reviewer":{"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},"state":"REVIEWER"},{"updated":"2019-03-26 20:37:34.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-05-21 13:08:26.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-05-21 14:14:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6e814076ea2ee88f2ac74ee94c81ec359f4c8a0a","author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"date":"2019-03-25 21:10:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f7b1175c0151ed940a28b30f5a32f06b71749aa","author":{"_account_id":21032,"name":"Farid Da Encarnacao","email":"farid.daencarnacao@ormuco.com","username":"haplo37"},"date":"2019-03-25 21:11:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b473a34201d0f5fc6e05638bcab81ed3226a108e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-25 22:09:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- designate-bind9 http://logs.openstack.org/09/647609/1/check/designate-bind9/b33bd58/ : SUCCESS in 45m 00s\n- designate-bind9-manager-model http://logs.openstack.org/09/647609/1/check/designate-bind9-manager-model/524e485/ : FAILURE in 43m 10s\n- designate-bind9-py35 http://logs.openstack.org/09/647609/1/check/designate-bind9-py35/320e520/ : SUCCESS in 36m 03s\n- designate-bind9-py36 http://logs.openstack.org/09/647609/1/check/designate-bind9-py36/7826eba/ : FAILURE in 40m 37s\n- designate-devstack-pdns4 http://logs.openstack.org/09/647609/1/check/designate-devstack-pdns4/f508125/ : SUCCESS in 38m 30s\n- designate-devstack-pdns4-postgres http://logs.openstack.org/09/647609/1/check/designate-devstack-pdns4-postgres/c7a0855/ : SUCCESS in 37m 04s\n- designate-grenade-pdns4 http://logs.openstack.org/09/647609/1/check/designate-grenade-pdns4/b3173a8/ : SUCCESS in 54m 11s\n- openstack-tox-py36 http://logs.openstack.org/09/647609/1/check/openstack-tox-py36/c7c48a2/ : SUCCESS in 6m 32s\n- openstack-tox-pep8 http://logs.openstack.org/09/647609/1/check/openstack-tox-pep8/3dbeada/ : SUCCESS in 5m 10s\n- openstack-tox-py27 http://logs.openstack.org/09/647609/1/check/openstack-tox-py27/303809f/ : SUCCESS in 6m 52s\n- openstack-tox-py35 http://logs.openstack.org/09/647609/1/check/openstack-tox-py35/51d4a8f/ : SUCCESS in 6m 46s\n- build-openstack-sphinx-docs http://logs.openstack.org/09/647609/1/check/build-openstack-sphinx-docs/fddb0e3/html/ : SUCCESS in 5m 17s\n- build-openstack-releasenotes http://logs.openstack.org/09/647609/1/check/build-openstack-releasenotes/9c14f1f/html/ : SUCCESS in 6m 10s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/09/647609/1/check/neutron-tempest-plugin-designate-scenario/58bfdb4/ : SUCCESS in 31m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/09/647609/1/check/openstack-tox-lower-constraints/aa18088/ : SUCCESS in 5m 50s\n- openstack-tox-cover http://logs.openstack.org/09/647609/1/check/openstack-tox-cover/ad5b079/cover/ : SUCCESS in 7m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ca158c402151e02dc8e7350b79748067fc8a49c9","author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"date":"2019-03-25 23:40:04.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"805ff45ff73e5e4a3586dfa9abbe8a3e6f368563","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 00:41:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/09/647609/1/check/designate-bind9/90c02f0/ : SUCCESS in 35m 21s\n- designate-bind9-manager-model http://logs.openstack.org/09/647609/1/check/designate-bind9-manager-model/72d1116/ : SUCCESS in 41m 25s\n- designate-bind9-py35 http://logs.openstack.org/09/647609/1/check/designate-bind9-py35/0b99bd6/ : SUCCESS in 38m 01s\n- designate-bind9-py36 http://logs.openstack.org/09/647609/1/check/designate-bind9-py36/eb49c49/ : SUCCESS in 43m 18s\n- designate-devstack-pdns4 http://logs.openstack.org/09/647609/1/check/designate-devstack-pdns4/84c7a87/ : SUCCESS in 34m 58s\n- designate-devstack-pdns4-postgres http://logs.openstack.org/09/647609/1/check/designate-devstack-pdns4-postgres/d54cef7/ : SUCCESS in 40m 28s\n- designate-grenade-pdns4 http://logs.openstack.org/09/647609/1/check/designate-grenade-pdns4/3a564c8/ : SUCCESS in 59m 23s\n- openstack-tox-py36 http://logs.openstack.org/09/647609/1/check/openstack-tox-py36/f9a8d85/ : SUCCESS in 5m 34s\n- openstack-tox-pep8 http://logs.openstack.org/09/647609/1/check/openstack-tox-pep8/faba160/ : SUCCESS in 5m 29s\n- openstack-tox-py27 http://logs.openstack.org/09/647609/1/check/openstack-tox-py27/2d4b348/ : SUCCESS in 4m 57s\n- openstack-tox-py35 http://logs.openstack.org/09/647609/1/check/openstack-tox-py35/5845ef5/ : SUCCESS in 6m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/09/647609/1/check/build-openstack-sphinx-docs/260c3eb/html/ : SUCCESS in 5m 19s\n- build-openstack-releasenotes http://logs.openstack.org/09/647609/1/check/build-openstack-releasenotes/b86ef89/html/ : SUCCESS in 7m 00s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/09/647609/1/check/neutron-tempest-plugin-designate-scenario/694c31e/ : SUCCESS in 32m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/09/647609/1/check/openstack-tox-lower-constraints/57e7b92/ : SUCCESS in 4m 24s\n- openstack-tox-cover http://logs.openstack.org/09/647609/1/check/openstack-tox-cover/11d579e/cover/ : SUCCESS in 6m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c77f306fc3ee6098e0c9ec7ded728a7f5ee86b48","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-03-26 20:37:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cbea9ec3fa9132ef59295ae65d57b0dd85fce318","author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"date":"2019-03-28 12:52:56.000000000","message":"Patch Set 1:\n\none more +2 and we are good to go :)","accounts_in_message":[],"_revision_number":1},{"id":"f2c35df205a255ebaf4c04428fa159a69b7c465f","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-03-28 18:38:46.000000000","message":"Patch Set 1:\n\n\u003e one more +2 and we are good to go :)\n\nIt also needs to be merged in Stein first. :p","accounts_in_message":[],"_revision_number":1},{"id":"3ac5dce05d292ccee9f5be8ebbdd45ef70aa6227","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-20 03:19:11.000000000","message":"Patch Set 1:\n\nup","accounts_in_message":[],"_revision_number":1},{"id":"73cff79dc305e58c92614c8f9dd5b5a67c3dceda","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-05-21 13:08:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"198d34a6dc7f170fa3a73fd1280cccaefc471d9e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 13:08:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3cc34f76d488ea34ab816615de655288de9f2e50","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 14:14:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b4d165f12c31d661536d9e02fd6681c3da30865a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 14:14:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 http://logs.openstack.org/09/647609/1/gate/designate-bind9/5989e30/ : SUCCESS in 40m 53s\n- designate-bind9-manager-model http://logs.openstack.org/09/647609/1/gate/designate-bind9-manager-model/f571235/ : SUCCESS in 43m 52s\n- designate-bind9-py35 http://logs.openstack.org/09/647609/1/gate/designate-bind9-py35/8b17b28/ : SUCCESS in 41m 34s\n- designate-bind9-py36 http://logs.openstack.org/09/647609/1/gate/designate-bind9-py36/8a03454/ : SUCCESS in 38m 09s\n- designate-devstack-pdns4 http://logs.openstack.org/09/647609/1/gate/designate-devstack-pdns4/68c54bb/ : SUCCESS in 34m 04s\n- designate-devstack-pdns4-postgres http://logs.openstack.org/09/647609/1/gate/designate-devstack-pdns4-postgres/48fc7ae/ : SUCCESS in 36m 12s\n- designate-grenade-pdns4 http://logs.openstack.org/09/647609/1/gate/designate-grenade-pdns4/b2c9c37/ : SUCCESS in 59m 23s\n- openstack-tox-py36 http://logs.openstack.org/09/647609/1/gate/openstack-tox-py36/e1007ab/ : SUCCESS in 5m 33s\n- openstack-tox-pep8 http://logs.openstack.org/09/647609/1/gate/openstack-tox-pep8/1f3e446/ : SUCCESS in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/09/647609/1/gate/openstack-tox-py27/e3fdf2b/ : SUCCESS in 5m 43s\n- openstack-tox-py35 http://logs.openstack.org/09/647609/1/gate/openstack-tox-py35/5fbd1fc/ : SUCCESS in 5m 36s\n- build-openstack-sphinx-docs http://logs.openstack.org/09/647609/1/gate/build-openstack-sphinx-docs/ef8e34d/html/ : SUCCESS in 4m 48s\n- build-openstack-releasenotes http://logs.openstack.org/09/647609/1/gate/build-openstack-releasenotes/d49cbb0/html/ : SUCCESS in 7m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/09/647609/1/gate/openstack-tox-lower-constraints/c1f839e/ : SUCCESS in 5m 38s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"af59fd0d978c63973d3cf13afbcefe722592772d","revisions":{"af59fd0d978c63973d3cf13afbcefe722592772d":{"kind":"REWORK","_number":1,"created":"2019-03-25 21:10:48.000000000","uploader":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"ref":"refs/changes/09/647609/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/09/647609/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/647609/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/647609/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/647609/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/09/647609/1"}}},"commit":{"parents":[{"commit":"c98329940bf9f059ad26c441064e21fccce8cf1c","subject":"Replace openstack.org git:// URLs with https://","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/c98329940bf9f059ad26c441064e21fccce8cf1c"}]}],"author":{"name":"Graham Hayes","email":"gr@ham.ie","date":"2019-03-14 16:36:46.000000000","tz":0},"committer":{"name":"Gaëtan Trellu","email":"gaetan.trellu@incloudus.com","date":"2019-03-25 21:10:47.000000000","tz":-240},"subject":"Allow pdns4 backend to select tsigkey","message":"Allow pdns4 backend to select tsigkey\n\nAllow a new config item in pools.yaml to set the pdns tsigkey to use for\nAFXR queries.\n\nChange-Id: Ibb4fb604957286c6edfe85f72321f199eb3167a7\nCloses-Bug: #1820089\nSigned-off-by: Graham Hayes \u003cgr@ham.ie\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/af59fd0d978c63973d3cf13afbcefe722592772d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/af59fd0d978c63973d3cf13afbcefe722592772d"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}