)]}'
{"designate/api/v2/controllers/blacklist.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Betsy Luzader \u003cbetsy.luzader@rackspace.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FjcA%3D","line":1,"updated":"2014-01-11 14:33:59.000000000","message":"Minor - fix this only if something else needs to change.\nNow that it is 2014 - this can be updated.","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Betsy Luzader \u003cbetsy.luzader@rackspace.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fi8g%3D","line":1,"in_reply_to":"AAAAUH%2F%2FjcA%3D","updated":"2014-01-13 05:41:11.000000000","message":"Done","commit_id":"68450a642a62de04c4ffef276867c73988d31801"}],"designate/api/v2/controllers/root.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"44ec4a750224e9813587415d3332b90706c041cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    limits \u003d limits.LimitsController()"},{"line_number":31,"context_line":"    schemas \u003d schemas.SchemasController()"},{"line_number":32,"context_line":"    zones \u003d zones.ZonesController()"},{"line_number":33,"context_line":"    blacklist \u003d blacklist.BlacklistController()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FdEo%3D","line":33,"updated":"2014-01-13 18:40:02.000000000","message":"this should be plural (aka blacklists - same for the classname)","commit_id":"d450e5cc5e6dcdc654e344751b09c4a611ce1b0d"}],"designate/api/v2/views/blacklist.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"44ec4a750224e9813587415d3332b90706c041cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    _resource_name \u003d \u0027blacklist\u0027"},{"line_number":28,"context_line":"    _collection_name \u003d \u0027blacklists\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def detail(self, context, request, blacklist):"},{"line_number":31,"context_line":"        \"\"\" Detailed view of a blacklisted zone \"\"\""},{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"blacklist\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FdEA%3D","line":30,"updated":"2014-01-13 18:40:02.000000000","message":"this needs to change from detail() to basic() (due to https://review.openstack.org/66237 - merged this morning)","commit_id":"d450e5cc5e6dcdc654e344751b09c4a611ce1b0d"}],"designate/api/v2/views/blacklists.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b6010a3187e7041f31e2a490b4eb46eb6529b30d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"            \"blacklist\": {"},{"line_number":34,"context_line":"                \"id\": blacklist[\u0027id\u0027],"},{"line_number":35,"context_line":"                \"name\": blacklist[\u0027name\u0027],"},{"line_number":36,"context_line":"                \"description\": blacklist[\u0027description\u0027],"},{"line_number":37,"context_line":"                \"created_at\": blacklist[\u0027created_at\u0027],"},{"line_number":38,"context_line":"                \"updated_at\": blacklist[\u0027updated_at\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Bbog%3D","line":35,"updated":"2014-01-26 19:56:19.000000000","message":"Since we have moved to regexs for this field, this should be renamed \u0027pattern\u0027 - currently if you add google, it will block google.hayes.ie. being created - while \\.google\\.com\\.$ would stop sub domains.","commit_id":"1d0a7dc606a7438d71fcb071f11ad6ce2438434c"}],"designate/central/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    #            default\u003d[\u0027\\\\.arpa\\\\.$\u0027, \u0027\\\\.novalocal\\\\.$\u0027,"},{"line_number":33,"context_line":"    #                     \u0027\\\\.localhost\\\\.$\u0027,"},{"line_number":34,"context_line":"    #                     \u0027\\\\.localdomain\\\\.$\u0027, \u0027\\\\.local\\\\.$\u0027],"},{"line_number":35,"context_line":"    #            help\u003d\u0027DNS domain name blacklist\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027accepted-tlds-file\u0027, default\u003d\u0027tlds-alpha-by-domain.txt\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Accepted TLDs\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027effective-tlds-file\u0027, default\u003d\u0027effective_tld_names.dat\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FyuU%3D","line":35,"updated":"2014-01-08 12:19:02.000000000","message":"Can we remove these commented out lines :)","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e8da8fce26e446eff51711bd32c4afe221534036","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027accepted-tlds-file\u0027, default\u003d\u0027tlds-alpha-by-domain.txt\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027Accepted TLDs\u0027),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027effective-tlds-file\u0027, default\u003d\u0027effective_tld_names.dat\u0027,"},{"line_number":34,"context_line":"               help\u003d\u0027Effective TLDs\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027max_domain_name_len\u0027, default\u003d255,"},{"line_number":36,"context_line":"               help\u003d\"Maximum domain name length\"),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027max_recordset_name_len\u0027, default\u003d255,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BoBk%3D","line":34,"updated":"2014-01-23 19:34:18.000000000","message":"I had removed these in my previous change.  Could you delete these lines from your change?","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"98acea6597f4a21d168ccdd8091a249886bf5e8e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027accepted-tlds-file\u0027, default\u003d\u0027tlds-alpha-by-domain.txt\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027Accepted TLDs\u0027),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027effective-tlds-file\u0027, default\u003d\u0027effective_tld_names.dat\u0027,"},{"line_number":34,"context_line":"               help\u003d\u0027Effective TLDs\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027max_domain_name_len\u0027, default\u003d255,"},{"line_number":36,"context_line":"               help\u003d\"Maximum domain name length\"),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027max_recordset_name_len\u0027, default\u003d255,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Bn3w%3D","line":34,"in_reply_to":"AAAAUH%2F%2BoBk%3D","updated":"2014-01-24 16:46:04.000000000","message":"Done","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"}],"designate/central/rpcapi.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        1.3 - Add get_absolute_limits"},{"line_number":33,"context_line":"        2.0 - Renamed most get_resources to find_resources"},{"line_number":34,"context_line":"        2.1 - Add quota methods"},{"line_number":35,"context_line":"        2.2 - Add methods for blacklisted domains"},{"line_number":36,"context_line":"        3.0 - RecordSet Changes"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F1gQ%3D","line":35,"updated":"2014-01-07 21:50:32.000000000","message":"This should be 3.1","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        LOG.info(\"create_blacklist: Calling central\u0027s create_blacklist\")"},{"line_number":361,"context_line":"        msg \u003d self.make_msg(\u0027create_blacklist\u0027, values\u003dvalues)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        return self.call(context, msg)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def get_blacklist(self, context, blacklist_id):"},{"line_number":366,"context_line":"        LOG.info(\"get_blacklist: Calling central\u0027s get_blacklist.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F1fs%3D","line":363,"updated":"2014-01-07 21:50:32.000000000","message":"All the function returns should be of the type\nreturn self.call(context, msg, version\u003d\u00273.1\u0027)","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"44945bf4f6193bee5ed27ceff8d8f53ea39cdf8c","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return self.call(context, msg, version\u003d\u00273.3\u0027)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def find_blacklist(self, context, criterion):"},{"line_number":424,"context_line":"        LOG.info(\"find_blacklist: Calling central\u0027s find_blacklist.\")"},{"line_number":425,"context_line":"        msg \u003d self.make_msg(\u0027find_blacklist\u0027, criterion\u003dcriterion)"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9bL0%3D","line":423,"updated":"2014-02-07 00:42:09.000000000","message":"Optional - In the api (v2/controllers/blacklists.py), find_blacklist is not used, so I assuming this function is not needed.","commit_id":"529bd963e34b9803fc88c1b8661783f6ea7bce0d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ee92a513977054c38a726abcb3162fc9952d3d7a","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return self.call(context, msg, version\u003d\u00273.3\u0027)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def find_blacklist(self, context, criterion):"},{"line_number":424,"context_line":"        LOG.info(\"find_blacklist: Calling central\u0027s find_blacklist.\")"},{"line_number":425,"context_line":"        msg \u003d self.make_msg(\u0027find_blacklist\u0027, criterion\u003dcriterion)"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9Yds%3D","line":423,"in_reply_to":"AAAAUH%2F9bL0%3D","updated":"2014-02-07 10:10:25.000000000","message":"I\u0027d argue that, for consistency, we include all the methods.\n\nThat way, custom tooling layered on top of this can count on the same methods being available via the RPCAPI for everything.","commit_id":"529bd963e34b9803fc88c1b8661783f6ea7bce0d"}],"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        Ensures the provided domain_name is not blacklisted."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        blacklists \u003d cfg.CONF[\u0027service:central\u0027].domain_name_blacklist"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        for blacklist in blacklists:"},{"line_number":175,"context_line":"            if bool(re.search(blacklist, domain_name)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FyuA%3D","line":172,"updated":"2014-01-08 12:19:02.000000000","message":"Can we remove this section of commented code?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        except exceptions.BlacklistNotFound:"},{"line_number":185,"context_line":"            pass"},{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return blacklist"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        return False"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fyt0%3D","line":187,"updated":"2014-01-08 12:19:02.000000000","message":"Should this not simply be `return True`?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        policy.check(\u0027create_blacklist\u0027, context)"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"        #Ensure the blacklisted domain is in correct domain format"},{"line_number":996,"context_line":"        #self._is_valid_domain_name(context, values[\u0027name\u0027])"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        with self.storage_api.create_blacklist(context, values) as blacklist:"},{"line_number":999,"context_line":"            pass  # NOTE: No other systems need updating"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fyto%3D","line":996,"updated":"2014-01-08 12:19:02.000000000","message":"Can we remove these commented lines?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        blacklist \u003d self.storage_api.get_blacklist(context, blacklist_id)"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"        self.notifier.info(context, \u0027blacklist.get\u0027, blacklist)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"        return blacklist"},{"line_number":1013,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FytI%3D","line":1010,"updated":"2014-01-08 12:19:02.000000000","message":"Notifications should only be sent for Create/Update/delete events get / find shouln\u0027t emit an event.","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3497490adf5fa06d33f5147158fcc98121fb973c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        except exceptions.BlacklistNotFound:"},{"line_number":176,"context_line":"            pass"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            return blacklist"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Fq1Y%3D","line":178,"updated":"2014-01-09 20:43:23.000000000","message":"Should this not simply be `return True` rather than the blacklist entry itself, as we\u0027re expecting a True or False ?","commit_id":"910be5943422f9be8569be4157d7845abdabc4c3"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"de17b0edc2bdfae1cea5d422157e6c995011dfe3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        except exceptions.BlacklistNotFound:"},{"line_number":176,"context_line":"            pass"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            return blacklist"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FnDI%3D","line":178,"in_reply_to":"AAAAUH%2F%2Fq1Y%3D","updated":"2014-01-10 14:22:06.000000000","message":"I thought I had changed that. I\u0027ll do it in the next update.","commit_id":"910be5943422f9be8569be4157d7845abdabc4c3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        with self.storage_api.create_blacklist(context, values) as blacklist:"},{"line_number":986,"context_line":"            pass  # NOTE: No other systems need updating"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        self.notifier.info(context, \u0027blacklist.create\u0027, blacklist)"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"        return blacklist"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fja8%3D","line":988,"updated":"2014-01-11 14:33:59.000000000","message":"Other notifications seem to start with a dns.  Would be good to follow the same convention for blacklists too.","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        with self.storage_api.create_blacklist(context, values) as blacklist:"},{"line_number":986,"context_line":"            pass  # NOTE: No other systems need updating"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        self.notifier.info(context, \u0027blacklist.create\u0027, blacklist)"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"        return blacklist"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fi8c%3D","line":988,"in_reply_to":"AAAAUH%2F%2Fja8%3D","updated":"2014-01-13 05:41:11.000000000","message":"Done","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"        return blacklists"},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"    def find_blacklist(self, context, criterion):"},{"line_number":1007,"context_line":"        policy.check(\u0027find_blacklist\u0027, context)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        blacklist \u003d self.storage_api.find_blacklists(context, criterion)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fja4%3D","line":1006,"updated":"2014-01-11 14:33:59.000000000","message":"Is find_blacklist used anywhere?  Also I don\u0027t see any difference between this and find_blacklists.","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"        return blacklists"},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"    def find_blacklist(self, context, criterion):"},{"line_number":1007,"context_line":"        policy.check(\u0027find_blacklist\u0027, context)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        blacklist \u003d self.storage_api.find_blacklists(context, criterion)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fi78%3D","line":1006,"in_reply_to":"AAAAUH%2F%2Fja4%3D","updated":"2014-01-13 05:41:11.000000000","message":"find_blacklist returns only one blacklisted zone and find_blacklists returns all of them","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"44ec4a750224e9813587415d3332b90706c041cf","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        return True"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _is_blacklisted_domain_name(self, context, domain_name):"},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        Ensures the provided domain_name is not blacklisted."},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fc%2Fs%3D","line":167,"updated":"2014-01-13 18:40:02.000000000","message":"This doesn\u0027t seem to check if it is a sub domain of the blacklisted domain - eg i can add www.google.com if I blacklist google.com.","commit_id":"d450e5cc5e6dcdc654e344751b09c4a611ce1b0d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e8da8fce26e446eff51711bd32c4afe221534036","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        blacklists \u003d self.storage_api.find_blacklists(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        for blacklist in blacklists:"},{"line_number":210,"context_line":"            if bool(re.search(blacklist[\"name\"], domain_name)):"},{"line_number":211,"context_line":"                return True"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Bn%2Fo%3D","line":210,"updated":"2014-01-23 19:34:18.000000000","message":"You are using re.search here.  So I wanted to make sure that regular expressions are allowed in blacklists.\nAlso we need to take care of subdomains here.","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"98acea6597f4a21d168ccdd8091a249886bf5e8e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        blacklists \u003d self.storage_api.find_blacklists(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        for blacklist in blacklists:"},{"line_number":210,"context_line":"            if bool(re.search(blacklist[\"name\"], domain_name)):"},{"line_number":211,"context_line":"                return True"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Bn3g%3D","line":210,"in_reply_to":"AAAAUH%2F%2Bn%2Fo%3D","updated":"2014-01-24 16:46:04.000000000","message":"Regular expressions work in domains and subdomains are taken care of. You can see it all in the unit tests.","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"}],"designate/resources/schemas/v1/blacklist.json":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        },"},{"line_number":24,"context_line":"        \"created_at\": {"},{"line_number":25,"context_line":"            \"type\": \"string\","},{"line_number":26,"context_line":"            \"description\": \"Date and time of server creation\","},{"line_number":27,"context_line":"            \"format\": \"date-time\","},{"line_number":28,"context_line":"            \"readonly\": true"},{"line_number":29,"context_line":"        },"}],"source_content_type":"application/json","patch_set":1,"id":"AAAAUH%2F%2F1m8%3D","line":26,"updated":"2014-01-07 21:50:32.000000000","message":"Should this be \"Date and time of blacklisted zone creation\"?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        },"},{"line_number":30,"context_line":"        \"description\": {"},{"line_number":31,"context_line":"            \"type\": [\"string\", \"null\"],"},{"line_number":32,"context_line":"            \"description\": \"Description for the record\","},{"line_number":33,"context_line":"            \"maxLength\": 160"},{"line_number":34,"context_line":"        },"},{"line_number":35,"context_line":"        \"updated_at\": {"}],"source_content_type":"application/json","patch_set":1,"id":"AAAAUH%2F%2F1m4%3D","line":32,"updated":"2014-01-07 21:50:32.000000000","message":"\"Description for the blacklisted zone\"","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        },"},{"line_number":35,"context_line":"        \"updated_at\": {"},{"line_number":36,"context_line":"            \"type\": [\"string\", \"null\"],"},{"line_number":37,"context_line":"            \"description\": \"Date and time of last domain update\","},{"line_number":38,"context_line":"            \"format\": \"date-time\","},{"line_number":39,"context_line":"            \"readonly\": true"},{"line_number":40,"context_line":"        }"}],"source_content_type":"application/json","patch_set":1,"id":"AAAAUH%2F%2F1mk%3D","line":37,"updated":"2014-01-07 21:50:32.000000000","message":"\"Date and time of last blacklisted zone update\"","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"}],"designate/resources/schemas/v2/blacklist.json":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e8da8fce26e446eff51711bd32c4afe221534036","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"name\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Blacklisted Zone\","},{"line_number":28,"context_line":"                    \"format\": \"domain-name\","},{"line_number":29,"context_line":"                    \"maxLength\": 255,"},{"line_number":30,"context_line":"                    \"required\": true"},{"line_number":31,"context_line":"                },"}],"source_content_type":"application/json","patch_set":6,"id":"AAAAUH%2F%2Bn%2FE%3D","line":28,"updated":"2014-01-23 19:34:18.000000000","message":"This needs to be \"domainname\".  Otherwise domain name checks are not enforced.","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"98acea6597f4a21d168ccdd8091a249886bf5e8e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"name\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Blacklisted Zone\","},{"line_number":28,"context_line":"                    \"format\": \"domain-name\","},{"line_number":29,"context_line":"                    \"maxLength\": 255,"},{"line_number":30,"context_line":"                    \"required\": true"},{"line_number":31,"context_line":"                },"}],"source_content_type":"application/json","patch_set":6,"id":"AAAAUH%2F%2BnwU%3D","line":28,"in_reply_to":"AAAAUH%2F%2Bn%2FE%3D","updated":"2014-01-24 16:46:04.000000000","message":"Done","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b6010a3187e7041f31e2a490b4eb46eb6529b30d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                    \"pattern\": \"^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$\","},{"line_number":23,"context_line":"                    \"readonly\": true"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \"name\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Blacklisted Zone\","},{"line_number":28,"context_line":"                    \"maxLength\": 255,"}],"source_content_type":"application/json","patch_set":7,"id":"AAAAUH%2F%2BboY%3D","line":25,"updated":"2014-01-26 19:56:19.000000000","message":"See notes on the views/blacklists.py file - this should go to \u0027pattern\u0027","commit_id":"1d0a7dc606a7438d71fcb071f11ad6ce2438434c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b6010a3187e7041f31e2a490b4eb46eb6529b30d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \"readonly\": true"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \"name\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Blacklisted Zone\","},{"line_number":28,"context_line":"                    \"maxLength\": 255,"},{"line_number":29,"context_line":"                    \"required\": true"}],"source_content_type":"application/json","patch_set":7,"id":"AAAAUH%2F%2BboU%3D","line":26,"updated":"2014-01-26 19:56:19.000000000","message":"This should then go to a \u0027regex\u0027 type","commit_id":"1d0a7dc606a7438d71fcb071f11ad6ce2438434c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b6010a3187e7041f31e2a490b4eb46eb6529b30d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \"name\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Blacklisted Zone\","},{"line_number":28,"context_line":"                    \"maxLength\": 255,"},{"line_number":29,"context_line":"                    \"required\": true"},{"line_number":30,"context_line":"                },"}],"source_content_type":"application/json","patch_set":7,"id":"AAAAUH%2F%2BboM%3D","line":27,"updated":"2014-01-26 19:56:19.000000000","message":"\u0027Blacklisted (python) regex pattern\u0027 (something more descriptive, but along those lines)","commit_id":"1d0a7dc606a7438d71fcb071f11ad6ce2438434c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ee92a513977054c38a726abcb3162fc9952d3d7a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"pattern\": {"},{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Regex for blacklisted zone name\","},{"line_number":28,"context_line":"                    \"format\": \"blacklistname\","},{"line_number":29,"context_line":"                    \"maxLength\": 512,"},{"line_number":30,"context_line":"                    \"required\": true"},{"line_number":31,"context_line":"                },"}],"source_content_type":"application/json","patch_set":8,"id":"AAAAUH%2F9YcQ%3D","line":28,"updated":"2014-02-07 10:10:25.000000000","message":"This should be \"format: regex\", there\u0027s no need for a custom format validator in this case.","commit_id":"529bd963e34b9803fc88c1b8661783f6ea7bce0d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"70baed403edbf177020e9ca08e3381e2303cb6fd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                    \"type\": \"string\","},{"line_number":27,"context_line":"                    \"description\": \"Regex for blacklisted zone name\","},{"line_number":28,"context_line":"                    \"format\": \"regex\","},{"line_number":29,"context_line":"                    \"maxLength\": 512,"},{"line_number":30,"context_line":"                    \"required\": true"},{"line_number":31,"context_line":"                },"},{"line_number":32,"context_line":"                \"created_at\": {"}],"source_content_type":"application/json","patch_set":10,"id":"AAAAUX%2F%2F5rs%3D","line":29,"updated":"2014-02-10 03:34:14.000000000","message":"In the DB Migration, the column is set to 255 chars.","commit_id":"0283bfc928a6bf14557108c3498ae170d8f96396"}],"designate/schema/format.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"44945bf4f6193bee5ed27ceff8d8f53ea39cdf8c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    r\u0027(\\.((?!\\-)[A-Za-z0-9_\\-]{1,63}(?\u003c!\\-)))*$\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RE_BLACKLISTNAME \u003d \\"},{"line_number":32,"context_line":"    r\u0027^(?!.{512,})((?!\\-)[A-Za-z0-9_\\\\\\.\\^\\+\\?\\$\\-]{1,63}(?\u003c!\\-))+$\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"draft3_format_checker \u003d jsonschema.draft3_format_checker"},{"line_number":35,"context_line":"draft4_format_checker \u003d jsonschema.draft4_format_checker"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9bJY%3D","line":32,"updated":"2014-02-07 00:42:09.000000000","message":"Minor change if you are modifying the patchset for other reasons - Since you doubled the total length to 512, it makes sense to increase each label length from 63 to 128 to account for regex characters in the label.","commit_id":"529bd963e34b9803fc88c1b8661783f6ea7bce0d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ee92a513977054c38a726abcb3162fc9952d3d7a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    if not re.match(RE_BLACKLISTNAME, instance):"},{"line_number":133,"context_line":"        return False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9Yb4%3D","line":135,"updated":"2014-02-07 10:10:25.000000000","message":"See my comment in designate/resources/schemas/v2/blacklist.json - This should be unnecessary","commit_id":"529bd963e34b9803fc88c1b8661783f6ea7bce0d"}],"designate/storage/api.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"5a15cf2483358ae2f4a028048eca5575bf4bc0b3","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        :param context: RPC Context."},{"line_number":747,"context_line":"        :param blacklist_id: Blacklist ID to delete."},{"line_number":748,"context_line":"        \"\"\""},{"line_number":749,"context_line":"        yield self.storage.get_blacklist(context, blacklist_id)"},{"line_number":750,"context_line":"        self.storage.delete_blacklist(context, blacklist_id)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def ping(self, context):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F9UpM%3D","line":749,"updated":"2014-02-07 18:52:10.000000000","message":"I believe this should actually be:\n\nself.storage.begin()\n\ntry:\n    yield self.storage.get_blacklist(context, domain_id)\n    self.storage.delete_blacklist(context, domain_id)\nexcept Exception:\n    with excutils.save_and_reraise_exception():\n        self.storage.rollback()\nelse:\n    self.storage.commit()\n\nThe delete_tld one is actually not right either. It\u0027s still manually deleting the TLD so that needs to be fixed.","commit_id":"de775b18bddb30ad0850e3df51ae5e9998365857"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"4fa447080500df9cd6abd9989803a500e8697444","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            raise exceptions.DomainNotFound()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def create_domain(self, context, values):"},{"line_number":308,"context_line":"        LOG.debug(\"impl_sqlalchemy.__init__py.create_domain\")"},{"line_number":309,"context_line":"        domain \u003d models.Domain()"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        domain.update(values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F1lY%3D","line":308,"updated":"2014-01-07 21:50:32.000000000","message":"Did you put this for your debugging?  Should this now be removed?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"}],"designate/storage/impl_sqlalchemy/migrate_repo/versions/036_add_blacklist_table.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Rackspace Hosting"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Betsy Luzader \u003cbetsy.luzader@rackspace.com\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FjZ0%3D","line":1,"updated":"2014-01-11 14:33:59.000000000","message":"Minor - could you change the year to 2014","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Rackspace Hosting"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Betsy Luzader \u003cbetsy.luzader@rackspace.com\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fi7g%3D","line":1,"in_reply_to":"AAAAUH%2F%2FjZ0%3D","updated":"2014-01-13 05:41:11.000000000","message":"Done","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"3280c394146917c87520b4a07f097acfa7da2f98","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                         unique\u003dTrue),"},{"line_number":41,"context_line":"                  Column(\u0027description\u0027,"},{"line_number":42,"context_line":"                         String(160),"},{"line_number":43,"context_line":"                         nullable\u003dTrue))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fes4%3D","line":43,"updated":"2014-01-13 13:47:49.000000000","message":"I missed this the last time - I am not sure if we need to specify the following here.  Kiall do you know if this is needed.\n    mysql_engine\u003d\u0027INNODB\u0027,\n    mysql_charset\u003d\u0027utf8\u0027)","commit_id":"d450e5cc5e6dcdc654e344751b09c4a611ce1b0d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"08a73ec10ecc8da8774bdc3d289abba57ef6f447","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                         unique\u003dTrue),"},{"line_number":41,"context_line":"                  Column(\u0027description\u0027,"},{"line_number":42,"context_line":"                         String(160),"},{"line_number":43,"context_line":"                         nullable\u003dTrue))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Feks%3D","line":43,"in_reply_to":"AAAAUH%2F%2Fes4%3D","updated":"2014-01-13 14:04:08.000000000","message":"Yes - We do need to specify these now, in order to ensure the tables are always utf8,\n\nA previous migration changed all the existing tables, and new migrations should do this from the start.","commit_id":"d450e5cc5e6dcdc654e344751b09c4a611ce1b0d"}],"designate/storage/impl_sqlalchemy/models.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"70baed403edbf177020e9ca08e3381e2303cb6fd","unresolved":false,"context_lines":[{"line_number":193,"context_line":"class Blacklists(Base):"},{"line_number":194,"context_line":"    __tablename__ \u003d \u0027blacklists\u0027"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    pattern \u003d Column(String(512), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":197,"context_line":"    description \u003d Column(Unicode(160), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2F5rY%3D","line":196,"updated":"2014-02-10 03:34:14.000000000","message":"In the DB Migration, the column is set to 255 chars.","commit_id":"0283bfc928a6bf14557108c3498ae170d8f96396"}],"designate/tests/test_central/test_service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_is_blacklisted_domain_name(self):"},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":"        self.config(domain_name_blacklist\u003d[\u0027^example.org.$\u0027, \u0027net.$\u0027],"},{"line_number":78,"context_line":"                    group\u003d\u0027service:central\u0027)"},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        context \u003d self.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fysw%3D","line":77,"updated":"2014-01-08 12:19:02.000000000","message":"Can we remove the commented lines here?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def test_create_blacklisted_domain_success(self):"},{"line_number":444,"context_line":"        #self.config(domain_name_blacklist\u003d[\u0027^blacklisted.com.$\u0027],"},{"line_number":445,"context_line":"        #            group\u003d\u0027service:central\u0027)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        context \u003d self.get_admin_context()"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fysk%3D","line":445,"updated":"2014-01-08 12:19:02.000000000","message":"More commented lines etc :)","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_create_blacklisted_domain_fail(self):"},{"line_number":474,"context_line":"        #self.config(domain_name_blacklist\u003d[\u0027^blacklisted.com.$\u0027],"},{"line_number":475,"context_line":"        #            group\u003d\u0027service:central\u0027)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        context \u003d self.get_admin_context()"},{"line_number":478,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fysc%3D","line":475,"updated":"2014-01-08 12:19:02.000000000","message":"More commented lines etc :)","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"            self.central_service.count_records(self.get_context())"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    # Blacklist Tests"},{"line_number":1398,"context_line":"    def test_create_blacklist(self):"},{"line_number":1399,"context_line":"        context \u003d self.get_admin_context()"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        values \u003d dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FjYY%3D","line":1398,"updated":"2014-01-11 14:33:59.000000000","message":"Many of the following tests functions use the following 3 lines (or a slight variation of it) to create a blacklist.  These could be moved to a separate function.","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"            self.central_service.count_records(self.get_context())"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    # Blacklist Tests"},{"line_number":1398,"context_line":"    def test_create_blacklist(self):"},{"line_number":1399,"context_line":"        context \u003d self.get_admin_context()"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        values \u003d dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FgwU%3D","line":1398,"in_reply_to":"AAAAUH%2F%2FjYY%3D","updated":"2014-01-13 05:41:11.000000000","message":"I was in the process of cleaning up the tests. They definitely needed it.\nDone","commit_id":"68450a642a62de04c4ffef276867c73988d31801"}],"doc/source/examples/basic-config-sample.conf":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e8da8fce26e446eff51711bd32c4afe221534036","unresolved":false,"context_lines":[{"line_number":33,"context_line":"backend_driver \u003d powerdns"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Accepted TLD list - http://data.iana.org/TLD/tlds-alpha-by-domain.txt"},{"line_number":36,"context_line":"#accepted_tld_list \u003d COM, NET, ORG, IE, UK, ..."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Maximum domain name length"},{"line_number":39,"context_line":"max_domain_name_len \u003d 255"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2Bn9w%3D","line":36,"updated":"2014-01-23 19:34:18.000000000","message":"Could you remove these lines?  My previous change had removed these lines.","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"98acea6597f4a21d168ccdd8091a249886bf5e8e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"backend_driver \u003d powerdns"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Accepted TLD list - http://data.iana.org/TLD/tlds-alpha-by-domain.txt"},{"line_number":36,"context_line":"#accepted_tld_list \u003d COM, NET, ORG, IE, UK, ..."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Maximum domain name length"},{"line_number":39,"context_line":"max_domain_name_len \u003d 255"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2Bnv4%3D","line":36,"in_reply_to":"AAAAUH%2F%2Bn9w%3D","updated":"2014-01-24 16:46:04.000000000","message":"Done","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"}],"etc/designate/designate.conf.sample":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e8da8fce26e446eff51711bd32c4afe221534036","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Effective TLDs"},{"line_number":44,"context_line":"# This is a local copy of the list at http://publicsuffix.org/list/"},{"line_number":45,"context_line":"# This contains domain names that effectively act like TLDs e.g. co.uk or tx.us"},{"line_number":46,"context_line":"#effective_tlds_file \u003d effective_tld_names.dat"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Maximum domain name length"},{"line_number":49,"context_line":"#max_domain_name_len \u003d 255"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2Bn9o%3D","line":46,"updated":"2014-01-23 19:34:18.000000000","message":"Could you remove these lines?  My previous change had removed these lines.","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"98acea6597f4a21d168ccdd8091a249886bf5e8e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Effective TLDs"},{"line_number":44,"context_line":"# This is a local copy of the list at http://publicsuffix.org/list/"},{"line_number":45,"context_line":"# This contains domain names that effectively act like TLDs e.g. co.uk or tx.us"},{"line_number":46,"context_line":"#effective_tlds_file \u003d effective_tld_names.dat"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Maximum domain name length"},{"line_number":49,"context_line":"#max_domain_name_len \u003d 255"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2Bnu4%3D","line":46,"in_reply_to":"AAAAUH%2F%2Bn9o%3D","updated":"2014-01-24 16:46:04.000000000","message":"Done","commit_id":"6945d0dfcda4ea72fee8742c98986451edeb53b9"}],"etc/designate/policy.json":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"34b16802888fd111c0e590bef6ca923b10aaee91","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"count_records\": \"rule:admin_or_owner\","},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \"use_sudo\": \"rule:admin\","},{"line_number":50,"context_line":"    \"use_blacklisted_domain\": \"rule:admin\","},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"create_blacklist\": \"rule:admin\","},{"line_number":53,"context_line":"    \"find_blacklist\": \"rule:admin\","}],"source_content_type":"application/json","patch_set":1,"id":"AAAAUH%2F%2Fyr8%3D","line":50,"updated":"2014-01-08 12:19:02.000000000","message":"Can we move this to the bottom of the new blacklist group?","commit_id":"cc0a6645b4579f063b6c8ad61921ba283a7638a6"}],"setup.cfg":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2180c3d3bb66464483a89c9388f25748cfd81e57","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    records \u003d designate.api.v1.records:blueprint"},{"line_number":46,"context_line":"    servers \u003d designate.api.v1.servers:blueprint"},{"line_number":47,"context_line":"    tsigkeys \u003d designate.api.v1.tsigkeys:blueprint"},{"line_number":48,"context_line":"    blacklist \u003d designate.api.v1.blacklist:blueprint"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"designate.api.v1.extensions \u003d"},{"line_number":51,"context_line":"    diagnostics \u003d designate.api.v1.extensions.diagnostics:blueprint"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"AAAAUH%2F%2FjYs%3D","line":48,"updated":"2014-01-11 14:33:59.000000000","message":"Now that the blacklist apis are in v2 and not v1, this should not be needed","commit_id":"68450a642a62de04c4ffef276867c73988d31801"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"6ede87b25d5c6887bf659ec6c3d0651388dde636","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    records \u003d designate.api.v1.records:blueprint"},{"line_number":46,"context_line":"    servers \u003d designate.api.v1.servers:blueprint"},{"line_number":47,"context_line":"    tsigkeys \u003d designate.api.v1.tsigkeys:blueprint"},{"line_number":48,"context_line":"    blacklist \u003d designate.api.v1.blacklist:blueprint"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"designate.api.v1.extensions \u003d"},{"line_number":51,"context_line":"    diagnostics \u003d designate.api.v1.extensions.diagnostics:blueprint"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"AAAAUH%2F%2FhPE%3D","line":48,"in_reply_to":"AAAAUH%2F%2FjYs%3D","updated":"2014-01-13 05:41:11.000000000","message":"Done","commit_id":"68450a642a62de04c4ffef276867c73988d31801"}]}