)]}'
{"designate/notification_handler/fake.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"96a64c8f09630a04d1f1efbcef9c210422788013","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def process_notification(self, context, event_type, payload):"},{"line_number":49,"context_line":"        LOG.info(\u0027%s: received notification - %s\u0027,"},{"line_number":50,"context_line":"                 self.get_canonical_name(), event_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_4ac0fae1","line":50,"range":{"start_line":50,"start_character":17,"end_line":50,"end_character":42},"updated":"2019-05-27 08:45:49.000000000","message":"Can the name change after initialization? Otherwise this would just be \"self.name\".","commit_id":"ad865aa354c3bf1700705e5e7a344f2f050e76a1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1ce4ebb6ddfabe8c541561ee8f09fb590c4cd5db","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def process_notification(self, context, event_type, payload):"},{"line_number":49,"context_line":"        LOG.info(\u0027%s: received notification - %s\u0027,"},{"line_number":50,"context_line":"                 self.get_canonical_name(), event_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_9abe39b2","line":50,"range":{"start_line":50,"start_character":17,"end_line":50,"end_character":42},"in_reply_to":"bfb3d3c7_4ac0fae1","updated":"2019-05-27 18:10:50.000000000","message":"It shouldn\u0027t ever change. We probably want to change this on the other handlers as well.","commit_id":"ad865aa354c3bf1700705e5e7a344f2f050e76a1"}],"designate/tests/unit/sink/test_notifications.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"96a64c8f09630a04d1f1efbcef9c210422788013","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.service.info(self.context, None, event_type,"},{"line_number":43,"context_line":"                          fixture[\u0027payload\u0027], None)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.assertIn(\u0027fake: received notification - %s\u0027 % event_type,"},{"line_number":46,"context_line":"                      self.stdlog.logger.output)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_simple_notification_with_unknown_event(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_0a120263","line":45,"updated":"2019-05-27 08:45:49.000000000","message":"This will match as a substring, but the full message will be \"handler:fake: received ...\", so I\u0027d match on that to avoid confusion.\n\nMight also be worth adding something like a test_notification_handler_name function to verify that part.","commit_id":"ad865aa354c3bf1700705e5e7a344f2f050e76a1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1ce4ebb6ddfabe8c541561ee8f09fb590c4cd5db","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.service.info(self.context, None, event_type,"},{"line_number":43,"context_line":"                          fixture[\u0027payload\u0027], None)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.assertIn(\u0027fake: received notification - %s\u0027 % event_type,"},{"line_number":46,"context_line":"                      self.stdlog.logger.output)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_simple_notification_with_unknown_event(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_3aaf0d7e","line":45,"in_reply_to":"bfb3d3c7_0a120263","updated":"2019-05-27 18:10:50.000000000","message":"Good catch. I didn\u0027t want to add \"fake\" handler specific tests here, but I think it\u0027s worth the effort, so added some tests for the fake handler as well.","commit_id":"ad865aa354c3bf1700705e5e7a344f2f050e76a1"}]}