)]}'
{"id":"openstack%2Fdesignate~660484","triplet_id":"openstack%2Fdesignate~master~Icaecf50fada63454f150f2a2b26d7b455ba48f33","project":"openstack/designate","branch":"master","topic":"standardize_unit_tests","hashtags":[],"change_id":"Icaecf50fada63454f150f2a2b26d7b455ba48f33","subject":"Modernized object tests","status":"MERGED","created":"2019-05-21 18:08:27.000000000","updated":"2019-05-22 22:30:29.000000000","submitted":"2019-05-22 22:30:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660484-1558564229283-c2c98f2f","meta_rev_id":"5d8d2ba5a79525207a38cfba8151296dd298f6ce","_number":660484,"virtual_id_number":660484,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2019-05-22 22:30:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-05-22 10:44:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-22 19:14:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-22 10:44:49.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-05-22 22:30:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c9d73ed4fa65b3eeea1c51c1c58d6a719bbffb0b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-21 18:08:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c619f9635929718af31698fdb062517ea760a2ad","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-21 18:10:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2b9f5ecf9121656780b8256d2ad78628b71d58c5","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-21 18:18:10.000000000","message":"Topic changed from new_unit_objects to standardize_unit_tests","accounts_in_message":[],"_revision_number":2},{"id":"f9fd99880136ce8cfea23da2bd9265661de8d3dd","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-21 19:17:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"798f9c1c579b92080bb50c08403cbe34c2705646","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-21 20:15:42.000000000","message":"Topic changed from new_unit_objects to standardize_unit_tests","accounts_in_message":[],"_revision_number":3},{"id":"04b9c5b9e028763515760850adf0c2ab1f50c2fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 20:28:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/84/660484/3/check/designate-bind9/1dbeb63/ : SUCCESS in 37m 44s\n- designate-pdns4 http://logs.openstack.org/84/660484/3/check/designate-pdns4/59a9ef3/ : SUCCESS in 34m 39s\n- designate-bind9-manager-model http://logs.openstack.org/84/660484/3/check/designate-bind9-manager-model/2777da9/ : SUCCESS in 38m 36s\n- designate-bind9-py27 http://logs.openstack.org/84/660484/3/check/designate-bind9-py27/1f8a575/ : SUCCESS in 40m 03s\n- designate-pdns4-py27 http://logs.openstack.org/84/660484/3/check/designate-pdns4-py27/ad5cc7e/ : SUCCESS in 39m 35s\n- designate-pdns4-postgres http://logs.openstack.org/84/660484/3/check/designate-pdns4-postgres/033f24b/ : SUCCESS in 41m 46s\n- designate-grenade-pdns4 http://logs.openstack.org/84/660484/3/check/designate-grenade-pdns4/f47fded/ : SUCCESS in 52m 27s\n- openstack-tox-cover http://logs.openstack.org/84/660484/3/check/openstack-tox-cover/7884f54/cover/ : SUCCESS in 6m 43s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/660484/3/check/openstack-tox-lower-constraints/4991d48/ : SUCCESS in 6m 20s\n- openstack-tox-pep8 http://logs.openstack.org/84/660484/3/check/openstack-tox-pep8/089023a/ : SUCCESS in 7m 09s\n- openstack-tox-py27 http://logs.openstack.org/84/660484/3/check/openstack-tox-py27/f0aab22/ : SUCCESS in 7m 37s\n- openstack-tox-py36 http://logs.openstack.org/84/660484/3/check/openstack-tox-py36/aa98f37/ : SUCCESS in 7m 38s\n- openstack-tox-py37 http://logs.openstack.org/84/660484/3/check/openstack-tox-py37/8345219/ : SUCCESS in 8m 15s\n- openstack-tox-docs http://logs.openstack.org/84/660484/3/check/openstack-tox-docs/34d4a73/html/ : SUCCESS in 7m 22s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/84/660484/3/check/neutron-tempest-plugin-designate-scenario/22f4b7f/ : SUCCESS in 36m 36s","accounts_in_message":[],"_revision_number":3},{"id":"9e6ac1c2bf972d3806031173f758d1e873b68ee0","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-05-22 10:44:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"62cc84d1e8a7615d906fd01c38f17babe32f663b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-22 19:14:53.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"e98034533bd3426398667c324afc8ac42ee20f52","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 19:15:09.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d4fa887c460db14aab2198f7b5c9d51c81988024","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 21:19:49.000000000","message":"Patch Set 3:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"98564c4acb3cd34e772d0ca8629666952dca1ddd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 22:30:25.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 http://logs.openstack.org/84/660484/3/gate/designate-bind9/fde0250/ : SUCCESS in 40m 01s\n- designate-pdns4 http://logs.openstack.org/84/660484/3/gate/designate-pdns4/aaac1ef/ : SUCCESS in 38m 33s\n- designate-bind9-manager-model http://logs.openstack.org/84/660484/3/gate/designate-bind9-manager-model/dc91865/ : SUCCESS in 37m 20s\n- designate-bind9-py27 http://logs.openstack.org/84/660484/3/gate/designate-bind9-py27/48f9573/ : SUCCESS in 43m 59s\n- designate-pdns4-py27 http://logs.openstack.org/84/660484/3/gate/designate-pdns4-py27/ddb792b/ : SUCCESS in 36m 25s\n- designate-pdns4-postgres http://logs.openstack.org/84/660484/3/gate/designate-pdns4-postgres/afde22f/ : SUCCESS in 40m 31s\n- designate-grenade-pdns4 http://logs.openstack.org/84/660484/3/gate/designate-grenade-pdns4/eb97fea/ : SUCCESS in 1h 03m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/660484/3/gate/openstack-tox-lower-constraints/926eb03/ : SUCCESS in 5m 24s\n- openstack-tox-pep8 http://logs.openstack.org/84/660484/3/gate/openstack-tox-pep8/fc25372/ : SUCCESS in 4m 58s\n- openstack-tox-py27 http://logs.openstack.org/84/660484/3/gate/openstack-tox-py27/c866495/ : SUCCESS in 5m 24s\n- openstack-tox-py36 http://logs.openstack.org/84/660484/3/gate/openstack-tox-py36/b986cba/ : SUCCESS in 5m 19s\n- openstack-tox-py37 http://logs.openstack.org/84/660484/3/gate/openstack-tox-py37/8c38848/ : SUCCESS in 5m 45s\n- openstack-tox-docs http://logs.openstack.org/84/660484/3/gate/openstack-tox-docs/460bcf7/html/ : SUCCESS in 5m 13s","accounts_in_message":[],"_revision_number":3},{"id":"5d8d2ba5a79525207a38cfba8151296dd298f6ce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 22:30:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4820cd48d8be179f113e20163230f63f234ab96a","revisions":{"e311f4c988610dfec05017d5197109c1e14ee472":{"kind":"REWORK","_number":1,"created":"2019-05-21 18:08:27.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/84/660484/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/84/660484/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/84/660484/1"}}},"commit":{"parents":[{"commit":"8594066e2b172b8338a5bbb3439cd75aeeef3e9f","subject":"Merge \"Added PowerDNS 4 unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8594066e2b172b8338a5bbb3439cd75aeeef3e9f"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 18:07:15.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 18:08:38.000000000","tz":-420},"subject":"Modernized object tests","message":"Modernized object tests\n\n- Moved all tests to unit/objects.\n- Cleaned up tests and standardized them.\n\nChange-Id: Icaecf50fada63454f150f2a2b26d7b455ba48f33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e311f4c988610dfec05017d5197109c1e14ee472"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e311f4c988610dfec05017d5197109c1e14ee472"}]},"branch":"refs/heads/master"},"ec78091d1b64fc8595914dc0892fbb8f047c5965":{"kind":"REWORK","_number":2,"created":"2019-05-21 18:10:45.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/84/660484/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/84/660484/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/84/660484/2"}}},"commit":{"parents":[{"commit":"8594066e2b172b8338a5bbb3439cd75aeeef3e9f","subject":"Merge \"Added PowerDNS 4 unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8594066e2b172b8338a5bbb3439cd75aeeef3e9f"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 18:07:15.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 18:10:52.000000000","tz":-420},"subject":"Modernized object tests","message":"Modernized object tests\n\n- Moved all tests to unit/objects.\n- Cleaned up tests and standardized them.\n\nChange-Id: Icaecf50fada63454f150f2a2b26d7b455ba48f33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ec78091d1b64fc8595914dc0892fbb8f047c5965"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ec78091d1b64fc8595914dc0892fbb8f047c5965"}]},"branch":"refs/heads/master"},"4820cd48d8be179f113e20163230f63f234ab96a":{"kind":"REWORK","_number":3,"created":"2019-05-21 19:17:40.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/84/660484/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/84/660484/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/84/660484/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/84/660484/3"}}},"commit":{"parents":[{"commit":"8594066e2b172b8338a5bbb3439cd75aeeef3e9f","subject":"Merge \"Added PowerDNS 4 unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8594066e2b172b8338a5bbb3439cd75aeeef3e9f"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 18:07:15.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-21 19:17:48.000000000","tz":-420},"subject":"Modernized object tests","message":"Modernized object tests\n\n- Moved all tests to unit/objects.\n- Cleaned up tests and standardized them.\n\nChange-Id: Icaecf50fada63454f150f2a2b26d7b455ba48f33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4820cd48d8be179f113e20163230f63f234ab96a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4820cd48d8be179f113e20163230f63f234ab96a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}