)]}'
{"id":"openstack%2Fdesignate~661428","triplet_id":"openstack%2Fdesignate~master~Ibdecc9320587a88fcd83f58443562bc4391f059b","project":"openstack/designate","branch":"master","topic":"improved_tests","hashtags":[],"change_id":"Ibdecc9320587a88fcd83f58443562bc4391f059b","subject":"Adding basic socket tests and fixed a typo","status":"MERGED","created":"2019-05-25 05:48:29.000000000","updated":"2019-05-27 11:00:53.000000000","submitted":"2019-05-27 11:00:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"661428-1558954853581-1bcd8dc4","meta_rev_id":"4b031ffb900d0e20fd76c46669eac41dbc7a042a","_number":661428,"virtual_id_number":661428,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-05-27 11:00:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},{"value":0,"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-05-27 09:52:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2019-05-27 08:50:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-27 10:00:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},{"value":1,"date":"2019-05-27 09:08:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":1,"date":"2019-05-27 09:52:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},{"value":0,"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},{"value":0,"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},{"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-27 08:50:36.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-05-27 09:08:53.000000000","updated_by":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"reviewer":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"state":"REVIEWER"},{"updated":"2019-05-27 09:52:26.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-05-27 10:00:38.000000000","updated_by":{"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},"reviewer":{"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},"state":"REVIEWER"},{"updated":"2019-05-27 11:00:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8bc38b1129731dd86cad73d91d098abade87ac9b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-25 05:48:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"082dcf62100fb22e67f4040ce363966f3c5169a6","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-25 05:49:29.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f412cc9e552b9109caa78fbe47ad8ad4e669461e","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-05-25 05:54:35.000000000","message":"Topic changed from socket_tests to improved_tests","accounts_in_message":[],"_revision_number":2},{"id":"0bab1d6ece4eea100926fd2cd76669ea3568e4af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-25 06:52:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/28/661428/2/check/designate-bind9/4d7a14f/ : SUCCESS in 36m 30s\n- designate-pdns4 http://logs.openstack.org/28/661428/2/check/designate-pdns4/8adacd3/ : SUCCESS in 44m 00s\n- designate-bind9-manager-model http://logs.openstack.org/28/661428/2/check/designate-bind9-manager-model/c69157c/ : SUCCESS in 38m 02s\n- designate-bind9-py27 http://logs.openstack.org/28/661428/2/check/designate-bind9-py27/7306ed0/ : SUCCESS in 38m 41s\n- designate-pdns4-py27 http://logs.openstack.org/28/661428/2/check/designate-pdns4-py27/539f83e/ : SUCCESS in 30m 29s\n- designate-pdns4-postgres http://logs.openstack.org/28/661428/2/check/designate-pdns4-postgres/6415fef/ : SUCCESS in 35m 54s\n- designate-grenade-pdns4 http://logs.openstack.org/28/661428/2/check/designate-grenade-pdns4/4ad6218/ : SUCCESS in 1h 01m 56s\n- openstack-tox-cover http://logs.openstack.org/28/661428/2/check/openstack-tox-cover/015778e/cover/ : SUCCESS in 5m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/28/661428/2/check/openstack-tox-lower-constraints/be3fc31/ : SUCCESS in 4m 37s\n- openstack-tox-pep8 http://logs.openstack.org/28/661428/2/check/openstack-tox-pep8/c9ed947/ : SUCCESS in 4m 57s\n- openstack-tox-py27 http://logs.openstack.org/28/661428/2/check/openstack-tox-py27/37a3aa0/ : SUCCESS in 4m 48s\n- openstack-tox-py36 http://logs.openstack.org/28/661428/2/check/openstack-tox-py36/9351d46/ : SUCCESS in 5m 26s\n- openstack-tox-py37 http://logs.openstack.org/28/661428/2/check/openstack-tox-py37/56c1120/ : SUCCESS in 5m 14s\n- openstack-tox-docs http://logs.openstack.org/28/661428/2/check/openstack-tox-docs/c0c1cd5/html/ : SUCCESS in 4m 39s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/28/661428/2/check/neutron-tempest-plugin-designate-scenario/95c3b75/ : SUCCESS in 31m 56s","accounts_in_message":[],"_revision_number":2},{"id":"2c8030796f87b131c5fd0eba8123c53048abe35c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-05-27 08:50:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"80298c09f7ae81d76b0c06f75511fa5a38b46176","author":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"date":"2019-05-27 09:08:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f321a1e9dac27faaa8abfd5184db057cbad780dc","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-05-27 09:52:26.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e122ac62e1a2f51f8db25439412d5e8aa57996b8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-27 09:52:37.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"15a9138787184b1c0c36c7cc13c14560ecaab7fb","author":{"_account_id":30429,"name":"wangpeng","email":"wang_peng@awcloud.com"},"date":"2019-05-27 10:00:38.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bfe65d7c1a8e5ae6842243e41c79a936db301213","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-27 11:00:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4b031ffb900d0e20fd76c46669eac41dbc7a042a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-27 11:00:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 http://logs.openstack.org/28/661428/2/gate/designate-bind9/46a9188/ : SUCCESS in 37m 11s\n- designate-pdns4 http://logs.openstack.org/28/661428/2/gate/designate-pdns4/b431707/ : SUCCESS in 40m 28s\n- designate-bind9-manager-model http://logs.openstack.org/28/661428/2/gate/designate-bind9-manager-model/055c093/ : SUCCESS in 41m 43s\n- designate-bind9-py27 http://logs.openstack.org/28/661428/2/gate/designate-bind9-py27/7397b15/ : SUCCESS in 38m 27s\n- designate-pdns4-py27 http://logs.openstack.org/28/661428/2/gate/designate-pdns4-py27/e9a82ca/ : SUCCESS in 36m 51s\n- designate-pdns4-postgres http://logs.openstack.org/28/661428/2/gate/designate-pdns4-postgres/39289d4/ : SUCCESS in 36m 59s\n- designate-grenade-pdns4 http://logs.openstack.org/28/661428/2/gate/designate-grenade-pdns4/0893352/ : SUCCESS in 1h 02m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/28/661428/2/gate/openstack-tox-lower-constraints/35fc021/ : SUCCESS in 4m 40s\n- openstack-tox-pep8 http://logs.openstack.org/28/661428/2/gate/openstack-tox-pep8/1452da5/ : SUCCESS in 5m 06s\n- openstack-tox-py27 http://logs.openstack.org/28/661428/2/gate/openstack-tox-py27/6c278cd/ : SUCCESS in 5m 09s\n- openstack-tox-py36 http://logs.openstack.org/28/661428/2/gate/openstack-tox-py36/15bfccd/ : SUCCESS in 5m 17s\n- openstack-tox-py37 http://logs.openstack.org/28/661428/2/gate/openstack-tox-py37/c7989d2/ : SUCCESS in 5m 22s\n- openstack-tox-docs http://logs.openstack.org/28/661428/2/gate/openstack-tox-docs/91f217e/html/ : SUCCESS in 4m 34s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"54c62ee778762acb03b5f6c0af449bee7dad5419","revisions":{"04e4f981ab6f4bee1dd212575e21c7f1d2fb38c7":{"kind":"REWORK","_number":1,"created":"2019-05-25 05:48:29.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/28/661428/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/28/661428/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/28/661428/1"}}},"commit":{"parents":[{"commit":"7d2527014f664b37fab177c7b5dcfaf876e85519","subject":"Merge \"Added basic synchronized_zone tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7d2527014f664b37fab177c7b5dcfaf876e85519"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-25 05:47:46.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-25 05:47:46.000000000","tz":-420},"subject":"Adding basic socket tests and fixed a typo","message":"Adding basic socket tests and fixed a typo\n\nChange-Id: Ibdecc9320587a88fcd83f58443562bc4391f059b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/04e4f981ab6f4bee1dd212575e21c7f1d2fb38c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/04e4f981ab6f4bee1dd212575e21c7f1d2fb38c7"}]},"branch":"refs/heads/master"},"54c62ee778762acb03b5f6c0af449bee7dad5419":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-05-25 05:49:29.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/28/661428/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/28/661428/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/28/661428/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/28/661428/2"}}},"commit":{"parents":[{"commit":"7d2527014f664b37fab177c7b5dcfaf876e85519","subject":"Merge \"Added basic synchronized_zone tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7d2527014f664b37fab177c7b5dcfaf876e85519"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-25 05:47:46.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-05-25 05:48:43.000000000","tz":-420},"subject":"Adding basic socket tests and fixed a typo","message":"Adding basic socket tests and fixed a typo\n\nIn addition also fixed a minor typo in the logging\nfor bind_tcp.\n\nChange-Id: Ibdecc9320587a88fcd83f58443562bc4391f059b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/54c62ee778762acb03b5f6c0af449bee7dad5419"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/54c62ee778762acb03b5f6c0af449bee7dad5419"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}