)]}'
{"designate/conf/worker.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dc25f182a67d0842545193f646023f1b53fc8b3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027notify\u0027, default\u003dTrue,"},{"line_number":46,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":47,"context_line":"                deprecated_reason\u003d\u0027This option is being removed to reduce \u0027"},{"line_number":48,"context_line":"                                  \u0027complexity\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Whether to allow worker to send NOTIFYs, this will \u0027"},{"line_number":50,"context_line":"                     \u0027noop NOTIFYs in mdns if true\u0027),"},{"line_number":51,"context_line":"    cfg.BoolOpt(\u0027export_synchronous\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_a1b33e4d","line":48,"updated":"2019-08-09 11:46:30.000000000","message":"These two options should be mentioned in the release note, because the old upgrade document we are linking to still asks to set both.","commit_id":"37c26d1ba19df5db867a7afb6a57787929972300"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2d525b78ab733a7887e46d0e159d3fec13ad5baf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027notify\u0027, default\u003dTrue,"},{"line_number":46,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":47,"context_line":"                deprecated_reason\u003d\u0027This option is being removed to reduce \u0027"},{"line_number":48,"context_line":"                                  \u0027complexity\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Whether to allow worker to send NOTIFYs, this will \u0027"},{"line_number":50,"context_line":"                     \u0027noop NOTIFYs in mdns if true\u0027),"},{"line_number":51,"context_line":"    cfg.BoolOpt(\u0027export_synchronous\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_081feb6c","line":48,"in_reply_to":"7faddb67_a1b33e4d","updated":"2019-09-18 03:03:19.000000000","message":"This was removed in a recent update to the documentation.","commit_id":"37c26d1ba19df5db867a7afb6a57787929972300"}],"designate/manage/akamai.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c6d2fa7317e7f3e9fe55fe2d5e5ef61a17d08013","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        rpc.init(cfg.CONF)"},{"line_number":37,"context_line":"        self.central_api \u003d central_rpcapi.CentralAPI()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _get_config(self, pool_id, target_id):"},{"line_number":40,"context_line":"        pool \u003d pool_object.Pool.from_config(cfg.CONF, pool_id)"},{"line_number":41,"context_line":"        target \u003d None"},{"line_number":42,"context_line":"        for t in pool.targets:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_9ceec789","side":"PARENT","line":39,"updated":"2019-06-17 19:34:14.000000000","message":"This would have to be re-written to not use the configuration, as this is no longer supported.","commit_id":"ab50fcebc2be5b2fab3ba5bef2b3d6a9c3dd62a6"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"7a02086c84c092eb2ffc43ffb555ad1509bc8794","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @base.args(\u0027pool-id\u0027, help\u003d\"Pool to Sync\", type\u003dstr)"},{"line_number":73,"context_line":"    @base.args(\u0027pool-target-id\u0027, help\u003d\"Pool Target to Sync\", type\u003dstr)"},{"line_number":74,"context_line":"    @base.args(\u0027--batch-size\u0027, default\u003d20, type\u003dint)"},{"line_number":75,"context_line":"    def sync_zones(self, pool_id, pool_target_id, batch_size):"},{"line_number":76,"context_line":"        pool, target \u003d self._get_config(pool_id, pool_target_id)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        client \u003d impl_akamai.EnhancedDNSClient("}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_9c932701","side":"PARENT","line":75,"updated":"2019-06-17 19:34:37.000000000","message":"Not sure how critical this is.","commit_id":"ab50fcebc2be5b2fab3ba5bef2b3d6a9c3dd62a6"}],"designate/mdns/notify.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dc25f182a67d0842545193f646023f1b53fc8b3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            metrics.timing(\u0027mdns.notify_zone_changed\u0027,"},{"line_number":71,"context_line":"                           time.time() - start_time)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def poll_for_serial_number(self, context, zone, nameserver, timeout,"},{"line_number":74,"context_line":"                               retry_interval, max_retries, delay):"},{"line_number":75,"context_line":"        \"\"\"Get the serial number of a zone on a resolver, then call update_status"},{"line_number":76,"context_line":"        on Pool Manager to update the zone status."}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_21b50ece","side":"PARENT","line":73,"updated":"2019-08-09 11:46:30.000000000","message":"I think I understand that this function doesn\u0027t seem to make sense anymore when there is no pool_manager, but can we really just drop it from the RPC API? Or would it make sense to replace it with a no-op function instead?","commit_id":"076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2d525b78ab733a7887e46d0e159d3fec13ad5baf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            metrics.timing(\u0027mdns.notify_zone_changed\u0027,"},{"line_number":71,"context_line":"                           time.time() - start_time)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def poll_for_serial_number(self, context, zone, nameserver, timeout,"},{"line_number":74,"context_line":"                               retry_interval, max_retries, delay):"},{"line_number":75,"context_line":"        \"\"\"Get the serial number of a zone on a resolver, then call update_status"},{"line_number":76,"context_line":"        on Pool Manager to update the zone status."}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_2880a78b","side":"PARENT","line":73,"in_reply_to":"7faddb67_21b50ece","updated":"2019-09-18 03:03:19.000000000","message":"Do we actually need any of these? afaik only the pool-manager used this RPC API.","commit_id":"076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1"}],"designate/mdns/rpcapi.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"75daa4893e1612221d21b77163e96a2565a170b6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            MDNS_API \u003d cls()"},{"line_number":76,"context_line":"        return MDNS_API"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def notify_zone_changed(self, context, zone, host, port, timeout,"},{"line_number":79,"context_line":"                            retry_interval, max_retries, delay):"},{"line_number":80,"context_line":"        if CONF[\u0027service:worker\u0027].notify and CONF[\u0027service:worker\u0027].enabled:"},{"line_number":81,"context_line":"            LOG.debug(\u0027Letting worker send NOTIFYs instead\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_d900d1ae","side":"PARENT","line":78,"updated":"2019-06-17 18:04:20.000000000","message":"We can probably remove some of these code paths?","commit_id":"ab50fcebc2be5b2fab3ba5bef2b3d6a9c3dd62a6"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"932d191f4bf448cceb35e688bd698c9513d45b40","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def notify_zone_changed(self, context, zone, host, port, timeout,"},{"line_number":79,"context_line":"                            retry_interval, max_retries, delay):"},{"line_number":80,"context_line":"        return True"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def poll_for_serial_number(self, context, zone, nameserver, timeout,"},{"line_number":83,"context_line":"                               retry_interval, max_retries, delay):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_357a2588","line":80,"updated":"2019-07-24 18:20:51.000000000","message":"Graham this is the only thing I wasn\u0027t super sure of. I take it we don\u0027t need this at all when we removed the pool.","commit_id":"092b04a98190e3ac19023bb3382129ed205dd81a"}],"designate/tests/unit/test_central/test_basic.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dc25f182a67d0842545193f646023f1b53fc8b3","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        )"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    def test_touch_zone_with_worker_model(self):"},{"line_number":1150,"context_line":"        self._test_touch_zone()"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def test_get_recordset_not_found(self):"},{"line_number":1153,"context_line":"        self.service.storage.get_zone.return_value \u003d RoObject("}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_c13c3a32","line":1150,"updated":"2019-08-09 11:46:30.000000000","message":"Since this is the only remaining reference to this helper function, maybe just drop it and move the code here?\n\nSame for the other tests below.","commit_id":"37c26d1ba19df5db867a7afb6a57787929972300"}],"devstack/gate/gate_hook.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dc25f182a67d0842545193f646023f1b53fc8b3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DEVSTACK_GATE_DESIGNATE_DRIVER\u003d${DEVSTACK_GATE_DESIGNATE_DRIVER:-powerdns}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export KEEP_LOCALRC\u003d1"},{"line_number":10,"context_line":"export ENABLED_SERVICES\u003ddesignate,designate-api,designate-central,designate-sink,designate-mdns,designate-worker,designate-producer"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"echo \"DESIGNATE_SERVICE_PORT_DNS\u003d5322\" \u003e\u003e $BASE/new/devstack/localrc"},{"line_number":13,"context_line":"echo \"DESIGNATE_BACKEND_DRIVER\u003d$DEVSTACK_GATE_DESIGNATE_DRIVER\" \u003e\u003e $BASE/new/devstack/localrc"}],"source_content_type":"text/x-sh","patch_set":16,"id":"7faddb67_41604a36","line":10,"updated":"2019-08-09 11:46:30.000000000","message":"Actually I think we shouldn\u0027t be running devstack-gate based tests on master anymore, so we should be able to drop all this instead, but I\u0027m fine to test that in a followup.","commit_id":"37c26d1ba19df5db867a7afb6a57787929972300"}],"releasenotes/notes/removed-pool-manager-a1a9466aceb44b9f.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a38fcf1a238cf76ffa4b9825f5efd4f5d6992c4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The pool-manager has been removed in Train and can no longer be used. Instead"},{"line_number":5,"context_line":"    the worker and producer service will be used."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_1c82e101","line":5,"updated":"2019-06-17 10:19:52.000000000","message":"I think this change is big enough that in addition it  deserves a \"prelude\" section.\n\nAlso linking to the upgrade doc [1] would seem helpful to me.\n\n[1] https://docs.openstack.org/designate/latest/admin/upgrades/newton.html#upgrading-code-and-enabling-services\n\nBtw: Why do we still have Newton upgrade notes in our latest docs? Except, of course, that it makes them readily available when we need them, like here? ;)","commit_id":"8953f5400dbcec1bc9a01d1ca37ade6a3965269a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dc25f182a67d0842545193f646023f1b53fc8b3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Migration steps are available in the Newton upgrade guide `here`_."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. _here: https://docs.openstack.org/designate/latest/admin/upgrades/newton.html#upgrading-code-and-enabling-services"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_21d42ebd","line":11,"updated":"2019-08-09 11:46:30.000000000","message":"We should mentioned the removed/deprecated options here somehow, but I\u0027m not sure what the best way to do that would be.","commit_id":"37c26d1ba19df5db867a7afb6a57787929972300"}]}