)]}'
{"designate/manage/pool.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4592c4a935524ef4360e2233d8d3eafd99663866","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        pool \u003d self.central_api.get_pool("},{"line_number":141,"context_line":"                            self.context, xpool[\u0027id\u0027])"},{"line_number":142,"context_line":"                    except Exception as e:"},{"line_number":143,"context_line":"                        message \u003d \u0027Bad ID Supplied for pool.\u0027"},{"line_number":144,"context_line":"                        LOG.critical("},{"line_number":145,"context_line":"                            \"%(msg)s pool_id: %(pool)s message: %(res)s\" % {"},{"line_number":146,"context_line":"                                \u0027msg\u0027: message,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_aed7c923","line":143,"updated":"2019-07-04 17:01:57.000000000","message":"Might be better to just incorporate this directly in the log message.\nLOG.critical(\u0027Bad ID..... pool_id: ...\u0027, {...})","commit_id":"d5be2bb790519022864168bc77ba1e1acb61a993"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4592c4a935524ef4360e2233d8d3eafd99663866","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    except Exception as e:"},{"line_number":143,"context_line":"                        message \u003d \u0027Bad ID Supplied for pool.\u0027"},{"line_number":144,"context_line":"                        LOG.critical("},{"line_number":145,"context_line":"                            \"%(msg)s pool_id: %(pool)s message: %(res)s\" % {"},{"line_number":146,"context_line":"                                \u0027msg\u0027: message,"},{"line_number":147,"context_line":"                                \u0027pool\u0027: xpool[\u0027id\u0027],"},{"line_number":148,"context_line":"                                \u0027res\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ce1a4516","line":145,"updated":"2019-07-04 17:01:57.000000000","message":"No need to use % here, just use a comma to make the log line lazy loaded.","commit_id":"d5be2bb790519022864168bc77ba1e1acb61a993"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"23a9cb9339074715ef63fdc5bc937ba38d9e04ca","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            self.context, xpool[\u0027id\u0027])"},{"line_number":142,"context_line":"                    except Exception as e:"},{"line_number":143,"context_line":"                        LOG.critical("},{"line_number":144,"context_line":"                            \"Bad ID Supplied for pool. pool_id: \\"},{"line_number":145,"context_line":"                            %(pool)s message: %(res)s\", {"},{"line_number":146,"context_line":"                                \u0027pool\u0027: xpool[\u0027id\u0027],"},{"line_number":147,"context_line":"                                \u0027res\u0027: e})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_114cfdc5","line":144,"updated":"2019-07-05 04:56:22.000000000","message":"I missed this at first. Why the \\ ?","commit_id":"d494e85647e870fc03b02273d79518a39e0d8974"},{"author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"change_message_id":"0c3b409cdd25a98df143acc7d077ee07a82f715d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            self.context, xpool[\u0027id\u0027])"},{"line_number":142,"context_line":"                    except Exception as e:"},{"line_number":143,"context_line":"                        LOG.critical("},{"line_number":144,"context_line":"                            \"Bad ID Supplied for pool. pool_id: \\"},{"line_number":145,"context_line":"                            %(pool)s message: %(res)s\", {"},{"line_number":146,"context_line":"                                \u0027pool\u0027: xpool[\u0027id\u0027],"},{"line_number":147,"context_line":"                                \u0027res\u0027: e})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_914a2d7e","line":144,"in_reply_to":"7faddb67_114cfdc5","updated":"2019-07-05 05:31:57.000000000","message":"It was just to get rid of pep8 error.\n\nexcept Exception as e:\n    msg \u003d (\"Bad ID Supplied for pool. pool_id: \"\n         \"%(pool)s message: %(res)s\")\n    LOG.critical(msg, {\u0027pool\u0027: xpool[\u0027id\u0027], \u0027res\u0027: e})\n    continue\n\nI think this is ok.","commit_id":"d494e85647e870fc03b02273d79518a39e0d8974"}]}