)]}'
{"id":"openstack%2Fdesignate~671954","triplet_id":"openstack%2Fdesignate~master~I945c51330dae39f6d7d8384412ed7dc63abd46c1","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"I945c51330dae39f6d7d8384412ed7dc63abd46c1","subject":"Cleaned up mdns handler and added better test coverage","status":"MERGED","created":"2019-07-22 04:12:59.000000000","updated":"2019-08-06 12:42:39.000000000","submitted":"2019-08-06 12:42:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"671954-1565095359567-b796e31c","meta_rev_id":"6430e9780b5c6ebca25babc611b478c6e2ae4dcf","_number":671954,"virtual_id_number":671954,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-08-06 12:42:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-07-23 10:07:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2019-08-06 11:21:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":1,"date":"2019-08-06 11:21:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-23 10:07:23.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-08-06 11:21:25.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-08-06 12:42:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb151cfc8606aa13240a2f48666da87e57cefa20","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-22 04:12:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7fa9c2a0b2ce55c92da1e28af4d72177367a711f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-22 06:16:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/54/671954/1/check/designate-bind9/e08673f/ : SUCCESS in 40m 47s\n- designate-pdns4 http://logs.openstack.org/54/671954/1/check/designate-pdns4/251154c/ : SUCCESS in 42m 45s\n- designate-bind9-manager-model http://logs.openstack.org/54/671954/1/check/designate-bind9-manager-model/6f99bae/ : SUCCESS in 43m 54s\n- designate-bind9-py27 http://logs.openstack.org/54/671954/1/check/designate-bind9-py27/5f61a59/ : SUCCESS in 46m 19s\n- designate-pdns4-py27 http://logs.openstack.org/54/671954/1/check/designate-pdns4-py27/d77ae91/ : SUCCESS in 43m 35s\n- designate-pdns4-postgres http://logs.openstack.org/54/671954/1/check/designate-pdns4-postgres/a72eb6a/ : FAILURE in 29m 41s (non-voting)\n- designate-grenade-pdns4 http://logs.openstack.org/54/671954/1/check/designate-grenade-pdns4/a95aa32/ : SUCCESS in 56m 09s\n- openstack-tox-cover http://logs.openstack.org/54/671954/1/check/openstack-tox-cover/d823fa5/cover/ : SUCCESS in 5m 33s\n- openstack-tox-lower-constraints http://logs.openstack.org/54/671954/1/check/openstack-tox-lower-constraints/289689e/ : SUCCESS in 5m 00s\n- openstack-tox-pep8 http://logs.openstack.org/54/671954/1/check/openstack-tox-pep8/e19df85/ : SUCCESS in 5m 14s\n- openstack-tox-py27 http://logs.openstack.org/54/671954/1/check/openstack-tox-py27/4ab0462/ : SUCCESS in 4m 52s\n- openstack-tox-py36 http://logs.openstack.org/54/671954/1/check/openstack-tox-py36/4754cd8/ : SUCCESS in 5m 29s\n- openstack-tox-py37 http://logs.openstack.org/54/671954/1/check/openstack-tox-py37/9db4634/ : SUCCESS in 5m 33s\n- openstack-tox-docs http://logs.openstack.org/54/671954/1/check/openstack-tox-docs/8506997/html/ : SUCCESS in 4m 07s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/54/671954/1/check/neutron-tempest-plugin-designate-scenario/add02d7/ : SUCCESS in 36m 05s","accounts_in_message":[],"_revision_number":1},{"id":"0eeea962e385af5d9ef127f53edb43fc3a7ff6f1","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-07-23 10:07:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"acd5194aebfde5625c349a8caaee28057cd2b3ff","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-06 11:21:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2d4f99deb861cf26e90e9836f3b34645f9a57ccb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 11:21:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"522b855320f96789c3ab88b4265fc041bb6f8bb8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 12:42:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"6430e9780b5c6ebca25babc611b478c6e2ae4dcf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 12:42:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://logs.opendev.org/54/671954/1/gate/designate-bind9/43d6bdc/ : SUCCESS in 41m 45s\n- designate-pdns4 https://logs.opendev.org/54/671954/1/gate/designate-pdns4/0ccb0e6/ : SUCCESS in 45m 06s\n- designate-bind9-manager-model https://logs.opendev.org/54/671954/1/gate/designate-bind9-manager-model/7fd9e25/ : SUCCESS in 50m 29s\n- designate-bind9-py27 https://logs.opendev.org/54/671954/1/gate/designate-bind9-py27/70d8b46/ : SUCCESS in 51m 17s\n- designate-pdns4-py27 https://logs.opendev.org/54/671954/1/gate/designate-pdns4-py27/7b9f2bf/ : SUCCESS in 36m 51s\n- designate-grenade-pdns4 https://logs.opendev.org/54/671954/1/gate/designate-grenade-pdns4/515dedc/ : SUCCESS in 1h 11m 07s\n- openstack-tox-lower-constraints https://logs.opendev.org/54/671954/1/gate/openstack-tox-lower-constraints/cf646c8/ : SUCCESS in 4m 10s\n- openstack-tox-pep8 https://logs.opendev.org/54/671954/1/gate/openstack-tox-pep8/35aad0e/ : SUCCESS in 4m 30s\n- openstack-tox-py27 https://logs.opendev.org/54/671954/1/gate/openstack-tox-py27/3dfebf7/ : SUCCESS in 4m 02s\n- openstack-tox-py36 https://logs.opendev.org/54/671954/1/gate/openstack-tox-py36/1aa4003/ : SUCCESS in 3m 41s\n- openstack-tox-py37 https://logs.opendev.org/54/671954/1/gate/openstack-tox-py37/efac1ff/ : SUCCESS in 4m 57s\n- openstack-tox-docs https://logs.opendev.org/54/671954/1/gate/openstack-tox-docs/bfeb247/html/ : SUCCESS in 4m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5e0e4c194bf8ccb17e57c081e061ad580e6d800b","revisions":{"5e0e4c194bf8ccb17e57c081e061ad580e6d800b":{"kind":"REWORK","_number":1,"created":"2019-07-22 04:12:59.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/54/671954/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/54/671954/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/54/671954/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/54/671954/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/54/671954/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/54/671954/1"}}},"commit":{"parents":[{"commit":"762daa5507152be96956af4dd01c5fa060faa5f9","subject":"Merge \"Fixed akamai default wsdl path\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/762daa5507152be96956af4dd01c5fa060faa5f9"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-22 04:10:42.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-22 04:10:42.000000000","tz":-420},"subject":"Cleaned up mdns handler and added better test coverage","message":"Cleaned up mdns handler and added better test coverage\n\n- Added additional tests.\n- Fixed minor bug with notify log line.\n- Re-factored handle_axfr.\n\nChange-Id: I945c51330dae39f6d7d8384412ed7dc63abd46c1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5e0e4c194bf8ccb17e57c081e061ad580e6d800b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5e0e4c194bf8ccb17e57c081e061ad580e6d800b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}