)]}'
{"id":"openstack%2Fdesignate~673452","triplet_id":"openstack%2Fdesignate~master~I7e657d9fa4502621f48c6e40a7a2eb5e48a3ac3d","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"I7e657d9fa4502621f48c6e40a7a2eb5e48a3ac3d","subject":"Use zone.tenant_id as tenant if context.project_id is None","status":"MERGED","created":"2019-07-30 08:45:02.000000000","updated":"2019-08-06 17:36:19.000000000","submitted":"2019-08-06 17:36:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673452-1565112979883-172d8bd1","meta_rev_id":"93fa432c9a0a097d840945f7cab05252e59ba08d","_number":673452,"virtual_id_number":673452,"owner":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-08-06 17:36:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-31 04:34:58.000000000","_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-08-06 16:33:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2019-08-06 11:17:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},{"value":2,"date":"2019-07-31 03:29:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":1,"date":"2019-08-06 16:33:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 03:29:56.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-08-06 11:17:54.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-08-06 16:33:52.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-08-06 17:36:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"14277c51ecf35b4c513299ac7f071f674e18b313","author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"date":"2019-07-30 08:45:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7209ea12edcc6f283b2b9ca15898bce4ffd57cd0","author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"date":"2019-07-30 08:52:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"02245dcd3f6bb9039c91a4eaf155f3981c14c46b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 10:04:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/52/673452/2/check/designate-bind9/17ce145/ : SUCCESS in 42m 53s\n- designate-pdns4 http://logs.openstack.org/52/673452/2/check/designate-pdns4/e6dc3e4/ : SUCCESS in 39m 34s\n- designate-bind9-manager-model http://logs.openstack.org/52/673452/2/check/designate-bind9-manager-model/fc8c680/ : SUCCESS in 43m 26s\n- designate-bind9-py27 http://logs.openstack.org/52/673452/2/check/designate-bind9-py27/f07f6cf/ : SUCCESS in 47m 02s\n- designate-pdns4-py27 http://logs.openstack.org/52/673452/2/check/designate-pdns4-py27/c3ad0fb/ : SUCCESS in 40m 06s\n- designate-pdns4-postgres http://logs.openstack.org/52/673452/2/check/designate-pdns4-postgres/3e80f9e/ : FAILURE in 30m 57s (non-voting)\n- designate-grenade-pdns4 http://logs.openstack.org/52/673452/2/check/designate-grenade-pdns4/2723b71/ : SUCCESS in 1h 03m 17s\n- openstack-tox-cover http://logs.openstack.org/52/673452/2/check/openstack-tox-cover/5d589ec/cover/ : SUCCESS in 4m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/52/673452/2/check/openstack-tox-lower-constraints/a592c39/ : SUCCESS in 5m 09s\n- openstack-tox-pep8 http://logs.openstack.org/52/673452/2/check/openstack-tox-pep8/94a33af/ : SUCCESS in 5m 24s\n- openstack-tox-py27 http://logs.openstack.org/52/673452/2/check/openstack-tox-py27/fb4e36e/ : SUCCESS in 5m 30s\n- openstack-tox-py36 http://logs.openstack.org/52/673452/2/check/openstack-tox-py36/ce24069/ : SUCCESS in 4m 29s\n- openstack-tox-py37 http://logs.openstack.org/52/673452/2/check/openstack-tox-py37/a78b385/ : SUCCESS in 4m 38s\n- openstack-tox-docs http://logs.openstack.org/52/673452/2/check/openstack-tox-docs/ca95973/html/ : SUCCESS in 3m 44s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/52/673452/2/check/neutron-tempest-plugin-designate-scenario/c75e653/ : SUCCESS in 38m 32s","accounts_in_message":[],"_revision_number":2},{"id":"544fb5f796bee36f01c27b285e6bfbf7b014a842","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-30 22:49:29.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nThanks! Added some minor feedback.","accounts_in_message":[],"_revision_number":2},{"id":"a125276b97f2b5d57433107e6a6a239029ba4974","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-30 22:49:42.000000000","message":"Patch Set 2:\n\nIdeally if you have time could you add a simple test as well?","accounts_in_message":[],"_revision_number":2},{"id":"a76e8edb6b1fe951c2412eab2392c370f5700939","author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"date":"2019-07-31 03:05:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"42e9598f6cd79056b4485a391524bf82c90bbd75","author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"date":"2019-07-31 03:07:40.000000000","message":"Patch Set 3:\n\n(1 comment)\n\n\u003e Ideally if you have time could you add a simple test as well?\n\nActually, the \"context\" in our unit test doesn\u0027t contains \"project_id\". So the code here is covered by our unit test.","accounts_in_message":[],"_revision_number":3},{"id":"2370f76369e847b7f40af370cd1bc416264ef3f4","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-31 03:14:31.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n \u003e \n \u003e \u003e Ideally if you have time could you add a simple test as well?\n \u003e \n \u003e Actually, the \"context\" in our unit test doesn\u0027t contains\n \u003e \"project_id\". So the code here is covered by our unit test.\n\nWhy aren\u0027t the tests failing if project_id is missing?\n\nSince the following commit most things should be using project_id\nhttps://github.com/openstack/designate/commit/acbb803d17117a5dc0a72ff58fea57da0b6eb472\n\nBtw project_id comes from the oslo.context, so it\u0027s not directly defined in DesignateContext, but rather inherited.\nhttps://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L293","accounts_in_message":[],"_revision_number":3},{"id":"c74b756fcbb2817c851de83440fb947b159a24b4","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-31 03:25:53.000000000","message":"Patch Set 3:\n\nI think I see what you mean with the tests. They never actually set a tenant or project id.","accounts_in_message":[],"_revision_number":3},{"id":"0dde5ed50a64ea4d926be50b6fbe94718a00dc59","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-31 03:29:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0c7975cc15d97d76dd1b916be726b3e072dae732","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-31 03:41:19.000000000","message":"Patch Set 3:\n\nLooks good. Probably a bug with the powerdns implementation as well. I think we can merge this, but might be worth changing RecoverShard as well to just pass on the tenant_id to all backends.","accounts_in_message":[],"_revision_number":3},{"id":"98e7a569c3c57ca26c2e5d3f4ce25db53ac9aac4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 04:07:53.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- designate-bind9 http://logs.openstack.org/52/673452/3/check/designate-bind9/a679d13/ : SUCCESS in 37m 47s\n- designate-pdns4 http://logs.openstack.org/52/673452/3/check/designate-pdns4/0536bf6/ : SUCCESS in 39m 09s\n- designate-bind9-manager-model http://logs.openstack.org/52/673452/3/check/designate-bind9-manager-model/bb70d22/ : SUCCESS in 35m 04s\n- designate-bind9-py27 http://logs.openstack.org/52/673452/3/check/designate-bind9-py27/d366fdc/ : SUCCESS in 50m 24s\n- designate-pdns4-py27 http://logs.openstack.org/52/673452/3/check/designate-pdns4-py27/2eae7d5/ : SUCCESS in 57m 59s\n- designate-pdns4-postgres http://logs.openstack.org/52/673452/3/check/designate-pdns4-postgres/37bdd26/ : FAILURE in 35m 37s (non-voting)\n- designate-grenade-pdns4 http://logs.openstack.org/52/673452/3/check/designate-grenade-pdns4/9849225/ : FAILURE in 42m 41s\n- openstack-tox-cover http://logs.openstack.org/52/673452/3/check/openstack-tox-cover/7a36cf7/cover/ : SUCCESS in 6m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/52/673452/3/check/openstack-tox-lower-constraints/880418b/ : SUCCESS in 4m 29s\n- openstack-tox-pep8 http://logs.openstack.org/52/673452/3/check/openstack-tox-pep8/ba18d20/ : SUCCESS in 3m 41s\n- openstack-tox-py27 http://logs.openstack.org/52/673452/3/check/openstack-tox-py27/f4f142a/ : SUCCESS in 3m 55s\n- openstack-tox-py36 http://logs.openstack.org/52/673452/3/check/openstack-tox-py36/4773b17/ : SUCCESS in 5m 38s\n- openstack-tox-py37 http://logs.openstack.org/52/673452/3/check/openstack-tox-py37/e2ca967/ : SUCCESS in 6m 12s\n- openstack-tox-docs http://logs.openstack.org/52/673452/3/check/openstack-tox-docs/4771da7/html/ : SUCCESS in 3m 17s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/52/673452/3/check/neutron-tempest-plugin-designate-scenario/dc34a6c/ : SUCCESS in 34m 43s","accounts_in_message":[],"_revision_number":3},{"id":"f5dee341b4f4c17f73619a03db2031745be30b5c","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-31 04:28:49.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"12d13d88ee373bd72185120042b1e3197bf3d72a","author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"date":"2019-07-31 04:34:58.000000000","message":"Patch Set 3:\n\n\u003e Looks good. Probably a bug with the powerdns implementation as\n \u003e well. I think we can merge this, but might be worth changing\n \u003e RecoverShard as well to just pass on the tenant_id to all backends.\n\nyes, agree! But seems a  little difficult. I checked the code and found the \"context\" in RecoverShard function is come from producer WorkerPeriodicRecovery() function.  As the following code line show:  https://github.com/openstack/designate/blob/master/designate/producer/tasks.py#L291.\nSeems we can\u0027t get the project_id here. Don\u0027t find a good way to pass it to RecoverShard.","accounts_in_message":[],"_revision_number":3},{"id":"4c83d6ef470a90823a59473cac76ab9c53e53dcb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 05:37:25.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 http://logs.openstack.org/52/673452/3/check/designate-bind9/132abfc/ : SUCCESS in 38m 41s\n- designate-pdns4 http://logs.openstack.org/52/673452/3/check/designate-pdns4/83170b5/ : SUCCESS in 37m 43s\n- designate-bind9-manager-model http://logs.openstack.org/52/673452/3/check/designate-bind9-manager-model/76c6ab5/ : SUCCESS in 39m 39s\n- designate-bind9-py27 http://logs.openstack.org/52/673452/3/check/designate-bind9-py27/83a6558/ : SUCCESS in 41m 58s\n- designate-pdns4-py27 http://logs.openstack.org/52/673452/3/check/designate-pdns4-py27/5eaf905/ : SUCCESS in 38m 53s\n- designate-pdns4-postgres http://logs.openstack.org/52/673452/3/check/designate-pdns4-postgres/b5ca04f/ : FAILURE in 29m 51s (non-voting)\n- designate-grenade-pdns4 http://logs.openstack.org/52/673452/3/check/designate-grenade-pdns4/60c3552/ : SUCCESS in 1h 01m 53s\n- openstack-tox-cover http://logs.openstack.org/52/673452/3/check/openstack-tox-cover/fdbbb72/cover/ : SUCCESS in 4m 49s\n- openstack-tox-lower-constraints http://logs.openstack.org/52/673452/3/check/openstack-tox-lower-constraints/189d4ba/ : SUCCESS in 3m 12s\n- openstack-tox-pep8 http://logs.openstack.org/52/673452/3/check/openstack-tox-pep8/288b76c/ : SUCCESS in 4m 23s\n- openstack-tox-py27 http://logs.openstack.org/52/673452/3/check/openstack-tox-py27/1a8d4a1/ : SUCCESS in 4m 39s\n- openstack-tox-py36 http://logs.openstack.org/52/673452/3/check/openstack-tox-py36/96fe0c4/ : SUCCESS in 5m 58s\n- openstack-tox-py37 http://logs.openstack.org/52/673452/3/check/openstack-tox-py37/a121517/ : SUCCESS in 4m 56s\n- openstack-tox-docs http://logs.openstack.org/52/673452/3/check/openstack-tox-docs/afa56a8/html/ : SUCCESS in 4m 55s\n- neutron-tempest-plugin-designate-scenario http://logs.openstack.org/52/673452/3/check/neutron-tempest-plugin-designate-scenario/1e60a3e/ : SUCCESS in 34m 28s","accounts_in_message":[],"_revision_number":3},{"id":"1976a95ff9aaa6cc787663bd05ec9e3ba19a8c9e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-06 11:17:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8990cca0e61557460990ce08e72270a8b6d07cf1","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-08-06 16:33:52.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"d6038cee07f9f4219814b2ae3b425bed86e2a3a0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 16:34:12.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"b5b5a8f96b4fe58f0ca36c4edbc116bae358ee37","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 17:36:19.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://logs.opendev.org/52/673452/3/gate/designate-bind9/3fd963e/ : SUCCESS in 46m 02s\n- designate-pdns4 https://logs.opendev.org/52/673452/3/gate/designate-pdns4/cb8dbed/ : SUCCESS in 37m 48s\n- designate-bind9-manager-model https://logs.opendev.org/52/673452/3/gate/designate-bind9-manager-model/8311a18/ : SUCCESS in 39m 56s\n- designate-bind9-py27 https://logs.opendev.org/52/673452/3/gate/designate-bind9-py27/4ac2ae7/ : SUCCESS in 47m 34s\n- designate-pdns4-py27 https://logs.opendev.org/52/673452/3/gate/designate-pdns4-py27/e2b58cb/ : SUCCESS in 42m 33s\n- designate-grenade-pdns4 https://logs.opendev.org/52/673452/3/gate/designate-grenade-pdns4/dbec14e/ : SUCCESS in 54m 26s\n- openstack-tox-lower-constraints https://logs.opendev.org/52/673452/3/gate/openstack-tox-lower-constraints/aace48e/ : SUCCESS in 4m 17s\n- openstack-tox-pep8 https://logs.opendev.org/52/673452/3/gate/openstack-tox-pep8/4728413/ : SUCCESS in 4m 07s\n- openstack-tox-py27 https://logs.opendev.org/52/673452/3/gate/openstack-tox-py27/8d2c513/ : SUCCESS in 4m 28s\n- openstack-tox-py36 https://logs.opendev.org/52/673452/3/gate/openstack-tox-py36/736d3f2/ : SUCCESS in 3m 58s\n- openstack-tox-py37 https://logs.opendev.org/52/673452/3/gate/openstack-tox-py37/09779fb/ : SUCCESS in 5m 15s\n- openstack-tox-docs https://logs.opendev.org/52/673452/3/gate/openstack-tox-docs/73ec934/html/ : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":3},{"id":"93fa432c9a0a097d840945f7cab05252e59ba08d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 17:36:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1ac2c8db9af6941be4ca936b3b6c53f051dff6c7","revisions":{"e52ec8a1bc84847e759ea9c5b39f1d452de52b44":{"kind":"REWORK","_number":1,"created":"2019-07-30 08:45:02.000000000","uploader":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"ref":"refs/changes/52/673452/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/52/673452/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/52/673452/1"}}},"commit":{"parents":[{"commit":"076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1","subject":"Merge \"Improve log message for better understanding\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1"}]}],"author":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-30 08:29:38.000000000","tz":-420},"committer":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-30 08:43:19.000000000","tz":-420},"subject":"Use zone.tenant_id as tenant if context.project_id is None","message":"Use zone.tenant_id as tenant if context.project_id is None\n\nWhen enable multi-tenant in infoblox integration, designate infoblox\nplugin need to get dns view. The input of this function is project_id in\ncontext. But when do periodic recovery job, the context is generated via\ninit DesignateContext. We don\u0027t set project_id in it. So use\nzone.tenant_id instead on this situation.\n\nChange-Id: I7e657d9fa4502621f48c6e40a7a2eb5e48a3ac3d\nCloses-Bug: #1838379\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e52ec8a1bc84847e759ea9c5b39f1d452de52b44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e52ec8a1bc84847e759ea9c5b39f1d452de52b44"}]},"branch":"refs/heads/master"},"471b3e1fdb9b9c1ddc7c71f44b25562c04cd5c5b":{"kind":"REWORK","_number":2,"created":"2019-07-30 08:52:54.000000000","uploader":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"ref":"refs/changes/52/673452/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/52/673452/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/52/673452/2"}}},"commit":{"parents":[{"commit":"076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1","subject":"Merge \"Improve log message for better understanding\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1"}]}],"author":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-30 08:29:38.000000000","tz":-420},"committer":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-30 08:50:56.000000000","tz":-420},"subject":"Use zone.tenant_id as tenant if context.project_id is None","message":"Use zone.tenant_id as tenant if context.project_id is None\n\nWhen enable multi-tenant in infoblox integration, designate infoblox\nplugin need to get dns view. The input of this function is project_id in\ncontext. But when do periodic recovery job, the context is generated via\ninit DesignateContext. We don\u0027t set project_id in it. So use\nzone.tenant_id instead on this situation.\n\nCloses-Bug: #1838379\n\nChange-Id: I7e657d9fa4502621f48c6e40a7a2eb5e48a3ac3d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/471b3e1fdb9b9c1ddc7c71f44b25562c04cd5c5b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/471b3e1fdb9b9c1ddc7c71f44b25562c04cd5c5b"}]},"branch":"refs/heads/master"},"1ac2c8db9af6941be4ca936b3b6c53f051dff6c7":{"kind":"REWORK","_number":3,"created":"2019-07-31 03:05:58.000000000","uploader":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"ref":"refs/changes/52/673452/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/52/673452/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/673452/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/52/673452/3"}}},"commit":{"parents":[{"commit":"076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1","subject":"Merge \"Improve log message for better understanding\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/076f9fce0ac95b4b628f0d95cfe6e04b7b3988c1"}]}],"author":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-30 08:29:38.000000000","tz":-420},"committer":{"name":"Damon Li","email":"damonl@vmware.com","date":"2019-07-31 03:04:03.000000000","tz":-420},"subject":"Use zone.tenant_id as tenant if context.project_id is None","message":"Use zone.tenant_id as tenant if context.project_id is None\n\nWhen enable multi-tenant in infoblox integration, designate infoblox\nplugin need to get dns view. The input of this function is project_id in\ncontext. But when do periodic recovery job, the context is generated via\ninit DesignateContext. We don\u0027t set project_id in it. So use\nzone.tenant_id instead on this situation.\n\nCloses-Bug: #1838379\n\nChange-Id: I7e657d9fa4502621f48c6e40a7a2eb5e48a3ac3d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/1ac2c8db9af6941be4ca936b3b6c53f051dff6c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/1ac2c8db9af6941be4ca936b3b6c53f051dff6c7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}