)]}'
{"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d5a14951fb17e693896f757453466cdfb21762a2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return True"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _is_valid_recordset_placement_subdomain(self, context, domain,"},{"line_number":161,"context_line":"                                                record_name, criterion\u003dNone):"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        Check that the placement of the requested rrset is within a domain and"},{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9OE%3D","line":161,"updated":"2014-01-20 12:39:03.000000000","message":"We\u0027re reading with recordset\u0027s here, so can record_name be updated to recordset_name?","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"e5026b9e793a1b83edbe444ee045b845280b9b94","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return True"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _is_valid_recordset_placement_subdomain(self, context, domain,"},{"line_number":161,"context_line":"                                                record_name, criterion\u003dNone):"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        Check that the placement of the requested rrset is within a domain and"},{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9Mg%3D","line":161,"in_reply_to":"AAAAUH%2F%2B9OE%3D","updated":"2014-01-20 12:49:42.000000000","message":"Done","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d5a14951fb17e693896f757453466cdfb21762a2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                                record_name, criterion\u003dNone):"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        Check that the placement of the requested rrset is within a domain and"},{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        LOG.debug(\"Checking %s, %s\", domain[\u0027name\u0027], record_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9OA%3D","line":164,"updated":"2014-01-20 12:39:03.000000000","message":"This comment doesn\u0027t describe what this methods actually does. Can we update it?","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"e5026b9e793a1b83edbe444ee045b845280b9b94","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                                record_name, criterion\u003dNone):"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        Check that the placement of the requested rrset is within a domain and"},{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        LOG.debug(\"Checking %s, %s\", domain[\u0027name\u0027], record_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9MM%3D","line":164,"in_reply_to":"AAAAUH%2F%2B9OA%3D","updated":"2014-01-20 12:49:42.000000000","message":"Done","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d5a14951fb17e693896f757453466cdfb21762a2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        LOG.debug(\"Checking %s, %s\", domain[\u0027name\u0027], record_name)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        criterion \u003d criterion or {}"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9Ok%3D","line":167,"updated":"2014-01-20 12:39:03.000000000","message":"Can we update the message here to be more descriptive over what it\u0027s checking?\n\nIn 6 months, when staring at the logs, this isn\u0027t going to give anywhere near enough info to be understandable.","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"e5026b9e793a1b83edbe444ee045b845280b9b94","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        that there\u0027s no subdomain between the record and the domain."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        LOG.debug(\"Checking %s, %s\", domain[\u0027name\u0027], record_name)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        criterion \u003d criterion or {}"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9MA%3D","line":167,"in_reply_to":"AAAAUH%2F%2B9Ok%3D","updated":"2014-01-20 12:49:42.000000000","message":"Done","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d5a14951fb17e693896f757453466cdfb21762a2","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            except Exception:"},{"line_number":184,"context_line":"                continue"},{"line_number":185,"context_line":"            else:"},{"line_number":186,"context_line":"                msg \u003d \u0027RecordSet belongs in a child zone.. %s\u0027 % \\"},{"line_number":187,"context_line":"                    child_domain[\u0027name\u0027]"},{"line_number":188,"context_line":"                raise exceptions.InvalidRecordSetLocation(msg)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9O8%3D","line":186,"updated":"2014-01-20 12:39:03.000000000","message":"Can we swap the message for \"RecordSet belongs in a child zone: %s\"","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"e5026b9e793a1b83edbe444ee045b845280b9b94","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            except Exception:"},{"line_number":184,"context_line":"                continue"},{"line_number":185,"context_line":"            else:"},{"line_number":186,"context_line":"                msg \u003d \u0027RecordSet belongs in a child zone.. %s\u0027 % \\"},{"line_number":187,"context_line":"                    child_domain[\u0027name\u0027]"},{"line_number":188,"context_line":"                raise exceptions.InvalidRecordSetLocation(msg)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9Ls%3D","line":186,"in_reply_to":"AAAAUH%2F%2B9O8%3D","updated":"2014-01-20 12:49:42.000000000","message":"Done","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d5a14951fb17e693896f757453466cdfb21762a2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        Check that the placement of the requested name is within a zone and"},{"line_number":205,"context_line":"        that there\u0027s no existing record in a parent domain with the name."},{"line_number":206,"context_line":"        \"\"\""},{"line_number":207,"context_line":"        context \u003d context.elevated()"},{"line_number":208,"context_line":"        context.all_tenants \u003d True"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9PE%3D","line":206,"updated":"2014-01-20 12:39:03.000000000","message":"This comment doesn\u0027t describe what this methods actually does. Let\u0027s remove this one","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"e5026b9e793a1b83edbe444ee045b845280b9b94","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        Check that the placement of the requested name is within a zone and"},{"line_number":205,"context_line":"        that there\u0027s no existing record in a parent domain with the name."},{"line_number":206,"context_line":"        \"\"\""},{"line_number":207,"context_line":"        context \u003d context.elevated()"},{"line_number":208,"context_line":"        context.all_tenants \u003d True"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9Lc%3D","line":206,"in_reply_to":"AAAAUH%2F%2B9PE%3D","updated":"2014-01-20 12:49:42.000000000","message":"removed","commit_id":"371e3f9a7e0322564da04c39f23c34efa825029c"}]}